From: "Yajun Deng" <yajun.deng@linux.dev>
To: "Daniel Bristot de Oliveira" <bristot@redhat.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, bsegall@google.com,
vschneid@redhat.com, rostedt@goodmis.org, mgorman@suse.de,
vincent.guittot@linaro.org
Subject: Re: [PATCH] sched/deadline: Use proc_douintvec_minmax() limit minimum value
Date: Tue, 07 Jun 2022 08:35:56 +0000 [thread overview]
Message-ID: <9150a4ffa0ff94ab4697d615c60ed9b4@linux.dev> (raw)
In-Reply-To: <46b7ca44-a338-e1c1-e005-326e89576211@redhat.com>
June 7, 2022 3:55 PM, "Daniel Bristot de Oliveira" <bristot@redhat.com> wrote:
> Hi Yajun
>
> On 5/13/22 04:41, Yajun Deng wrote:
>
>> proc_dointvec() is not applicable for unsigned integer, use
>> proc_douintvec_minmax() limit minimum value.
>
> I understand your patch, but your log message is somehow incomplete.
>
> Could you expand on that, showing the problem using an example, and then how you
> see it fixed?
>
This patch isn't a fix. It's just an optimization for match data and proc_handler in struct ctl_table.
> Also, could you please add the Fixes: tag so this patch can land on stable trees?
>
This statement 'if (period < min || period > max)' in __checkparam_dl() will work fine even if there hasn't this patch.
So this patch may not need land on stable trees.
> -- Daniel
next prev parent reply other threads:[~2022-06-07 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 2:41 [PATCH] sched/deadline: Use proc_douintvec_minmax() limit minimum value Yajun Deng
2022-06-07 1:26 ` Yajun Deng
2022-06-07 7:55 ` Daniel Bristot de Oliveira
2022-06-07 8:35 ` Yajun Deng [this message]
2022-06-07 8:45 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9150a4ffa0ff94ab4697d615c60ed9b4@linux.dev \
--to=yajun.deng@linux.dev \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.