From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C39E3C61D90 for ; Tue, 21 Nov 2023 18:27:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5VSQ-0005Xt-IM; Tue, 21 Nov 2023 13:26:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5VSO-0005XL-B5; Tue, 21 Nov 2023 13:26:44 -0500 Received: from mail.ozlabs.org ([2404:9400:2221:ea00::3] helo=gandalf.ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5VSM-00034g-Fo; Tue, 21 Nov 2023 13:26:44 -0500 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4SZXrt2qLvz4wy1; Wed, 22 Nov 2023 05:26:38 +1100 (AEDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SZXrr4yRYz4wx5; Wed, 22 Nov 2023 05:26:36 +1100 (AEDT) Message-ID: <915bf0d2-4600-4666-95a5-752fbb9f034f@kaod.org> Date: Tue, 21 Nov 2023 19:26:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/11] ppc/pnv: New powernv10-rainier machine type Content-Language: en-US To: Miles Glenn , Nicholas Piggin , qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: =?UTF-8?B?RnLDqWTDqXJpYyBCYXJyYXQ=?= References: <20231120235112.1951342-1-milesg@linux.vnet.ibm.com> <20231120235112.1951342-4-milesg@linux.vnet.ibm.com> <31af40b3-a6c8-467c-8ef0-63e370465a9a@kaod.org> <2e0854faea5c520512f903420f91f153e3287532.camel@linux.vnet.ibm.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: <2e0854faea5c520512f903420f91f153e3287532.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2404:9400:2221:ea00::3; envelope-from=SRS0=nm9w=HC=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/21/23 17:36, Miles Glenn wrote: > On Tue, 2023-11-21 at 08:29 +0100, Cédric Le Goater wrote: >> On 11/21/23 02:33, Nicholas Piggin wrote: >>> On Tue Nov 21, 2023 at 9:51 AM AEST, Glenn Miles wrote: >>>> Create a new powernv machine type, powernv10-rainier, that >>>> will contain rainier-specific devices. >>> >>> Is the plan to have a base powernv10 common to all and then >>> powernv10-rainier looks like a Rainier? Or would powernv10 >>> just be a rainier? >>> >>> It's fine to structure code this way, I'm just wondering about >>> the machine types available to user. Is a base powernv10 machine >>> useful to run? >> >> There are multiple P10 boards defined in Linux : >> >> aspeed-bmc-ibm-bonnell.dts >> aspeed-bmc-ibm-everest.dts >> aspeed-bmc-ibm-rainier-1s4u.dts >> aspeed-bmc-ibm-rainier-4u.dts >> aspeed-bmc-ibm-rainier.dts >> >> and we could model the machines above with a fixed number of sockets. >> The "powernv10" would be the generic system that can be customized >> at will on the command line, even I2C devices. There is also the >> P10 Denali which is FSP based. This QEMU machine would certainly be >> very different. I thought of doing the same for P9 with a -zaius >> and include NPU2 models for it. I lacked time and the interest was >> small at the time of OpenPOWER. >> >> Anyhow, adding a new machine makes sense and it prepares ground for >> possible new ones. I am OK with or without. As primary users, you are >> the ones that can tell if there will be a second machine. >> >> Thanks, >> >> C. >> > > I am not sure what the powernv10 machine would be used for. The > only reason I kept it was because I didn't want to break anyone out > there that might be using it. (previous email sent to fast) You would need to go through the deprecation process [1] if you want to remove the machine. I suggest keeping it for now since it is two lines of type definition. > My preference would have been to just make powernv10-rainier an > alias of the powernv10 machine, but only one alias name per machine > is supported and there is already a plan to make "powernv" an > alias for the powernv10 machine. yes. It might be time now for PowerNV and pSeries to update the default processor. Let's address that in the QEMU 9.0 cycle. Thanks, C. [1] https://qemu.readthedocs.io/en/v8.1.0/about/deprecated.html