From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, Jonas Pfefferle1 <JPF@zurich.ibm.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [PATCH] bus/pci: fix vfio device reset
Date: Tue, 31 Oct 2017 19:24:42 +0100 [thread overview]
Message-ID: <9161630.57FQBGedkL@xps> (raw)
In-Reply-To: <OF54C5FC0A.14218344-ON002581C7.003AD241-C12581C7.003BE7A1@notes.na.collabserv.com>
28/10/2017 12:54, Jonas Pfefferle1:
> Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote on 28/10/2017 08:22:55:
> > If the device is not capable of resetting, then Linux kernel updates
> > the errno as EINVAL.
> > https://urldefense.proofpoint.com/v2/url?
> > u=http-3A__elixir.free-2Delectrons.com_linux_v4.
> > 9_source_drivers_vfio_pci_vfio-5Fpci.c-23L887&d=DwIBAg&c=jf_iaSHvJObTbx-
> > siA1ZOg&r=rOdXhRsgn8Iur7bDE0vgwvo6TC8OpoDN-pXjigIjRW0&m=V-
> > sbOkvx7qxOMbwyk3n1Fb_1NCjAhl0io-
> > hqldJ0r6M&s=OXV7lrxTpahVIsA3J3nCNUlLqW21nlMiQiYveAzyQhc&e=
> >
> > Honor the EINVAL errno value to avoid pci vfio setup failure.
> >
> > Fixes: f25f8f367644 ("bus/pci: check VFIO reset ioctl error")
> >
> > Cc: Jonas Pfefferle <jpf@zurich.ibm.com>
> > Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> Looks good to me.
>
> Reviewed-by: Jonas Pfefferle <jpf@zurich.ibm.com>
>
> Thanks,
> Jonas
Applied, thanks
prev parent reply other threads:[~2017-10-31 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 6:22 [PATCH] bus/pci: fix vfio device reset Jerin Jacob
2017-10-28 10:54 ` Jonas Pfefferle1
2017-10-31 18:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9161630.57FQBGedkL@xps \
--to=thomas@monjalon.net \
--cc=JPF@zurich.ibm.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.