From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A65EC47258 for ; Tue, 23 Jan 2024 20:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qmjKMue7ibcqMWRxvpEmpjzzlX86G4h6xr8oQon7NdM=; b=1Tk2il5DKmRFLk 4mAINFqZbveJJxDrT+pvkJle8JCw6qj3Nc/hcN+HroIXqEQ0XJUujgrQDWQnBPRjDUyLZ8GJONeO9 mkkbkTt1RAwwex9mxLninJGnj2mTJTFlsiPOk1WwOfoqRbmXzH/AY6QZ72+3cQdEhFxAZeOgRFB5Y c0HwvyCGdgPUtvKb8xuev3acEmMdyEyaJfqIWMs+KEzEb+KiOpM4/pqTRzqzjpevcgD+gO74uEXkL veUjsRnQmwtUL0xxnYsFRiHyGO93T26wQuGRFU095T8NsOoHYx8nmS9WGST3X2pPYSwPs5rPD2//f 26JHX8/0PExCfZtHSzig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSN3U-000LOT-0m; Tue, 23 Jan 2024 20:07:32 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSN3Q-000LMg-2f for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 20:07:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 45AC0CE300A; Tue, 23 Jan 2024 20:07:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03F66C433C7; Tue, 23 Jan 2024 20:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706040444; bh=qrTeZ90kKPIGHQj7Duz55R7K3bWxn9tvPLy0f4FBIh8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lyYcwTIr2hK9QPWsLjktNe77EKjomPt43dViYbpzFU8v2prv6n22QxXcwo57Dyxx7 +jeXGJyVro1ruwRCVSZztVV37pWrdeJ7OZNq+R1HciKQttk4O0fUbQr01bpayzMZlX KmOgx2l9400a9/bcNO4Fc+QQ2uvZtCCbegwBRQw9TC6dSigsbt2MhJZe+g5jU4SrLM btaa43cP2JaYQU8ABAXfS47B2NNJW2undFZY9mDFdvWHn0yYYfx37db1dUOW53aSR0 Z9BQKlPHQ5hVByEIQmFOZy9F04dELGFTEBSeEdkGXoesNGVYD7ZnLaYBfWijZKkWE2 utvXdqqKeWy1g== Message-ID: <9185e0b8-5e72-4b53-830b-bc2fb99ad76a@kernel.org> Date: Tue, 23 Jan 2024 22:07:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: ti: am642-evm: Add overlay for NAND expansion card To: Andrew Davis , Nishanth Menon Cc: vigneshr@ti.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, srk@ti.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Siddharth Vadapalli References: <20230920133450.54226-1-rogerq@kernel.org> <20230920133450.54226-3-rogerq@kernel.org> <20230920135802.3ej2wcuaruqjidel@uncouth> <20230920164424.rrjvm6nvtv4ysyrw@unreal> <6f2b38f8-1962-46f2-a095-b1eaf99ed407@kernel.org> Content-Language: en-US From: Roger Quadros In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_120729_255764_306AA77D X-CRM114-Status: GOOD ( 26.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiAyMS8wOS8yMDIzIDIwOjIzLCBBbmRyZXcgRGF2aXMgd3JvdGU6Cj4gT24gOS8yMS8y MyA2OjM3IEFNLCBSb2dlciBRdWFkcm9zIHdyb3RlOgo+PiBPbiAyMC8wOS8yMDIzIDIwOjA2LCBB bmRyZXcgRGF2aXMgd3JvdGU6Cj4+PiBPbiA5LzIwLzIzIDExOjQ0IEFNLCBOaXNoYW50aCBNZW5v biB3cm90ZToKPj4+PiBPbiAxODoxOC0yMDIzMDkyMCwgUm9nZXIgUXVhZHJvcyB3cm90ZToKPj4+ Pj4KPj4+Pj4KPj4+Pj4gT24gMjAvMDkvMjAyMyAxNjo1OCwgTmlzaGFudGggTWVub24gd3JvdGU6 Cj4+Pj4+PiBPbiAxNjozNC0yMDIzMDkyMCwgUm9nZXIgUXVhZHJvcyB3cm90ZToKPj4+Pj4+PiBU aGUgTkFORCBleHBhbnNpb24gY2FyZCBwbHVncyBpbiBvdmVyIHRoZSBIU0UgKEhpZ2ggU3BlZWQg RXhwYW5zaW9uKQo+Pj4+Pj4+IGNvbm5lY3Rvci4gQWRkIHN1cHBvcnQgZm9yIGl0Lgo+Pj4+Pj4+ Cj4+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUXVhZHJvcyA8cm9nZXJxQGtlcm5lbC5vcmc+ Cj4+Pj4+Pj4gLS0tCj4+Pj4+Pj4gwqDCoCBhcmNoL2FybTY0L2Jvb3QvZHRzL3RpL01ha2VmaWxl wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqDCoCAxICsKPj4+Pj4+PiDCoMKgIGFyY2gv YXJtNjQvYm9vdC9kdHMvdGkvazMtYW02NDItZXZtLW5hbmQuZHRzbyB8IDE0MCArKysrKysrKysr KysrKysrKysKPj4+Pj4+PiDCoMKgIDIgZmlsZXMgY2hhbmdlZCwgMTQxIGluc2VydGlvbnMoKykK Pj4+Pj4+PiDCoMKgIGNyZWF0ZSBtb2RlIDEwMDY0NCBhcmNoL2FybTY0L2Jvb3QvZHRzL3RpL2sz LWFtNjQyLWV2bS1uYW5kLmR0c28KPj4+Pj4+Pgo+Pj4+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2Fy bTY0L2Jvb3QvZHRzL3RpL01ha2VmaWxlIGIvYXJjaC9hcm02NC9ib290L2R0cy90aS9NYWtlZmls ZQo+Pj4+Pj4+IGluZGV4IDA2ZDZmMjY0ZjI5Mi4uZWNlNzQwODVhNmJlIDEwMDY0NAo+Pj4+Pj4+ IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvdGkvTWFrZWZpbGUKPj4+Pj4+PiArKysgYi9hcmNo L2FybTY0L2Jvb3QvZHRzL3RpL01ha2VmaWxlCj4+Pj4+Pj4gQEAgLTI5LDYgKzI5LDcgQEAgZHRi LSQoQ09ORklHX0FSQ0hfSzMpICs9IGszLWFtNjJwNS1zay5kdGIKPj4+Pj4+PiDCoMKgIMKgICMg Qm9hcmRzIHdpdGggQU02NHggU29DCj4+Pj4+Pj4gwqDCoCBkdGItJChDT05GSUdfQVJDSF9LMykg Kz0gazMtYW02NDItZXZtLmR0Ygo+Pj4+Pj4+ICtkdGItJChDT05GSUdfQVJDSF9LMykgKz0gazMt YW02NDItZXZtLW5hbmQuZHRibwo+Pj4+Pj4+IMKgwqAgZHRiLSQoQ09ORklHX0FSQ0hfSzMpICs9 IGszLWFtNjQyLXBoeWJvYXJkLWVsZWN0cmEtcmRrLmR0Ygo+Pj4+Pj4+IMKgwqAgZHRiLSQoQ09O RklHX0FSQ0hfSzMpICs9IGszLWFtNjQyLXNrLmR0Ygo+Pj4+Pj4+IMKgwqAgZHRiLSQoQ09ORklH X0FSQ0hfSzMpICs9IGszLWFtNjQyLXRxbWE2NHh4bC1tYmF4NHh4bC5kdGIKPj4+Pj4+Cj4+Pj4+ PiBBbHNvIHNlZSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMzA5MTExNjU2MTAuR0Ex MzYyOTMyLXJvYmhAa2VybmVsLm9yZy8KPj4+Pj4+Cj4+Pj4+PiB5b3UgbWF5IG5vdCBnZXQgdGhl IGR0Ym8gaW5zdGFsbGVkIHdoZW4gZG9pbmcgbWFrZSBkdGJzX2luc3RhbGwKPj4+Pj4+Cj4+Pj4+ PiBbLi4uXQo+Pj4+Pj4KPj4+Pj4KPj4+Pj4gJCB2OG1ha2UgZHRic19pbnN0YWxsIElOU1RBTExf RFRCU19QQVRIPS90bXAKPj4+Pj4gwqDCoMKgIElOU1RBTEwgL3RtcC90aS9rMy1hbTYyNS1iZWFn bGVwbGF5LmR0Ygo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjI1LXBoeWJvYXJk LWx5cmEtcmRrLmR0Ygo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjI1LXNrLmR0 Ygo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjI1LXZlcmRpbi1ub253aWZpLWRh aGxpYS5kdGIKPj4+Pj4gwqDCoMKgIElOU1RBTEwgL3RtcC90aS9rMy1hbTYyNS12ZXJkaW4tbm9u d2lmaS1kZXYuZHRiCj4+Pj4+IMKgwqDCoCBJTlNUQUxMIC90bXAvdGkvazMtYW02MjUtdmVyZGlu LW5vbndpZmkteWF2aWEuZHRiCj4+Pj4+IMKgwqDCoCBJTlNUQUxMIC90bXAvdGkvazMtYW02MjUt dmVyZGluLXdpZmktZGFobGlhLmR0Ygo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFt NjI1LXZlcmRpbi13aWZpLWRldi5kdGIKPj4+Pj4gwqDCoMKgIElOU1RBTEwgL3RtcC90aS9rMy1h bTYyNS12ZXJkaW4td2lmaS15YXZpYS5kdGIKPj4+Pj4gwqDCoMKgIElOU1RBTEwgL3RtcC90aS9r My1hbTYyLWxwLXNrLmR0Ygo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjJ4LXNr LWhkbWktYXVkaW8uZHRibwo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjJhNy1z ay5kdGIKPj4+Pj4gwqDCoMKgIElOU1RBTEwgL3RtcC90aS9rMy1hbTYycDUtc2suZHRiCj4+Pj4+ IMKgwqDCoCBJTlNUQUxMIC90bXAvdGkvazMtYW02NDItZXZtLmR0Ygo+Pj4+PiDCoMKgwqAgSU5T VEFMTCAvdG1wL3RpL2szLWFtNjQyLWV2bS1uYW5kLmR0Ym8KPj4+Pj4gXl5eXgo+Pj4+PiDCoMKg wqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjQyLXBoeWJvYXJkLWVsZWN0cmEtcmRrLmR0Ygo+Pj4+ PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjQyLXNrLmR0Ygo+Pj4+Pgo+Pj4+Pgo+Pj4+ PiBXaGF0IGRpZCBJIG1pc3M/Cj4+Pj4KPj4+PiBJIG1pc3NlZCBpdCwgYWN0dWFsbHkuIFNlZSBS b2IncyBjb21tZW50Ogo+Pj4+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC9DQUxfSnNxK0dS M2hQNmhGdkZuMno1YVh2U1huaDlidXREM2FLWi15X1hKZ3gwX1lQVHdAbWFpbC5nbWFpbC5jb20v Cj4+Pj4KPj4+PiBIYXZpbmcgb3JwaGFuIGR0Ym8gaXMgYXBwYXJlbnRseSBmcm93bmVkIHVwb24K Pj4+Pgo+Pj4KPj4+IEFuZCBpZiB5b3UgYXBwbHkgdGhlc2Ugb3ZlcmxheXMgdG8gdGhlIGJhc2Ug RFRCIHRoZW4gaXQgZ2V0cwo+Pj4gc3ltYm9scyBhZGRlZCBhdXRvbWF0aWNhbGx5LCBubyBuZWVk IGZvciB5b3VyIHBhdGNoIFsxLzJdIGhlcmUuCj4+Pgo+Pgo+PiBJcyB0aGlzIE9LPwo+Pgo+PiDC oMKgwqDCoGszLWFtNjQyLWV2bS1uYW5kLWR0YnMgOj0gazMtYW02NDItZXZtLmR0YiBrMy1hbTY0 Mi1ldm0tbmFuZC5kdGJvCj4+IMKgwqDCoMKgZHRiLSQoQ09ORklHX0FSQ0hfSzMpICs9IGszLWFt NjQyLWV2bS1uYW5kLmR0Ygo+Pgo+PiBTbyBwYXRjaCAxIGlzIG5vdCByZXF1aXJlZCBpbiB0aGlz IGNhc2UgYnV0IHdlIGhhdmUgYW4KPj4gZXh0cmEgZHRiIGZpbGUgd2hpY2ggaXMgbm90IHJlYWxs eSByZXF1aXJlZC4KPj4KPiAKPiBXaGlsZSBJIGFncmVlIHdlIHdpbGwgZW5kIHVwIHdpdGggc2V2 ZXJhbCBwcmUtb3ZlcmxheWVkIERUQiBmaWxlcwo+IHRoYXQgYXJlIGFyZ3VhYmx5IG5vdCByZXF1 aXJlZCBhcyB0aGV5IGNvdWxkIGJlIGxhdGVyIGJ1aWx0L2FwcGxpZWQsCj4gdW50aWwgd2UgZmlu ZCBhIGJldHRlciB3YXkgdG8gY2hlY2sgYXQgYnVpbGQgdGltZSB0aGVzZSBvdmVybGF5cwo+IG5l ZWQgYXBwbGllZCB0byBzb21ldGhpbmcgYXMgYSB0ZXN0Lgo+IAo+PiBJIGhhdmUgMiBtb3JlIGlz c3VlcyB0byBwb2ludCBvdXQKPj4KPj4gMSkKPj4gV2l0aCBleGlzdGluZyBleGFtcGxlcyBlLmcu IEo3MjAwIEVWTQo+PiB3b3VsZG4ndMKgIGszLWo3MjAwLWV2bS5kdGIgaW5jbHVkZSB0aGUgazMt ajcyMDAtZXZtLXF1YWQtcG9ydC1ldGgtZXhwLmR0Ym8/Cj4+IElzIHRoaXMgd2hhdCB3ZSByZWFs bHkgd2FudD8KPj4KPj4gbGlrZXdpc2UgZm9yIGszLWo3MjFlLWV2bS5kdGIgYW5kIGszLWFtNjU0 LWdwLWV2bS5kdGIKPj4KPiAKPiBZZXMsIHRoYXQgaXMgdGhlIGlkZWEsIHRoZSBiYXNlLWJvYXJk LmR0YiBpcyBqdXN0IHRoZSByYXcgbWFpbiBib2FyZCwgYnV0Cj4gdGhlICJFVk0iIHdoZW4geW91 IGJ1eSBpdCBjb21lcyB3aXRoIHRoZSBxdWFkLXBvcnQgZGF1Z2h0ZXJjYXJkIGF0dGFjaGVkLgo+ IFRoYXQgaXMgd2hhdCB3ZSBjb25zaWRlciB0aGUgIkVWTSIgYW5kIHRoZSBEVEIgbmFtZXMgbWF0 Y2ggdGhhdC4KPiAKPj4gMikKPj4gQW5vdGhlciBpc3N1ZSAodW5yZWxhdGVkIHRvIHRoaXMgY2hh bmdlKSBpcyB0aGUgYmVsb3cgd2FybmluZzoKPj4KPj4gwqDCoMKgwqBhcmNoL2FybTY0L2Jvb3Qv ZHRzL3RpL2szLWFtNjQyLWV2bS1uYW5kLmR0c286NjUuOC0xNDAuMzogV2FybmluZyAoYXZvaWRf ZGVmYXVsdF9hZGRyX3NpemUpOiAvZnJhZ21lbnRAMy9fX292ZXJsYXlfXzogUmVseWluZyBvbiBk ZWZhdWx0ICNhZGRyZXNzLWNlbGxzIHZhbHVlCj4+IMKgwqDCoMKgYXJjaC9hcm02NC9ib290L2R0 cy90aS9rMy1hbTY0Mi1ldm0tbmFuZC5kdHNvOjY1LjgtMTQwLjM6IFdhcm5pbmcgKGF2b2lkX2Rl ZmF1bHRfYWRkcl9zaXplKTogL2ZyYWdtZW50QDMvX19vdmVybGF5X186IFJlbHlpbmcgb24gZGVm YXVsdCAjc2l6ZS1jZWxscyB2YWx1ZQo+Pgo+PiBUaGlzIGlzIGJlY2F1c2Ugd2UgdXNlIHRoZSAn cmFuZ2VzJyBwcm9wZXJ0eSBpbiB0aGUgZ3BtYzAgbm9kZQo+PiBhbmQgdGhlIGNvbXBpbGVyIGRv ZXNuJ3Qga25vdyB0aGUgI2FkZHJlc3Mvc2l6ZS1jZWxscyBvZiB0aGUKPj4gcGFyZW50IG5vZGUu Cj4+Cj4+IElzIHRoZXJlIGEgdHJpY2sgdG8gc3BlY2lmeSBpdCBpbiB0aGUgZHRzbyBmaWxlPwo+ Pgo+IAo+IEhtbSwgc2VlbXMgbGlrZSBhIHRyaWNreSBvbmUuIERvIHlvdSByZWFsbHkgbmVlZCB0 byBkbyB0aGUgcmFuZ2VzIGhlcmU/Cj4gQ291bGQgeW91IHVzZSB0aGUgZGVmYXVsdCBgcmFuZ2Vz O2AgZm9yIGdwbWMwPyBUaGVuIGRvIHRoZSByYW5nZSB0cmFuc2xhdGlvbgo+IGRvd24gaW5zaWRl IHRoZSBuYW5kIG5vZGUgdG8ga2VlcCB0aGUgcGFydGl0aW9uIGFkZHJlc3NlcyBzYW5lLgoKSSB0 aGluayB3ZSBuZWVkIHRvIGdvIGRvd24gdGhpcyByb3V0ZS4KCllvdXIgc3VnZ2VzdGlvbiBhYm91 dCB1c2luZyByYW5nZXMgaW4gZ3BtYzAgbm9kZSBpbiB0aGUgRVZNIERUIGZpbGUgaXMKZmluZSBJ IGd1ZXNzIGFzIGZvciB0aGlzIGJvYXJkIHRoZXJlIGlzIG5vIG90aGVyIHVzZSBjYXNlIGZvciBH UE1DLgpTbyBpdCBzaG91bGQgYmUgT0sgdG8gcmVzZXJ2ZSBDaGlwIFNlbGVjdDAgYWRkcmVzcyBz cGFjZSBhdCBrMy1hbTY0Mi1ldm0uZHRzCgotLSAKY2hlZXJzLAotcm9nZXIKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13E4582D89; Tue, 23 Jan 2024 20:07:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706040445; cv=none; b=lORvcEz1Mz3YSIULpDg9JMZY3LvbdxQvfaOeFxQjWX5/r7EJ9wKKaFevTS0pLloPyXZiqbpjKyZYFrwUWzd4W2Zj9XGCq3WFMj7njjcu+jTHZepDZ8Wi4lSO/YaqlcibLKtandql47sdEFGSZl0fsnZiKkOU9tJVmbGlLyWgopg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706040445; c=relaxed/simple; bh=qrTeZ90kKPIGHQj7Duz55R7K3bWxn9tvPLy0f4FBIh8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uAMUWPpCCI5S2jkxCjDL4u6jtnKx3xk+FYMnHSffuJTVP9PrhG+6TA6Zad5/hB9sjhvkTPHiCalFvqg9SKPQ1JGGrXTdIi6QlTPfmmZpqGlRE23oeZsxQxSQ7T65B1SAzvPvlHmy11BXX88dASPGsssjF4eowtoPrWvkMDz6Lyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lyYcwTIr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lyYcwTIr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03F66C433C7; Tue, 23 Jan 2024 20:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706040444; bh=qrTeZ90kKPIGHQj7Duz55R7K3bWxn9tvPLy0f4FBIh8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lyYcwTIr2hK9QPWsLjktNe77EKjomPt43dViYbpzFU8v2prv6n22QxXcwo57Dyxx7 +jeXGJyVro1ruwRCVSZztVV37pWrdeJ7OZNq+R1HciKQttk4O0fUbQr01bpayzMZlX KmOgx2l9400a9/bcNO4Fc+QQ2uvZtCCbegwBRQw9TC6dSigsbt2MhJZe+g5jU4SrLM btaa43cP2JaYQU8ABAXfS47B2NNJW2undFZY9mDFdvWHn0yYYfx37db1dUOW53aSR0 Z9BQKlPHQ5hVByEIQmFOZy9F04dELGFTEBSeEdkGXoesNGVYD7ZnLaYBfWijZKkWE2 utvXdqqKeWy1g== Message-ID: <9185e0b8-5e72-4b53-830b-bc2fb99ad76a@kernel.org> Date: Tue, 23 Jan 2024 22:07:17 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: ti: am642-evm: Add overlay for NAND expansion card To: Andrew Davis , Nishanth Menon Cc: vigneshr@ti.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, srk@ti.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Siddharth Vadapalli References: <20230920133450.54226-1-rogerq@kernel.org> <20230920133450.54226-3-rogerq@kernel.org> <20230920135802.3ej2wcuaruqjidel@uncouth> <20230920164424.rrjvm6nvtv4ysyrw@unreal> <6f2b38f8-1962-46f2-a095-b1eaf99ed407@kernel.org> Content-Language: en-US From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, On 21/09/2023 20:23, Andrew Davis wrote: > On 9/21/23 6:37 AM, Roger Quadros wrote: >> On 20/09/2023 20:06, Andrew Davis wrote: >>> On 9/20/23 11:44 AM, Nishanth Menon wrote: >>>> On 18:18-20230920, Roger Quadros wrote: >>>>> >>>>> >>>>> On 20/09/2023 16:58, Nishanth Menon wrote: >>>>>> On 16:34-20230920, Roger Quadros wrote: >>>>>>> The NAND expansion card plugs in over the HSE (High Speed Expansion) >>>>>>> connector. Add support for it. >>>>>>> >>>>>>> Signed-off-by: Roger Quadros >>>>>>> --- >>>>>>>    arch/arm64/boot/dts/ti/Makefile               |   1 + >>>>>>>    arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso | 140 ++++++++++++++++++ >>>>>>>    2 files changed, 141 insertions(+) >>>>>>>    create mode 100644 arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso >>>>>>> >>>>>>> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile >>>>>>> index 06d6f264f292..ece74085a6be 100644 >>>>>>> --- a/arch/arm64/boot/dts/ti/Makefile >>>>>>> +++ b/arch/arm64/boot/dts/ti/Makefile >>>>>>> @@ -29,6 +29,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am62p5-sk.dtb >>>>>>>      # Boards with AM64x SoC >>>>>>>    dtb-$(CONFIG_ARCH_K3) += k3-am642-evm.dtb >>>>>>> +dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-nand.dtbo >>>>>>>    dtb-$(CONFIG_ARCH_K3) += k3-am642-phyboard-electra-rdk.dtb >>>>>>>    dtb-$(CONFIG_ARCH_K3) += k3-am642-sk.dtb >>>>>>>    dtb-$(CONFIG_ARCH_K3) += k3-am642-tqma64xxl-mbax4xxl.dtb >>>>>> >>>>>> Also see https://lore.kernel.org/all/20230911165610.GA1362932-robh@kernel.org/ >>>>>> >>>>>> you may not get the dtbo installed when doing make dtbs_install >>>>>> >>>>>> [...] >>>>>> >>>>> >>>>> $ v8make dtbs_install INSTALL_DTBS_PATH=/tmp >>>>>     INSTALL /tmp/ti/k3-am625-beagleplay.dtb >>>>>     INSTALL /tmp/ti/k3-am625-phyboard-lyra-rdk.dtb >>>>>     INSTALL /tmp/ti/k3-am625-sk.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-nonwifi-dahlia.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-nonwifi-dev.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-nonwifi-yavia.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-wifi-dahlia.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-wifi-dev.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-wifi-yavia.dtb >>>>>     INSTALL /tmp/ti/k3-am62-lp-sk.dtb >>>>>     INSTALL /tmp/ti/k3-am62x-sk-hdmi-audio.dtbo >>>>>     INSTALL /tmp/ti/k3-am62a7-sk.dtb >>>>>     INSTALL /tmp/ti/k3-am62p5-sk.dtb >>>>>     INSTALL /tmp/ti/k3-am642-evm.dtb >>>>>     INSTALL /tmp/ti/k3-am642-evm-nand.dtbo >>>>> ^^^^ >>>>>     INSTALL /tmp/ti/k3-am642-phyboard-electra-rdk.dtb >>>>>     INSTALL /tmp/ti/k3-am642-sk.dtb >>>>> >>>>> >>>>> What did I miss? >>>> >>>> I missed it, actually. See Rob's comment: >>>> https://lore.kernel.org/all/CAL_Jsq+GR3hP6hFvFn2z5aXvSXnh9butD3aKZ-y_XJgx0_YPTw@mail.gmail.com/ >>>> >>>> Having orphan dtbo is apparently frowned upon >>>> >>> >>> And if you apply these overlays to the base DTB then it gets >>> symbols added automatically, no need for your patch [1/2] here. >>> >> >> Is this OK? >> >>     k3-am642-evm-nand-dtbs := k3-am642-evm.dtb k3-am642-evm-nand.dtbo >>     dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-nand.dtb >> >> So patch 1 is not required in this case but we have an >> extra dtb file which is not really required. >> > > While I agree we will end up with several pre-overlayed DTB files > that are arguably not required as they could be later built/applied, > until we find a better way to check at build time these overlays > need applied to something as a test. > >> I have 2 more issues to point out >> >> 1) >> With existing examples e.g. J7200 EVM >> wouldn't  k3-j7200-evm.dtb include the k3-j7200-evm-quad-port-eth-exp.dtbo? >> Is this what we really want? >> >> likewise for k3-j721e-evm.dtb and k3-am654-gp-evm.dtb >> > > Yes, that is the idea, the base-board.dtb is just the raw main board, but > the "EVM" when you buy it comes with the quad-port daughtercard attached. > That is what we consider the "EVM" and the DTB names match that. > >> 2) >> Another issue (unrelated to this change) is the below warning: >> >>     arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso:65.8-140.3: Warning (avoid_default_addr_size): /fragment@3/__overlay__: Relying on default #address-cells value >>     arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso:65.8-140.3: Warning (avoid_default_addr_size): /fragment@3/__overlay__: Relying on default #size-cells value >> >> This is because we use the 'ranges' property in the gpmc0 node >> and the compiler doesn't know the #address/size-cells of the >> parent node. >> >> Is there a trick to specify it in the dtso file? >> > > Hmm, seems like a tricky one. Do you really need to do the ranges here? > Could you use the default `ranges;` for gpmc0? Then do the range translation > down inside the nand node to keep the partition addresses sane. I think we need to go down this route. Your suggestion about using ranges in gpmc0 node in the EVM DT file is fine I guess as for this board there is no other use case for GPMC. So it should be OK to reserve Chip Select0 address space at k3-am642-evm.dts -- cheers, -roger