All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Shuah Khan <shuah@kernel.org>, Peter Gonda <pgonda@google.com>
Cc: kernel@collabora.com, kernelci@groups.io,
	"kernelci.org bot" <bot@kernelci.org>,
	kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH V2] selftests: kvm: Remove absent target file
Date: Fri, 11 Feb 2022 10:34:58 -0700	[thread overview]
Message-ID: <9198c43b-e5e2-fa58-5862-598dc7019ad6@linuxfoundation.org> (raw)
In-Reply-To: <eb4e24c6-41d0-4f3a-2af0-3008db408da6@redhat.com>

On 2/10/22 11:56 AM, Paolo Bonzini wrote:
> On 2/10/22 19:02, Shuah Khan wrote:
>>
>> I am fine with the change itself. For this patch:
>>
>> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
>>
>> However, are we missing a vmx_pi_mmio_test and that test needs to be added.
>>
>> Just in case the test didn't make it into the 6a58150859fd and the intent
>> was to add it - hence the Makefile addition? This can be addressed in
>> another patch. Just want to make sure we aren't missing a test.
> 
> This was probably a rebase resolution issue.  The vmx_pi_mmio_test fails in the mainline tree, and is lingering in my tree together with the fix because somebody promised a better fix for it.  I included the TEST_GEN_PROGS_x86_64 line by mistake when rebasing Peter Gonda's test below vmx_pi_mmio_test.
> 
> Thanks for the fix,
> 
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> 

Paolo,

Thank you for explaining the discrepancy. Would you like take
this through your tree? This patch depends on

commit: de1956f48543e90f94b1194395f33140898b39b2

thanks,
-- Shuah

  reply	other threads:[~2022-02-11 17:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 17:23 [PATCH V2] selftests: kvm: Remove absent target file Usama
2022-02-10 17:23 ` Muhammad Usama Anjum
2022-02-10 18:02 ` Shuah Khan
2022-02-10 18:56   ` Paolo Bonzini
2022-02-11 17:34     ` Shuah Khan [this message]
2022-02-11 17:37       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9198c43b-e5e2-fa58-5862-598dc7019ad6@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=bot@kernelci.org \
    --cc=kernel@collabora.com \
    --cc=kernelci@groups.io \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=pgonda@google.com \
    --cc=shuah@kernel.org \
    --cc=usama.anjum@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.