From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC412D35E5D for ; Wed, 6 Nov 2024 02:16:40 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1t8Vb4-0004xT-Ip; Wed, 06 Nov 2024 02:16:38 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t8Vb3-0004xH-Ix for linux-f2fs-devel@lists.sourceforge.net; Wed, 06 Nov 2024 02:16:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jd6QbodmNyjEqp11lbBe/WW2fNJcqxSf6+CMYluVZ6c=; b=PjsMWVmBJTcgeYIZ1sUOrYik0p bVRzUis1gzh6RLb2Z4QCMYDjMMnPAk9aCOH7n9QI+pl9k9VOwYobgqfqmL1J114yAl/fe4Q7OcBuo BQHQPC9ah4CaRX2MOey+z8YIwz23CerSiHq0agadCEs1vAUACXdzE4lYNPfiRNzikeLY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jd6QbodmNyjEqp11lbBe/WW2fNJcqxSf6+CMYluVZ6c=; b=VfE48REuXzv9eEQP6Dnq5Fii9F CMJxeC/OyDu3sWgMVncfDVwwUje8Y3Ovt+w9TDgVwGBxvHsAAxgXr/LnWdrtlRsnATFBCP28ryPdF FszjumZRtHOaQzP+8AGYS4I9rGfgOANyzfhIPfqkdW/OTiYNp0auO3CEn1oDadWHzXwc=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1t8Vb1-0001Je-2y for linux-f2fs-devel@lists.sourceforge.net; Wed, 06 Nov 2024 02:16:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EEC725C4BB4; Wed, 6 Nov 2024 02:15:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C423C4CED1; Wed, 6 Nov 2024 02:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730859384; bh=06l34PWhvl4tdNiJSYbSZO4mr1xYv8cmwY77xvFqw2Q=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=dSi0Z35MYmjitvBnV1jBnhBWpPchp+wG3KFIZXuY8ya7S6M9P+DXegErXesVIvIBn TgKj/SVY0vHbOh7TF1lgZnWeffWqby6TLMK1YsVwTojrMA8XFO1g+R7aCJTr5/ta9R WIAoj4ekSnvQjVLmZ5gcrdFCqjeiw67/COz2TBUo+Cwu2EzD3AqfsPg28UbQ9b/ys4 TsYQd7p5i1/Hp6vnyIE4+P7azDxOcnov69XbBzS4U1YOtIgWRP1NVh46mH/LDnuW0X Xn65pf2fCjxq5IYe81/c8azbLHykJSgSg5t9+o5HmWFI8HNOHqeS4xZruqZIMcTh2q xq0/ic6Ai9GSg== Message-ID: <9199e9fc-7b5b-4069-b79b-65ba5ae1b0f6@kernel.org> Date: Wed, 6 Nov 2024 10:16:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Zhiguo Niu References: <1730685372-2995-1-git-send-email-zhiguo.niu@unisoc.com> <22873055-370b-4240-83ff-96bcfa91413a@kernel.org> Content-Language: en-US In-Reply-To: X-Headers-End: 1t8Vb1-0001Je-2y Subject: Re: [f2fs-dev] [PATCH V2] f2fs: fix to adjust appropriate length for fiemap X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: ke.wang@unisoc.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Zhiguo Niu , jaegeuk@kernel.org, Hao_hao.Wang@unisoc.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMjAyNC8xMS81IDE5OjAyLCBaaGlndW8gTml1IHdyb3RlOgo+IENoYW8gWXUgPGNoYW9Aa2Vy bmVsLm9yZz4g5LqOMjAyNOW5tDEx5pyINeaXpeWRqOS6jCAxODozOeWGmemBk++8mgo+Pgo+PiBP biAyMDI0LzExLzUgMTU6MjgsIFpoaWd1byBOaXUgd3JvdGU6Cj4+PiBDaGFvIFl1IDxjaGFvQGtl cm5lbC5vcmc+IOS6jjIwMjTlubQxMeaciDXml6XlkajkuowgMTU6MDTlhpnpgZPvvJoKPj4+Pgo+ Pj4+IE9uIDIwMjQvMTEvNCA5OjU2LCBaaGlndW8gTml1IHdyb3RlOgo+Pj4+PiBJZiB1c2VyIGdp dmUgYSBmaWxlIHNpemUgYXMgImxlbmd0aCIgcGFyYW1ldGVyIGZvciBmaWVtYXAKPj4+Pj4gb3Bl cmF0aW9ucywgYnV0IGlmIHRoaXMgc2l6ZSBpcyBub24tYmxvY2sgc2l6ZSBhbGlnbmVkLAo+Pj4+ PiBpdCB3aWxsIHNob3cgMiBzZWdtZW50cyBmaWVtYXAgcmVzdWx0cyBldmVuIHRoaXMgd2hvbGUg ZmlsZQo+Pj4+PiBpcyBjb250aWd1b3VzIG9uIGRpc2ssIHN1Y2ggYXMgdGhlIGZvbGxvd2luZyBy ZXN1bHRzOgo+Pj4+Pgo+Pj4+PiAgICAgLi9mMmZzX2lvIGZpZW1hcCAwIDE5MDM0IHlsb2cvYW5h bHl6ZXIucHkKPj4+Pj4gRmllbWFwOiBvZmZzZXQgPSAwIGxlbiA9IDE5MDM0Cj4+Pj4+ICAgICAg ICAgICAgbG9naWNhbCBhZGRyLiAgICBwaHlzaWNhbCBhZGRyLiAgIGxlbmd0aCAgICAgICAgICAg ZmxhZ3MKPj4+Pj4gMCAgICAgICAwMDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAwMjBiYWEwMDAgMDAw MDAwMDAwMDAwNDAwMCAwMDAwMTAwMAo+Pj4+PiAxICAgICAgIDAwMDAwMDAwMDAwMDQwMDAgMDAw MDAwMDAyMGJhZTAwMCAwMDAwMDAwMDAwMDAxMDAwIDAwMDAxMDAxCj4+Pj4+Cj4+Pj4+IGFmdGVy IHRoaXMgcGF0Y2g6Cj4+Pj4+IC4vZjJmc19pbyBmaWVtYXAgMCAxOTAzNCB5bG9nL2FuYWx5emVy LnB5Cj4+Pj4+IEZpZW1hcDogb2Zmc2V0ID0gMCBsZW4gPSAxOTAzNAo+Pj4+PiAgICAgICAgbG9n aWNhbCBhZGRyLiAgICBwaHlzaWNhbCBhZGRyLiAgIGxlbmd0aCAgICAgICAgICAgZmxhZ3MKPj4+ Pj4gMCAgICAwMDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAwMzE1ZjMwMDAgMDAwMDAwMDAwMDAwNTAw MCAwMDAwMTAwMQo+Pj4+Pgo+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBaaGlndW8gTml1IDx6aGlndW8u bml1QHVuaXNvYy5jb20+Cj4+Pj4+IC0tLQo+Pj4+PiBWMjogY29ycmVjdCBjb21taXQgbXNnIGFj Y29yZGluZyB0byBDaGFvJ3MgcXVlc3Rpb25zCj4+Pj4+IGYyZnNfaW8gaGFzIGJlZW4gbW9kaWZp ZWQgZm9yIHRlc3RpbmcsIHRoZSBsZW5ndGggZm9yIGZpZW1hcCBpcwo+Pj4+PiByZWFsIGZpbGUg c2l6ZSwgbm90IGJsb2NrIG51bWJlcgo+Pj4+PiAtLS0KPj4+Pj4gICAgIGZzL2YyZnMvZGF0YS5j IHwgNCArKy0tCj4+Pj4+ICAgICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQo+Pj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0IGEvZnMvZjJmcy9kYXRhLmMgYi9mcy9m MmZzL2RhdGEuYwo+Pj4+PiBpbmRleCAzMDZiODZiMC4uOWZjMjI5ZCAxMDA2NDQKPj4+Pj4gLS0t IGEvZnMvZjJmcy9kYXRhLmMKPj4+Pj4gKysrIGIvZnMvZjJmcy9kYXRhLmMKPj4+Pj4gQEAgLTE5 NjYsOCArMTk2Niw4IEBAIGludCBmMmZzX2ZpZW1hcChzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzdHJ1 Y3QgZmllbWFwX2V4dGVudF9pbmZvICpmaWVpbmZvLAo+Pj4+PiAgICAgICAgICAgICAgICAgICAg ICAgICBnb3RvIG91dDsKPj4+Pj4gICAgICAgICB9Cj4+Pj4+Cj4+Pj4+IC0gICAgIGlmIChieXRl c190b19ibGtzKGlub2RlLCBsZW4pID09IDApCj4+Pj4+IC0gICAgICAgICAgICAgbGVuID0gYmxr c190b19ieXRlcyhpbm9kZSwgMSk7Cj4+Pj4+ICsgICAgIGlmIChsZW4gJiAoYmxrc190b19ieXRl cyhpbm9kZSwgMSkgLSAxKSkKPj4+Pj4gKyAgICAgICAgICAgICBsZW4gPSByb3VuZF91cChsZW4s IGJsa3NfdG9fYnl0ZXMoaW5vZGUsIDEpKTsKPj4+Pgo+Pj4+IEhvdyBkbyB5b3UgdGhpbmsgb2Yg Z2V0dGluZyByaWQgb2YgYWJvdmUgYWxpZ25tZW50IGZvciBsZW4/Cj4+Pj4KPj4+Pj4KPj4+Pj4g ICAgICAgICBzdGFydF9ibGsgPSBieXRlc190b19ibGtzKGlub2RlLCBzdGFydCk7Cj4+Pj4+ICAg ICAgICAgbGFzdF9ibGsgPSBieXRlc190b19ibGtzKGlub2RlLCBzdGFydCArIGxlbiAtIDEpOwo+ Pj4+Cj4+Pj4gQW5kIHJvdW5kIHVwIGVuZCBwb3NpdGlvbiB3LzoKPj4+Pgo+Pj4+IGxhc3RfYmxr ID0gYnl0ZXNfdG9fYmxrcyhpbm9kZSwgcm91bmRfdXAoc3RhcnQgKyBsZW4gLSAxLCBGMkZTX0JM S1NJWkUpKTsKPj4+IEhpIENoYW8sCj4+PiBJIHRoaW5rIHRoaXMgd2lsbCBjaGFuZ2UgdGhlIGN1 cnJlbnQgY29kZSBsb2dpYwo+Pj4gLS0tLS0tLS0tLS0tLQo+Pj4gaWYgKHN0YXJ0X2JsayA+IGxh c3RfYmxrKQo+Pj4gICAgICAgZ290byBvdXQ7Cj4+PiAtLS0tLS0tLS0tLS0tCj4+PiBmb3IgZXhh bXBsZSwgYSBmaWxlIHdpdGggc2l6ZSAxOTAwNiwgYnV0IHRoZSBsZW5ndGggZnJvbSB0aGUgdXNl ciBpcyAxNjM4NC4KPj4+IGJlZm9yZSB0aGlzIG1vZGlmaWNhdGlvbiwgIGxhc3RfYmxrID0gIGJ5 dGVzX3RvX2Jsa3MoaW5vZGUsIHN0YXJ0ICsKPj4+IGxlbiAtIDEpID0gKGlub2RlLCAxNjM4Mykg PSAzCj4+PiBhZnRlciB0aGUgZmlyc3QgZjJmc19tYXBfYmxvY2tzKCkuIHN0YXJ0X2JsayBjaGFu Z2UgdG8gYmUgNCwKPj4+IGFmdGVyIHRoZSBzZWNvbmQgZjJmc19tYXBfYmxvY2tzKCksIGZpZW1h cF9maWxsX25leF9leHRlbiB3aWxsIGJlCj4+PiBjYWxsZWQgdG8gZmlsbCB1c2VyIHBhcmFtZXRl ciBhbmQgdGhlbgo+Pj4gd2lsbCBnb3RvIG91dCBiZWNhdXNlIHN0YXJ0X2JsayA+IGxhc3RfYmxr LCB0aGVuIGZpZW1hcCBmbG93IGZpbmlzaGVzLgo+Pj4gYnV0IGFmdGVyIHRoaXMgbW9kaWZpY2F0 aW9uLCBsYXN0X2JsayB3aWxsIGJlIDQKPj4+IHdpbGwgZG8gZjJmc19tYXBfYmxvY2tzKCkgdW50 aWwgcmVhY2ggdGhlIG1heF9maWxlX2Jsb2Nrcyhpbm9kZSkKPj4KPj4gWWVzLCB5b3UncmUgcmln aHQsIGhvd2V2ZXIsIHcvIHRoaXMgcGF0Y2gsIGl0IG1heSBjaGFuZ2UgbGFzdF9ibGssIGUuZy4K Pj4KPj4geGZzX2lvIGZpbGUgLWMgImZpZW1hcCAtdiAwIDE5MDA2IiB2cyB4ZnNfaW8gZmlsZSAt YyAiZmllbWFwIC12IDIgMTkwMDYiCj4+IHN0YXJ0X2JsayBhbmQgbGFzdF9ibGsgd2lsbCBiZTog MCwgNCBhbmQgMCwgNS4KPiBIaSBDaGFvLAo+IHllcywgYnV0IHcvbyB0aGlzIHBhdGNoICwgdGhl IG9yaWdpbmFsIGNvZGUgc3RpbGwgaGFzIHRoZSBzYW1lIHNpdHVhdGlvbj8/Cj4gZm9yIGV4YW1w bGUKPiB4ZnNfaW8gZmlsZSAtYyAiZmllbWFwIC12IDAgMTYzODQiIHZzIHhmc19pbyBmaWxlIC1j ICJmaWVtYXAgLXYgMiAxNjM4NCIKPiBzdGFydF9ibGsgYW5kIGxhc3RfYmxrIHdpbGwgYmU6IDAs IDMgYW5kIDAsIDQuCgpGb3IgdGhlIGNhc2UgImZpZW1hcCAtdiAyIDE5MDA2Iiwgb2Zmc2V0IGlz IDIsIGFuZCBsZW5ndGggaXMgMTkwMDYsIHNvIGxhc3Rfb2Zmc2V0CmlzIDE5MDA4LCBhbmQgbGFz dF9ibGsgc2hvdWxkIGJlIDQgcmF0aGVyIHRoYW4gNSwgcmlnaHQ/CgpBbmQgZm9yIHlvdSBjYXNl LCBpdCBjYWxjdWxhdGVzIGxhc3RfYmxrIGNvcnJlY3RseS4KClRoYW5rcywKCj4gYnV0IG92ZXJh bGwgbGFzdF9ibGsgd2lsbCBjaGFuZ2UgbG9vcCBjb3VudHMgYnV0IGhhcyBub3QgYWZmZWN0IG9u IHRoZSByZXN1bHRzLgo+Pgo+PiBTaG91bGQgd2Ugcm91bmRfdXAgbGVuIGFmdGVyIHN0YXJ0X2Js ayAmIGxhc3RfYmxrIGNhbGN1bGF0aW9uPwo+IEkgdGhpbmtzIGl0IGlzIG9rICxidXQganVzdCBh IGxpdHRsZSBiaXQgcmVkdW5kYW50IHdpdGggdGhlIGZvbGxvd2luZwo+IGhhbmRsaW5nIGFib3V0 IGxlbi4KPiAKPiBpZiAoYnl0ZXNfdG9fYmxrcyhpbm9kZSwgbGVuKSA9PSAwKQo+ICAgICBsZW4g PSBibGtzX3RvX2J5dGVzKGlub2RlLCAxKTsKPiAKPiBCYXNlZCBvbiB0aGUgYWJvdmUgc2l0dWF0 aW9uLAo+IGRvIHlvdSBoYXZlIGFueSBvdGhlciBnb29kIHN1Z2dlc3Rpb25zPyBeXgo+IHRoYW5r cyEKPiAKPj4KPj4gVGhhbmtzLAo+Pgo+Pj4gdGhhbmtz77yBCj4+Pj4KPj4+PiBUaGFua3MsCj4+ Pj4KPj4KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3Vy Y2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8v bGludXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C178318FC75 for ; Wed, 6 Nov 2024 02:16:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730859384; cv=none; b=BJrEKInLB3LoY7RKbkM3NQCzIiorVzM07N/ecyKDvIl9PzkViJ2On4cGvYjp/6QGae3ckkQAd6ArfonhSo4gU9zxj89pKT9YfJB4XE4q2eeCT8SIYSkXrAsMrNNInIfV1hUip2rL0e+dBIWZcKw7OyKS8+HTotknNteNwipc16U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730859384; c=relaxed/simple; bh=06l34PWhvl4tdNiJSYbSZO4mr1xYv8cmwY77xvFqw2Q=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=mKJxDnnXRS03FkYTTHuP77ybkdL00j3i0Mka3qhfflp11pDTQGM1aHNLVfHYVQ67UiCcrcxJHeF3UcbSgTrRMKEo2Juqw3vucgmwCS1L0cMpEcjzvag0HZ3Ikpi+EZRPL02BE4degI1MTjESCDnADNKkYY6vFuVD8ooreFM7O4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dSi0Z35M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dSi0Z35M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C423C4CED1; Wed, 6 Nov 2024 02:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730859384; bh=06l34PWhvl4tdNiJSYbSZO4mr1xYv8cmwY77xvFqw2Q=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=dSi0Z35MYmjitvBnV1jBnhBWpPchp+wG3KFIZXuY8ya7S6M9P+DXegErXesVIvIBn TgKj/SVY0vHbOh7TF1lgZnWeffWqby6TLMK1YsVwTojrMA8XFO1g+R7aCJTr5/ta9R WIAoj4ekSnvQjVLmZ5gcrdFCqjeiw67/COz2TBUo+Cwu2EzD3AqfsPg28UbQ9b/ys4 TsYQd7p5i1/Hp6vnyIE4+P7azDxOcnov69XbBzS4U1YOtIgWRP1NVh46mH/LDnuW0X Xn65pf2fCjxq5IYe81/c8azbLHykJSgSg5t9+o5HmWFI8HNOHqeS4xZruqZIMcTh2q xq0/ic6Ai9GSg== Message-ID: <9199e9fc-7b5b-4069-b79b-65ba5ae1b0f6@kernel.org> Date: Wed, 6 Nov 2024 10:16:20 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Chao Yu , Zhiguo Niu , jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, Hao_hao.Wang@unisoc.com Subject: Re: [PATCH V2] f2fs: fix to adjust appropriate length for fiemap To: Zhiguo Niu References: <1730685372-2995-1-git-send-email-zhiguo.niu@unisoc.com> <22873055-370b-4240-83ff-96bcfa91413a@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024/11/5 19:02, Zhiguo Niu wrote: > Chao Yu 于2024年11月5日周二 18:39写道： >> >> On 2024/11/5 15:28, Zhiguo Niu wrote: >>> Chao Yu 于2024年11月5日周二 15:04写道： >>>> >>>> On 2024/11/4 9:56, Zhiguo Niu wrote: >>>>> If user give a file size as "length" parameter for fiemap >>>>> operations, but if this size is non-block size aligned, >>>>> it will show 2 segments fiemap results even this whole file >>>>> is contiguous on disk, such as the following results: >>>>> >>>>> ./f2fs_io fiemap 0 19034 ylog/analyzer.py >>>>> Fiemap: offset = 0 len = 19034 >>>>> logical addr. physical addr. length flags >>>>> 0 0000000000000000 0000000020baa000 0000000000004000 00001000 >>>>> 1 0000000000004000 0000000020bae000 0000000000001000 00001001 >>>>> >>>>> after this patch: >>>>> ./f2fs_io fiemap 0 19034 ylog/analyzer.py >>>>> Fiemap: offset = 0 len = 19034 >>>>> logical addr. physical addr. length flags >>>>> 0 0000000000000000 00000000315f3000 0000000000005000 00001001 >>>>> >>>>> Signed-off-by: Zhiguo Niu >>>>> --- >>>>> V2: correct commit msg according to Chao's questions >>>>> f2fs_io has been modified for testing, the length for fiemap is >>>>> real file size, not block number >>>>> --- >>>>> fs/f2fs/data.c | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >>>>> index 306b86b0..9fc229d 100644 >>>>> --- a/fs/f2fs/data.c >>>>> +++ b/fs/f2fs/data.c >>>>> @@ -1966,8 +1966,8 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, >>>>> goto out; >>>>> } >>>>> >>>>> - if (bytes_to_blks(inode, len) == 0) >>>>> - len = blks_to_bytes(inode, 1); >>>>> + if (len & (blks_to_bytes(inode, 1) - 1)) >>>>> + len = round_up(len, blks_to_bytes(inode, 1)); >>>> >>>> How do you think of getting rid of above alignment for len? >>>> >>>>> >>>>> start_blk = bytes_to_blks(inode, start); >>>>> last_blk = bytes_to_blks(inode, start + len - 1); >>>> >>>> And round up end position w/: >>>> >>>> last_blk = bytes_to_blks(inode, round_up(start + len - 1, F2FS_BLKSIZE)); >>> Hi Chao, >>> I think this will change the current code logic >>> ------------- >>> if (start_blk > last_blk) >>> goto out; >>> ------------- >>> for example, a file with size 19006, but the length from the user is 16384. >>> before this modification, last_blk = bytes_to_blks(inode, start + >>> len - 1) = (inode, 16383) = 3 >>> after the first f2fs_map_blocks(). start_blk change to be 4, >>> after the second f2fs_map_blocks(), fiemap_fill_nex_exten will be >>> called to fill user parameter and then >>> will goto out because start_blk > last_blk, then fiemap flow finishes. >>> but after this modification, last_blk will be 4 >>> will do f2fs_map_blocks() until reach the max_file_blocks(inode) >> >> Yes, you're right, however, w/ this patch, it may change last_blk, e.g. >> >> xfs_io file -c "fiemap -v 0 19006" vs xfs_io file -c "fiemap -v 2 19006" >> start_blk and last_blk will be: 0, 4 and 0, 5. > Hi Chao, > yes, but w/o this patch , the original code still has the same situation?? > for example > xfs_io file -c "fiemap -v 0 16384" vs xfs_io file -c "fiemap -v 2 16384" > start_blk and last_blk will be: 0, 3 and 0, 4. For the case "fiemap -v 2 19006", offset is 2, and length is 19006, so last_offset is 19008, and last_blk should be 4 rather than 5, right? And for you case, it calculates last_blk correctly. Thanks, > but overall last_blk will change loop counts but has not affect on the results. >> >> Should we round_up len after start_blk & last_blk calculation? > I thinks it is ok ,but just a little bit redundant with the following > handling about len. > > if (bytes_to_blks(inode, len) == 0) > len = blks_to_bytes(inode, 1); > > Based on the above situation, > do you have any other good suggestions? ^^ > thanks! > >> >> Thanks, >> >>> thanks！ >>>> >>>> Thanks, >>>> >>