From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9119342B331 for ; Wed, 5 Aug 2026 11:20:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785928852; cv=none; b=AGBes7MreweUYOjyedELND3wQpkTWbG3N9L8GJlRuFeKL8SA7VwN6mY5NEickXedUo/Zk507tsmNyFW4XYp2b529w8wA+B20w3j1RDUzNu0HA3poxvw26hypaH35pUTVOfznc6iRi6epkTbmPTfw/TzEf55UEAIMXtuAvgBO4wg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785928852; c=relaxed/simple; bh=fdH8zgb4FUMrPKHIYgG4VuG+ZdMEk50Lpp+Ujtr24D4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AAtrRpule1qX4C9XHJvsdU2CcpMWn75w+8IESRQD1oNF8nS1NXLdWGGAD4T6h8PT0kTKyiDz4JWRkSrOs2/jpxUv4IftZ5c0gc2OJEQn60oB6vjPcUr6/Y+uHCFS/5DX6iw2/INM7b6peM+WopIZM5hQRtzW9JbVmmqwibRRCzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=k7od5wDL; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="k7od5wDL" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6758lnnl3438030; Wed, 5 Aug 2026 11:20:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=m1baXi 8To+fUNopTQsvjls+SIISy5DF1xd3UbXgnBhg=; b=k7od5wDLsLZG6wzUedXEWk FhyipTg/hK8HdcHuWhrSQe6u1wsBYxM7+qNO452Xoi/Q8j7xNuHdU4pHaN3h+Z7q Ukk78+J0KaQJvQ7QHV/HU/kOIdSwLHHnIC5N9DKOtdUaOhvaTJhB4BMdU4q38G5X zsxHavQMHHxk3paJ8rhAY0OZMLPNg/1IQC4mQwZ04J8JLo6bQeILkKjMgPhFJsVM KCw1lmJ500+xyqNA3oy3Gue9HM5fuWshvieqaKgWmMQbR7OUTERmm/EnARYSIEMX 6GP2/SdEOTOlBNobZzyC+NFuc2T0Z2MCipAi90W2GtepLE/oH0kG/g6XpdXGoWMQ == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fs8eut6ee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Aug 2026 11:20:31 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 675AfZOQ006305; Wed, 5 Aug 2026 11:20:30 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4fsv4k68mu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Aug 2026 11:20:30 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 675BKSOO49742202 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Aug 2026 11:20:28 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AB32D2004E; Wed, 5 Aug 2026 11:20:28 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A64F02004B; Wed, 5 Aug 2026 11:20:25 +0000 (GMT) Received: from [9.39.28.63] (unknown [9.39.28.63]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 5 Aug 2026 11:20:25 +0000 (GMT) Message-ID: <91b5adec-a9fd-4790-9ef4-ae99f54d95c4@linux.ibm.com> Date: Wed, 5 Aug 2026 16:50:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/10] crash_dump: Free temporary dm-crypt keys_header buffer in kdump kernel To: Coiby Xu , kexec@lists.infradead.org Cc: Andrew Morton , Baoquan He , Dave Young , Pratyush Yadav , Mike Rapoport , Pasha Tatashin , Coiby Xu , open list References: <20260729033654.311541-1-coiby.xu@gmail.com> <20260729033654.311541-6-coiby.xu@gmail.com> Content-Language: en-US From: Sourabh Jain In-Reply-To: <20260729033654.311541-6-coiby.xu@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: 1io9RBYzIySU7v8BPdNycSomfkFcOanQ X-Proofpoint-Spam-Info: AW1haW4tMjYwODA1MDA5MCBTYWx0ZWRfX6a7oLxRd4DkT TGaUOATi2L0+xiwi81cNGMr2XPvXVMylLiB1GUz31KbMNfO9QEu3lmnpqAUBajuU2ZYuKqJNSCf BCyoQv3/X+RCemsDI8HjdplPysWF17Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA1MDA5MCBTYWx0ZWRfX0N23kVcRFtZd l6v7SotQZuJ8bnOLOjowF4B8rFfMr7v6i2/jXamnns3Xqui+ijTIH2sXCsQ1VJnbm6xslhlFtL0 /42lQ2JjxH30VdkOiJUuTdEpxaHk0X24rXQO0IPqw0KVa/6msgU/ZiwH0r+Wg4X1+MQPOHoYSnD adqiAleClZVRZt0A7YT4GaaXeT+in5+w7aWbfU1EBpWirPudFjlaN/aretkARTT0ZomdL21UnMN eDo56q/wMIsbJvQ0uWLIjr6sqG58rSasMI0KYDSPzE4ImvALCWHwPd5jjZrCT/7KgfkXvPtLn7A 5Z8PwWcCX7p0Q7W+HRVH27KngzJ0i06uAGqIuivLwYhW/kiXMnccRiiGv9v1gTGXFu3mqW/O+1j jJg/LyhLLlenQPm+fv3BXvzfjShTS7p6iH0AZiyHx6vz15HHt/HDSxo8VuAFjaVy9XDlmWPbc3/ 9kejRuXyDEa1keJ5Pkw== X-Proofpoint-GUID: fnyVc4WBUGUEhCJ-wy-TfwbGtYr1lfHt X-Authority-Analysis: v=2.4 cv=KfzidwYD c=1 sm=1 tr=0 ts=6a731c80 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=pGLkceISAAAA:8 a=KfXPnQ-rYdLxMRt8lZMA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-05_03,2026-08-04_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608050090 On 29/07/26 09:06, Coiby Xu wrote: > Although we expect the system to reboot immediately after vmcore dumping > is finished, it's still good to free the temporary keys_header buffer. > > Fixes: 62f17d9df692 ("crash_dump: retrieve dm crypt keys in kdump kernel") > Reported-by: Sourabh Jain > Signed-off-by: Coiby Xu > --- > kernel/crash_dump_dm_crypt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c > index a3996208738b..9a64e2d6841b 100644 > --- a/kernel/crash_dump_dm_crypt.c > +++ b/kernel/crash_dump_dm_crypt.c > @@ -117,6 +117,7 @@ static int get_keys_from_kdump_reserved_memory(void) > > static int restore_dm_crypt_keys_to_thread_keyring(void) > { > + struct keys_header *keys_header __free(kfree_sensitive) = NULL; > struct dm_crypt_key *key; > size_t keys_header_size; > key_ref_t keyring_ref; Yeah, it's good to release the memory regardless. Feel free to add: Reviewed-by: Sourabh Jain