From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Luis Oliveira <Luis.Oliveira@synopsys.com>,
wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com,
mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH v6 1/6] i2c: designware: Cleaning and comment style fixes.
Date: Tue, 28 Feb 2017 17:07:09 +0200 [thread overview]
Message-ID: <91b9343d-e878-d262-41cd-a29979bf54f9@linux.intel.com> (raw)
In-Reply-To: <1487164348.2133.485.camel@linux.intel.com>
Hi
Sorry the delay.
On 02/15/17 15:12, Andy Shevchenko wrote:
> On Wed, 2017-02-15 at 12:22 +0000, Luis Oliveira wrote:
>> The purpose of this commit is to fix some comments and styling in the
>> existing code due to the need of reuse this code. What is being made
>> here is:
>>
>> - Sorted the headers files
>> - Corrected some comments style (capital letters, lowcase i2c)
>> - Reverse tree in the variables declaration
>> - Add/remove empty lines and tabs where needed
>> - Fix of misspelled word "endianness" and "transferred"
>> - Replaced the return variable "r" with the more standard "ret"
>>
>> The value of this, besides the rules of coding style, is because I
>> will use this code after and it will make my future patch a lot bigger
>> and
>> complicated to review. The work here won't bring any additional work
>> to
>> backported fixes because is just style and reordering.
>>
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
>> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
>> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Unfortunately this doesn't apply anymore due we had to revert commit
63d0f0a6952a ("i2c: designware: detect when dynamic tar update is
possible") for v4.10. Could you rebase and resend.
--
Jarkko
next prev parent reply other threads:[~2017-02-28 15:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 12:22 [PATCH v6 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira
2017-02-15 12:22 ` Luis Oliveira
2017-02-15 12:22 ` [PATCH v6 1/6] i2c: designware: Cleaning and comment style fixes Luis Oliveira
[not found] ` <8a176efc405d4f13d3fc1b5565d2a2b1c931a018.1487009294.git.lolivei-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-02-15 13:12 ` Andy Shevchenko
2017-02-15 13:12 ` Andy Shevchenko
2017-02-28 15:07 ` Jarkko Nikula [this message]
2017-02-15 12:22 ` [PATCH v6 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira
2017-02-15 12:22 ` [PATCH v6 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira
2017-02-15 12:22 ` [PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira
2017-02-27 17:24 ` Rob Herring
2017-02-15 12:22 ` [PATCH v6 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira
[not found] ` <cover.1487009294.git.lolivei-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-02-15 12:22 ` [PATCH v6 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira
2017-02-15 12:22 ` Luis Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91b9343d-e878-d262-41cd-a29979bf54f9@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Luis.Oliveira@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.