From: Finn Thain <fthain@linux-m68k.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Oliver Neukum <oneukum@suse.com>, Ali Akcaagac <aliakc@web.de>,
Jamie Lenehan <lenehan@twibble.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Colin Ian King <colin.i.king@gmail.com>,
linux-scsi@vger.kernel.org, llvm@lists.linux.dev,
patches@lists.linux.dev
Subject: Re: [PATCH] scsi: dc395x: Remove leftover if statement in reselect()
Date: Wed, 30 Apr 2025 11:36:55 +1000 (AEST) [thread overview]
Message-ID: <91ba6cf2-ca95-1ebe-837f-ecc89f547ea2@linux-m68k.org> (raw)
In-Reply-To: <20250429-scsi-dc395x-fix-uninit-var-v1-1-25215d481020@kernel.org>
On Tue, 29 Apr 2025, Nathan Chancellor wrote:
> This if statement only existed for a debugging print but it was not
> removed with the debugging print in a recent cleanup
The patch you called "cleanup" has a "fixes" tag. Strange.
I think it's unreasonable to refer to a patch which alters object code as
"cleanup".
I also think it's unreasonable to put a "fixes" tag on a patch that
doesn't alter object code (for any shipping config, for any supported
toolchain).
Those assertions could be tested automatically by CI. And maybe that could
prevent this kind of regression.
next prev parent reply other threads:[~2025-04-30 1:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 0:46 [PATCH] scsi: dc395x: Remove leftover if statement in reselect() Nathan Chancellor
2025-04-30 1:36 ` Finn Thain [this message]
2025-04-30 7:39 ` Oliver Neukum
2025-04-30 9:43 ` Finn Thain
2025-04-30 12:11 ` Oliver Neukum
2025-05-01 0:20 ` Finn Thain
2025-05-06 2:01 ` Martin K. Petersen
2025-05-13 2:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91ba6cf2-ca95-1ebe-837f-ecc89f547ea2@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=aliakc@web.de \
--cc=colin.i.king@gmail.com \
--cc=lenehan@twibble.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=nathan@kernel.org \
--cc=oneukum@suse.com \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.