From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com [136.143.188.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67DBA30FF36; Sun, 26 Jul 2026 15:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785080222; cv=pass; b=cRIpHP1M1OHEGcMiWmrs/JSuXP+v/gotqPim1vYw3UoOonKty8w5goPEVAVE+PveDvDFqoRVOb0SvwTSl8FVhGTIt9Z00fl8df0xhZMCGXnPG2iTBP3XRz/p85gouyRNPL1JCQ99dAuUDbY0u8fKjd0GSiuUqL/+GxnYXEyOB7Y= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785080222; c=relaxed/simple; bh=jx3dugEnzBY0Gfmo9vO84OdhOEvWmAjH4BuLb642vfg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qd9Ub5xO79WFd6WEj+Tm/++5wNXrSRsJuTMcMk4RRx7r6ItT+sFNZ59/f3NqvQ31LwNb0/i9eMLNbQgp8ExwoHX/5dQ2NSLY+2OZyHsuzlwREEXVCrjjR5lSdZKez4bJIOvUp/xL8hQ3l7VOwtCKBPenvuZbW8kX3CcjrmmqCpM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=yoavmoshe.com; spf=pass smtp.mailfrom=yoavmoshe.com; dkim=pass (1024-bit key) header.d=yoavmoshe.com header.i=linux@yoavmoshe.com header.b=YvcB1De+; arc=pass smtp.client-ip=136.143.188.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=yoavmoshe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yoavmoshe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yoavmoshe.com header.i=linux@yoavmoshe.com header.b="YvcB1De+" ARC-Seal: i=1; a=rsa-sha256; t=1785080208; cv=none; d=zohomail.com; s=zohoarc; b=UQkiHcR47z+NddFmPqTtLtUT2swz187cbX/2AVnTJtSZ02EZbiqbDcl0Akb082IiNoeBN2qWsolXCQaRwK8q52PlKZrUgNiexAEc5z2kSoZyWk+VByKkCRA77ctXHxBvHozhGf71aa62EBqeKnC2aYROlbYUPJw6tahKbqGKqxc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785080208; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=x7TPMOFy5N7Qt3AEzaq7fEAwVHo0rxFfUpnGX0hgRII=; b=eXcNIGq5cR0e8AUPw0rYOwRRu4okpnbbwiD1Bx+PtezpjmtWe/USiIeH3X215ERL2pG8/+/gbYqMT93W9oHGViOIdVqcvUZBUUQfUXxVyaoIqjllI7DPi6H5rRMHNmq+tFmnGgxQYl8yCnmNuFlCQGHoSae4uU6VbOwOI9G4NW4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=yoavmoshe.com; spf=pass smtp.mailfrom=linux@yoavmoshe.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785080208; s=zoho; d=yoavmoshe.com; i=linux@yoavmoshe.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=x7TPMOFy5N7Qt3AEzaq7fEAwVHo0rxFfUpnGX0hgRII=; b=YvcB1De+mncJrPRAlk5ny1KEork4Szs9K+6dGJZPUai2/MnH6M5GKuWbmoB24pX6 vm+jYWQ/lKLP78ywllGhmMCZO0iLMA1WD1hePr+i7bBn4o7d7d4G3i+pRcDV3++iS+U ysxBxBXL7mpSq8uo0i9KlD2nKSW5ycZhLal9Xnyk= Received: by mx.zohomail.com with SMTPS id 1785080203910869.7147545207597; Sun, 26 Jul 2026 08:36:43 -0700 (PDT) Message-ID: <91cb0f21-e78a-4931-b123-937c6a01592c@yoavmoshe.com> Date: Sun, 26 Jul 2026 17:36:37 +0200 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] ARM: imx: Fix suspend/resume crash with Clang CFI To: Nick Desaulniers , Sami Tolvanen , Yo'av Moshe Cc: Nathan Chancellor , Frank Li , Sascha Hauer , Russell King , Pengutronix Kernel Team , Fabio Estevam , Bill Wendling , Justin Stitt , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev, stable@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260718111340.159896-1-linux@yoavmoshe.com> <3046e60d-509f-471f-bd15-3ce78c87500b@yoavmoshe.com> <20260721180950.GA3684684@ax162> <180001f5-bddd-4e58-8442-f7ef3c979500@yoavmoshe.com> <7f273a08-b29c-4e15-b340-898b251efe57@yoavmoshe.com> <415ffa24-a30b-43b2-aa6a-a1cde3bd4ef0@yoavmoshe.com> <12a46993-82a5-4109-87fa-61b8fcf764aa@yoavmoshe.com> Content-Language: en-GB, sv-SE From: Yo'av Moshe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 2026-07-24 10:49 PM, Nick Desaulniers wrote: > Yeah, Yo'av did you test further modifications that explicitly copy > the hash prefix? I assumed Nathan's change _plus some additional tweak > to copy not just imx6_suspend to OCRAM which I assume the code already > does, but I would imagine you need another change to copy > __kcfi_typeid_imx6_suspend into OCRAM just before the function. Was > that tested? Yes, I tried that as well and it unfortunately didn't work. I tested Nathan's change along with explicitly copying the 4-byte prefix from before imx6_suspend into OCRAM right before calling fncpy(). However, when checking the compiled binary, "&imx6_suspend - 4" just contained padding rather than the hash, so the copied 4-byte value didn't match what the call site expected. Yo'av