From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mo4-p02-ob.smtp.rzone.de (mo4-p02-ob.smtp.rzone.de [85.215.255.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53094186284 for ; Tue, 7 Jul 2026 04:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=85.215.255.84 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783398739; cv=pass; b=HWV13W3f8XCdEkuzeUVykRuPu5LaqY/osHv4t2C9NhqG0NQAoj7pVoItAlVbF9j083rhr7TnCiAyEKZXkR5lWG4VVpb9vkDBE3Vz+Iib247txHBwJ6/3ZAHIAJaTjGSoUWgVrsRMkkvTk3qefz6vJwFjKD9rVzfW+vFvp+mNPSw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783398739; c=relaxed/simple; bh=a1N1tifhB9pQA+3Vq5vTWyl7F9503nUAFmGJQrNUkkA=; h=Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=EzsJooodbvNMm+ME4QSeJD5oqRsRpInlOWBBl5HlHcmiw0nYs9qFBzaRXoNndNzAD88qsF9GOObnl8XXOJeGyOigEcJHKA/pZt78/vKXEOf2G/6f4uIbhplutxKLH7b8o3teT7AdnTMYfH8H33uyjyuTYl+3AXhN9ASV0N4ivvE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xenosoft.de; spf=none smtp.mailfrom=xenosoft.de; dkim=pass (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b=jv8MHj9B; dkim=permerror (0-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b=Tdvac8RV; arc=pass smtp.client-ip=85.215.255.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xenosoft.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=xenosoft.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="jv8MHj9B"; dkim=permerror (0-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="Tdvac8RV" ARC-Seal: i=1; a=rsa-sha256; t=1783398689; cv=none; d=strato.com; s=strato-dkim-0002; b=U/z5LVimjpzXqUecmx/o6VjOMJ0L+8XYEqKm7ouCNeJw7Ve3ykstCCT5qxzJm///hS OqgZpZ3k1rHvnfZPiwfPizGBR4fILBBKPXMFKhh8+bN1mpccj+2/CXfTOLP9ooWXW+PG Q8mcFRgC042NI48xtGrTB2lAjlGVDWs1hg86qYWsutUBs2fX1rTVKF/UXZf4put2iYcS NtiK+JGjK/P3odQ7tX/ZRAX5dIAhtO0ibhWH5jz80WS9jYAbtymsBi3Foe2Fx5Ko3rIS NH4MnIztcumVAdBG8JrrT7UzSlEekYQ7/kRGPCQMGL3H4y85EdTCdwfjMA39CbJWeg87 8r4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1783398689; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:Date:Message-ID:From:References:To:Subject:Cc:Date:From: Subject:Sender; bh=u3IWUCGARqVOUe1k2VTrO7/4RsUY7qdLv+qZpKCsdHg=; b=WJJUP7FRSAqynguTl/4w9UA+WZ4xVlgWfYqqFk1YAd3MBfznz6v0vHFRCt2XTVHsEt WZ16IpiB2TNfmGId0duAELdqHhI/ee9Wj4zwFJpdnDGXGIkWkTIpZpegabxxoXonGa5g nd+aglW1SIReBAQykIyjYTiSh+071KAyRSsYBkSOkv7FRbOhAT0MBtH2yGYT8GXZj9kt tE1cIVUitDu08QRY7cwlpsDeoUEcUHLNNkJso56BsbHNUlWk5OjXRjaUnC9dcVD5JtpD LmWod5ZQcOJGfGx4fFnf7AXKhnOuTu7IAl1OHawBINMYndq0/QGc6wFfbDJApwuxexJH jCrw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1783398689; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:To:Subject:Cc:Date:From: Subject:Sender; bh=u3IWUCGARqVOUe1k2VTrO7/4RsUY7qdLv+qZpKCsdHg=; b=jv8MHj9B3uc/RRu6y7lINHD5y3R87luWUtEMrQSKvnMhrw89RhHb/KQhAiE8QGzNU2 DFdbCpGe0SMffZ4vvzP1O+BnjWixpReenQ8QKVnK40DWqj86011Eo+lOM1XZLMlK7eMU SH6hDCZNwr1ukh2e6QODWiqLsVYtkQswCfu8e9RmxnysSM9pRRuQxyE6erv64QrLVEVW +lBxXSm0VJjt4W7mEtaUoEXAgDSMMxb80sPFgFceKzHNYkbhrQsBt+6AuI7UmEKghtKx GrXtXy4w5Wz2THEGBw3YjKUT6HJEUziDHrqD64CMpDh3L7lhFX1gFMCjID8lzJzzSO+J TAUA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1783398689; s=strato-dkim-0003; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:To:Subject:Cc:Date:From: Subject:Sender; bh=u3IWUCGARqVOUe1k2VTrO7/4RsUY7qdLv+qZpKCsdHg=; b=Tdvac8RVHv1nVhSwLYVw3GrJsyj9Z/yiTh5+WcZ1FBmKO+vismc2mf6C18WBYV5L0/ XgTRHdtpsPXsY1/2F5Cg== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGN0rBVhd9dFr4thIFiqT9BURIy+m7hrg" Received: from void-ppc.a-eon.tld by smtp.strato.de (RZmta 55.5.6 DYNA|AUTH) with ESMTPSA id e4c84d2674VSkjn (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 7 Jul 2026 06:31:28 +0200 (CEST) Subject: [PATCH] Connecting the SB600's i8259 controller rather in pasemi's pci.c than in pasemi's setup.c. To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , open list , "R.T.Dickinson" , Damien Stewart , Darren Stevens References: <20260701105501.2093-1-chzigotzky@xenosoft.de> From: Christian Zigotzky Organization: A-EON Open Source Message-ID: <91cfa587-c555-45ad-2a34-83e5191ade7d@xenosoft.de> Date: Tue, 7 Jul 2026 06:31:28 +0200 X-Mailer: BrassMonkey/34.2.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260701105501.2093-1-chzigotzky@xenosoft.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Any comments about this patch? Tested-by: Christian Zigotzky -- Christian On 01/07/26 12:54, Christian Zigotzky wrote: >  "pas_pci_init" was before "nemo_init_IRQ". >  Now "pas_pci_init" is after "nemo_init_IRQ" in the official kernel source >  code. >  I think "pas_pci_init" scans (discovers) the PCI(e) devices >  and after that, "nemo_init_IRQ" assigns interrupt numbers >  to these devices if required. >  It's not possible to assigns interrupt numbers to PCI(e) devices >  which have not been discovered yet. > > Signed-off-by: Christian Zigotzky > --- >  arch/powerpc/platforms/pasemi/pci.c   | 7 +++++++ >  arch/powerpc/platforms/pasemi/setup.c | 7 ++++--- >  2 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c > index 2df955274652..7208c325bfc5 100644 > --- a/arch/powerpc/platforms/pasemi/pci.c > +++ b/arch/powerpc/platforms/pasemi/pci.c > @@ -25,6 +25,8 @@ > >  #define PA_PXP_CFA(bus, devfn, off) (((bus) << 20) | ((devfn) << 12) | (off)) > > +extern void nemo_init_IRQ(void); > + >  static inline int pa_pxp_offset_valid(u8 bus, u8 devfn, int offset) >  { >      /* Device 0 Function 0 is special: It's config space spans function 1 as > @@ -265,6 +267,11 @@ static int __init pas_add_bridge(struct device_node *dev) >       */ >      isa_bridge_find_early(hose); > > +    /* > +     * ISA bridge is now active, add the i8259 cascade (if needed) > +     */ > +    nemo_init_IRQ(); > + >      return 0; >  } > > diff --git a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platforms/pasemi/setup.c > index d03b41336901..eec74611be46 100644 > --- a/arch/powerpc/platforms/pasemi/setup.c > +++ b/arch/powerpc/platforms/pasemi/setup.c > @@ -214,10 +214,12 @@ static void sb600_8259_cascade(struct irq_desc *desc) >      chip->irq_eoi(&desc->irq_data); >  } > > -static void __init nemo_init_IRQ(struct mpic *mpic) > +void nemo_init_IRQ(void) >  { >      struct device_node *np; >      int gpio_virq; > +    struct mpic *mpic; > + >      /* Connect the SB600's legacy i8259 controller */ >      np = of_find_node_by_path("/pxp@0,e0000000"); >      i8259_init(np, 0); > @@ -228,6 +230,7 @@ static void __init nemo_init_IRQ(struct mpic *mpic) >      irq_set_chained_handler(gpio_virq, sb600_8259_cascade); >      mpic_unmask_irq(irq_get_irq_data(gpio_virq)); > > +    mpic = irq_get_chip_data(gpio_virq); >      irq_set_default_domain(mpic->irqhost); >  } > > @@ -298,8 +301,6 @@ static __init void pas_init_IRQ(void) >          mpic_unmask_irq(irq_get_irq_data(nmi_virq)); >      } > > -    nemo_init_IRQ(mpic); > - >      of_node_put(mpic_node); >      of_node_put(root); >  } -- Sent with BrassMonkey 34.2.2 (https://github.com/chzigotzky/Web-Browsers-and-Suites-for-Linux-PPC/releases/tag/BrassMonkey_34.2.2)