All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
To: phasta@kernel.org, dri-devel@lists.freedesktop.org
Cc: amd-gfx@lists.freedesktop.org, kernel-dev@igalia.com,
	"Christian König" <christian.koenig@amd.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Matthew Brost" <matthew.brost@intel.com>
Subject: Re: [PATCH 2/4] drm/sched: Ignore stopped entity attempt to change its run-queue
Date: Tue, 17 Nov 2026 13:04:59 +0000	[thread overview]
Message-ID: <91f421df-4753-4e63-8bc6-daea85c6bb35@igalia.com> (raw)
In-Reply-To: <fd86312b062767e3434573064aeb267721c7a4f6.camel@mailbox.org>


On 17/11/2026 11:53, Philipp Stanner wrote:
> On Tue, 2026-11-17 at 10:06 +0000, Tvrtko Ursulin wrote:
>> Jobs submitted to a stopped entity do not go anywhere due how they are
>> handled in drm_sched_rq_add_entity() so there is no point to allow them
>> to change their run-queue.
> 
> Who stops an entity?
> Who submits to a stopped entity?
> Isn't entity_select_rq only called for drm_sched_job_arm()?
> Who's arming jobs for an entity that he has stopped himself?

I extracted this change as separate patch on your request during a 
conversation back in June.

But it is not really required, even less so since I abandoned the 
removal of entity_idle. The only way race could happen if it drivers did 
crazy things.

I can drop it no problem.

Tvrtko


  reply	other threads:[~2026-11-17 13:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 10:06 [PATCH 0/4] drm/sched: Entity handling cleanups Tvrtko Ursulin
2026-11-17 10:06 ` [PATCH 1/4] drm/sched: Disallow initializing entities with un-initialized schedulers Tvrtko Ursulin
2026-11-17 10:46   ` sashiko-bot
2026-11-17 12:11     ` Tvrtko Ursulin
2026-11-17 12:00   ` Philipp Stanner
2026-11-17 12:17     ` Tvrtko Ursulin
2026-11-17 10:06 ` [PATCH 2/4] drm/sched: Ignore stopped entity attempt to change its run-queue Tvrtko Ursulin
2026-11-17 11:53   ` Philipp Stanner
2026-11-17 13:04     ` Tvrtko Ursulin [this message]
2026-11-17 10:06 ` [PATCH 3/4] drm/sched: Remove the single scheduler special case Tvrtko Ursulin
2026-11-17 10:25   ` sashiko-bot
2026-11-17 10:06 ` [PATCH 4/4] drm/sched: Address the fence_seq fixme Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91f421df-4753-4e63-8bc6-daea85c6bb35@igalia.com \
    --to=tvrtko.ursulin@igalia.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-dev@igalia.com \
    --cc=matthew.brost@intel.com \
    --cc=phasta@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.