From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC93FEC2; Thu, 12 Jun 2025 11:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749728198; cv=none; b=qqJ54PAXl1TLAmgqO42bU88ie04Qr1lN0AmOs1ZPF6zfFKCz8MwnxdTeEkZ+E+qU4OmyfagZ36V64sB+W6ZVcMN5lizHCtlLkKgQPz1TwsFnXVIOI4hqiDEzu/gl65xi8ZxU1JqdTOsxtKq6Q9WfAaAArLfCyTsTYLsKHigo6Tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749728198; c=relaxed/simple; bh=3N7FzZgOhubknsIKQSHsXc3phDEJSc5osYBSHxh6U2U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IJRRnEFSFoijwoBRhTx2w3rk7yTraE1PXxqD7Rt1gag0w+DRKtUMxi//3nGyD/yhmoCMqLuQO7erAV2HGbKnHW16IC8HL83Oy8HAkCUmEPRAyFcCMEGfIwKfDJvZEUxxB1jh5JnRgKAyFP8scO+ctd6D6W8omNov9Fz4ryMWYp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LOj+xzJb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LOj+xzJb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD92FC4CEEA; Thu, 12 Jun 2025 11:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749728196; bh=3N7FzZgOhubknsIKQSHsXc3phDEJSc5osYBSHxh6U2U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LOj+xzJbf/LdpybReE9UcMpx/rW+lyky73IQYXZDyAAPfKalv/EfRNvoTs9nfX46d TtPe6y23ROSV5J3Kl0vs3eKKB26VaIuYXqEpjxpzdG8Zrs34h6qMDhFL5yzs9U1mgB DJmPFt07YJowqt/DMTg76/vpvM8yrWorNQ2vr/Fp9BITqUfnfaE3WdbHRIG2o978mh nmudVh2iD9OOf9d5N+/YneBz+94syIx/7K8R+9Gtn80EvrW3uCS4rXmeruh9rWBZq1 PxDftDwMD5DtfF8kluInvAkqY+Erw0mhvOznq1beKPMIh6qje6XVnxwLlXlmkWOI3t Edi4GLs/0z+7g== Message-ID: <91f87756-b44e-41cb-86f2-624204d401ef@kernel.org> Date: Thu, 12 Jun 2025 13:36:31 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/10] dt-bindings: media: qcom: Add Qualcomm MIPI C-/D-PHY schema for CSIPHY IPs To: Vladimir Zapolskiy , Krzysztof Kozlowski , Rob Herring , Bjorn Andersson , Konrad Dybcio , Bryan O'Donoghue Cc: Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Neil Armstrong , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org References: <20250612011531.2923701-1-vladimir.zapolskiy@linaro.org> <20250612011531.2923701-9-vladimir.zapolskiy@linaro.org> <6e411e89-ce1e-4d6a-8d48-b800554f830e@kernel.org> <9e38a09b-1521-4196-b179-d29c62e143bc@linaro.org> <51a91c84-c83f-4b22-9861-88929b222432@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <51a91c84-c83f-4b22-9861-88929b222432@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/06/2025 13:27, Vladimir Zapolskiy wrote: > On 6/12/25 14:02, Krzysztof Kozlowski wrote: >> On 12/06/2025 09:57, Vladimir Zapolskiy wrote: >>> On 6/12/25 10:39, Krzysztof Kozlowski wrote: >>>> On 12/06/2025 09:38, Krzysztof Kozlowski wrote: >>>>> On 12/06/2025 03:15, Vladimir Zapolskiy wrote: >>>>>> Add dt-binding schema for Qualcomm CAMSS CSIPHY IP, which provides >>>>>> MIPI C-PHY/D-PHY interfaces on Qualcomm SoCs. >>>>>> >>>>>> Signed-off-by: Vladimir Zapolskiy >>>>>> --- >>>>>> RFC verion of the change: >>>>>> * https://lore.kernel.org/all/20250513143918.2572689-1-vladimir.zapolskiy@linaro.org/ >>>>>> >>>>>> Changes from RFC to v1: >>>>>> * moved from phy/qcom,csiphy.yaml to media/qcom,csiphy.yaml, >>>>>> * added 'clock-names' property, >>>>>> * removed SM8250 CSIPHY specifics, a generic binding is good enough for now, >>>> >>>> >>>> Now I noticed this... weird change and clearly a no-go. >>>> >>>> Device binding cannot be generic, so it is not good enough for now. >>>> Please write specific bindings for specific hardware. >>>> >>> >>> Can I add platform specific changes on top of the displayed generic one >>> like in Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml >>> etc? >>> >>> The generic compatible is sufficienlty good for adding the enhanced >>> CSIPHY support to any currently present in the upstream platform CAMSS. >>> >>> Obviously I can rename it to something SoC-specific, but then a question >>> arises, if a selected platform has to be a totally new one in the upstream, >>> or it could be among any of platforms with a ready CAMSS, and a backward >>> compatibility is preserved by these series and the new CSIPHY dt bindings. >> >> Just use a specific compatible for the actual hardware this is being >> added for. I don't understand why this is different than all other work >> upstream. > > There are very close examples in upstream, for instance that's a generic > value from Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml: > > properties: > compatible: > enum: > - qcom,dsi-phy-10nm > - qcom,dsi-phy-10nm-8998 That's ancient now style. Don't use something from 10 years ago as example. > > To save time reviewing the next version of the same change, will you > accept a list of acceptable compatible properties like this one? > > properties: > compatible: > enum: > - qcom,csiphy No. You cannot have generic compatible. We keep repeating this all the time, so this is nothing new. > - qcom,sm8250-csiphy > Best regards, Krzysztof