From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] fix checkpatch errors Date: Wed, 27 Jan 2016 19:16:23 +0100 Message-ID: <9204020.3pEC1ROqZC@xps13> References: <1451872319-30737-1-git-send-email-huawei.xie@intel.com> <1453829194-56909-1-git-send-email-huawei.xie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Huawei Xie Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 70E32C2DC for ; Wed, 27 Jan 2016 19:17:33 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id l65so155627567wmf.1 for ; Wed, 27 Jan 2016 10:17:33 -0800 (PST) In-Reply-To: <1453829194-56909-1-git-send-email-huawei.xie@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-01-27 01:26, Huawei Xie: > v2 changes: > add missed commit message in v1 > > fix the error reported by checkpatch: > "ERROR: return is not a function, parentheses are not required" > > also removed other extra parentheses like: > "return val == 0" > "return (rte_mempool_lookup(...))" How these examples are differents from above checkpatch error? Please add Fixes: 6307b909b8e0 ("lib: remove extra parenthesis after return") This is the second run after above commit but I still see a lot of them. Please check git grep 'return *('