Re: [PATCH net] amt: fix gateway mode stuck

[Taehee Yoo <ap420073@gmail.com>]

On 5/17/22 08:10, Jakub Kicinski wrote:

Hi Jakub,

Thanks a lot for your review!

> On Sat, 14 May 2022 13:13:46 +0000 Taehee Yoo wrote:
>> -			if (amt_advertisement_handler(amt, skb))
>> +			err = amt_advertisement_handler(amt, skb);
>> +			if (err)
>>   				amt->dev->stats.rx_dropped++;
>> -			goto out;
>> +			break;
> 
> There's another amt->dev->stats.rx_dropped++; before the end of this
> function which now won't be skipped, I think you're counting twice.
This is intended.
It skips a remaining handling of advertisement message.
So, I think a memory leak would occur at this point, so I added.

Thanks!
Taehee Yoo