From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Peterson <rpeterso@redhat.com>
Date: Mon, 14 Dec 2020 09:02:18 -0500 (EST)
Subject: [Cluster-devel] [PATCH 07/12] gfs2: Get rid of on-stack
 transactions
In-Reply-To: <20201214085442.45467-8-agruenba@redhat.com>
References: <20201214085442.45467-1-agruenba@redhat.com>
	<20201214085442.45467-8-agruenba@redhat.com>
Message-ID: <921985709.35517993.1607954538874.JavaMail.zimbra@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

----- Original Message -----
> +	ret = __gfs2_trans_begin(sdp, 0, revokes, GFP_NOFS | __GFP_NOFAIL);

The addition of __GFP_NOFAIL means that this operation can now block.
Looking at the code, I don't think it will be a problem because it can
already block in the log_flush operations that precede it, but it
makes me nervous. Obviously, we need to test this really well.

Bob