From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60A43C77B6C for ; Thu, 6 Apr 2023 21:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0WtF4gm/p5GF0iMaW8bJcvRnVG1V9rlfhVRF40LzgNs=; b=sOY3/zgdGarqQs jbxZqQyiNgC5lsTxB2Nni1K06XUJnc6oHUP3y00QGfBFQmkSCql27JO/PMHUyq2U+pBQ2h1ZhbWc5 7udeC/FQ9nAgU69hrSRgILWm3tkFVpP3Nz/RqS1yrkh8/AijLxPsMTmCFtW7MTG/RUaPMbNloUJAY 8XA6a5PuAuN/GVFCjRzUJyPZXg6Y9TN3SAULMzNPq11Cum77Mkw3Mhl87ANHAKyuiNMUGo+UF0VxZ 3UwP9BfcdAGS+sQR/8+KYGtJMCtHMrwQDIuecVih/H3TL9NSbkNwEUJzLOBBbZwqoFhNrzTkvnB62 4WXEcXH64OzJiO2c+a0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkXXu-008gsP-2u; Thu, 06 Apr 2023 21:53:30 +0000 Received: from mx3.securetransport.de ([2a01:4f8:c0c:92be::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkXXr-008grA-1q for linux-arm-kernel@lists.infradead.org; Thu, 06 Apr 2023 21:53:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1680817971; bh=f0pUhAJWTLi8vSi9ZobW2xHA14GSuVsrQ9QrsonYrqg=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=INWTRWecbrNYN1h39h2BpE2FJjMvDgcpKlq2WKwJRdckGGMd1vAM0urH1u/7J9HhB +UsFlNbHnKJ/g7+EIGtKtVLJs50Yh85LWPVXdI/6K9lXQLtABCN3G1DjSat/9HacsE 95tOCP4MStHoRYG0MFKFfgn5pUa9Mvy6aqAYPtEagbgT/dP40BQcwtYU3YYgBu8TI+ 3izXQZuLgZYCFpQoPYtMRxTrxUrIggpOGdakUPnR3uo8GJiZ1MhB0Xg01lW5Crrkgu G+PjaCrv6/JrdAtXjrv/WbLQn2dloa4pZILJYEzGkICzBfZJaX2eoFtJdjc3ZvV7FX ajBb2q5iMhj4g== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" CC: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Li Yang , Marek Vasut , Fabio Estevam , NXP Linux Team , kernel , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box Thread-Topic: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box Thread-Index: AQHZaJ93At1GnP2el0yoagNBg+3G/K8eWhSAgAAwTiD//+YUAIAAON0Q///zRYCAADW4IA== Date: Thu, 6 Apr 2023 21:52:41 +0000 Message-ID: <9224dcdbd62641cfb0ee691827d1b57d@dh-electronics.com> References: <20230406154900.6423-1-cniedermaier@dh-electronics.com> <20230406154900.6423-3-cniedermaier@dh-electronics.com> <5478133e-7772-1db9-3473-1ec86fa2aae2@linaro.org> <8353399f-c6de-8da7-78f1-d6a558c462d0@kernel.org> In-Reply-To: <8353399f-c6de-8da7-78f1-d6a558c462d0@kernel.org> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230406_145327_929272_9654895D X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Krzysztof Kozlowski [mailto:krzk@kernel.org] Sent: Thursday, April 6, 2023 10:38 PM > On 06/04/2023 21:57, Christoph Niedermaier wrote: >>>>>> + aliases { >>>>>> + /delete-property/ mmc0; /* Avoid double definitions */ >>>>> >>>>> I don't understand it. What is "double definition" of aliases? >>>> >>>> Otherwise I end up like this: >>>> mmc0 = &usdhc1; >>>> mmc1 = &usdhc2; >>>> mmc2 = &usdhc2; >>>> >>>> Is "Ensure unique allocation" a better comment here? >>>> >>>>> >>>>>> + /delete-property/ mmc1; >>>>>> + mmc2 = &usdhc2; /* eMMC should be mmc2 */ >>>>> >>>>> Why? How is this labeled on the board (physically or on schematics)? If >>>>> you answer here "for booting", then the answer is NAK. Don't add >>>>> software policies to Devicetree. >>>> >>>> The name in the schematics is "SD2". >>> >>> Answering also to above - then likely the aliases should be dropped from >>> SoM. I doubt that Som calls it SD1 and your board SD2... >> >> Maybe I don't quite get it, but the hardware starts counting at 1. The first >> interface is SD1 and it is used as WiFi. The second one is SD2 which is the >> eMMC. So with this aliases it should match SD2 to mmc2. >> Do you want me to delete the aliases in the include file "imx6ull-dhcor-som.dtsi" > > Yes, because it incorrectly calls eMMC as mmc1. You said it is SD2, right? Yes. I will do this in version 3. Thanks and best regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 953B4C76196 for ; Thu, 6 Apr 2023 21:53:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231320AbjDFVxn (ORCPT ); Thu, 6 Apr 2023 17:53:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbjDFVxn (ORCPT ); Thu, 6 Apr 2023 17:53:43 -0400 Received: from mx3.securetransport.de (mx3.securetransport.de [116.203.31.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 882AAA5FC; Thu, 6 Apr 2023 14:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1680817971; bh=f0pUhAJWTLi8vSi9ZobW2xHA14GSuVsrQ9QrsonYrqg=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=INWTRWecbrNYN1h39h2BpE2FJjMvDgcpKlq2WKwJRdckGGMd1vAM0urH1u/7J9HhB +UsFlNbHnKJ/g7+EIGtKtVLJs50Yh85LWPVXdI/6K9lXQLtABCN3G1DjSat/9HacsE 95tOCP4MStHoRYG0MFKFfgn5pUa9Mvy6aqAYPtEagbgT/dP40BQcwtYU3YYgBu8TI+ 3izXQZuLgZYCFpQoPYtMRxTrxUrIggpOGdakUPnR3uo8GJiZ1MhB0Xg01lW5Crrkgu G+PjaCrv6/JrdAtXjrv/WbLQn2dloa4pZILJYEzGkICzBfZJaX2eoFtJdjc3ZvV7FX ajBb2q5iMhj4g== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" CC: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Li Yang , Marek Vasut , Fabio Estevam , NXP Linux Team , kernel , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box Thread-Topic: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box Thread-Index: AQHZaJ93At1GnP2el0yoagNBg+3G/K8eWhSAgAAwTiD//+YUAIAAON0Q///zRYCAADW4IA== Date: Thu, 6 Apr 2023 21:52:41 +0000 Message-ID: <9224dcdbd62641cfb0ee691827d1b57d@dh-electronics.com> References: <20230406154900.6423-1-cniedermaier@dh-electronics.com> <20230406154900.6423-3-cniedermaier@dh-electronics.com> <5478133e-7772-1db9-3473-1ec86fa2aae2@linaro.org> <8353399f-c6de-8da7-78f1-d6a558c462d0@kernel.org> In-Reply-To: <8353399f-c6de-8da7-78f1-d6a558c462d0@kernel.org> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org RnJvbTogS3J6eXN6dG9mIEtvemxvd3NraSBbbWFpbHRvOmtyemtAa2VybmVsLm9yZ10NClNlbnQ6 IFRodXJzZGF5LCBBcHJpbCA2LCAyMDIzIDEwOjM4IFBNDQo+IE9uIDA2LzA0LzIwMjMgMjE6NTcs IENocmlzdG9waCBOaWVkZXJtYWllciB3cm90ZToNCj4+Pj4+PiArICAgICBhbGlhc2VzIHsNCj4+ Pj4+PiArICAgICAgICAgICAgIC9kZWxldGUtcHJvcGVydHkvIG1tYzA7IC8qIEF2b2lkIGRvdWJs ZSBkZWZpbml0aW9ucyAqLw0KPj4+Pj4NCj4+Pj4+IEkgZG9uJ3QgdW5kZXJzdGFuZCBpdC4gV2hh dCBpcyAiZG91YmxlIGRlZmluaXRpb24iIG9mIGFsaWFzZXM/DQo+Pj4+DQo+Pj4+IE90aGVyd2lz ZSBJIGVuZCB1cCBsaWtlIHRoaXM6DQo+Pj4+IG1tYzAgPSAmdXNkaGMxOw0KPj4+PiBtbWMxID0g JnVzZGhjMjsNCj4+Pj4gbW1jMiA9ICZ1c2RoYzI7DQo+Pj4+DQo+Pj4+IElzICJFbnN1cmUgdW5p cXVlIGFsbG9jYXRpb24iIGEgYmV0dGVyIGNvbW1lbnQgaGVyZT8NCj4+Pj4NCj4+Pj4+DQo+Pj4+ Pj4gKyAgICAgICAgICAgICAvZGVsZXRlLXByb3BlcnR5LyBtbWMxOw0KPj4+Pj4+ICsgICAgICAg ICAgICAgbW1jMiA9ICZ1c2RoYzI7IC8qIGVNTUMgc2hvdWxkIGJlIG1tYzIgKi8NCj4+Pj4+DQo+ Pj4+PiBXaHk/IEhvdyBpcyB0aGlzIGxhYmVsZWQgb24gdGhlIGJvYXJkIChwaHlzaWNhbGx5IG9y IG9uIHNjaGVtYXRpY3MpPyBJZg0KPj4+Pj4geW91IGFuc3dlciBoZXJlICJmb3IgYm9vdGluZyIs IHRoZW4gdGhlIGFuc3dlciBpcyBOQUsuIERvbid0IGFkZA0KPj4+Pj4gc29mdHdhcmUgcG9saWNp ZXMgdG8gRGV2aWNldHJlZS4NCj4+Pj4NCj4+Pj4gVGhlIG5hbWUgaW4gdGhlIHNjaGVtYXRpY3Mg aXMgIlNEMiIuDQo+Pj4NCj4+PiBBbnN3ZXJpbmcgYWxzbyB0byBhYm92ZSAtIHRoZW4gbGlrZWx5 IHRoZSBhbGlhc2VzIHNob3VsZCBiZSBkcm9wcGVkIGZyb20NCj4+PiBTb00uIEkgZG91YnQgdGhh dCBTb20gY2FsbHMgaXQgU0QxIGFuZCB5b3VyIGJvYXJkIFNEMi4uLg0KPj4NCj4+IE1heWJlIEkg ZG9uJ3QgcXVpdGUgZ2V0IGl0LCBidXQgdGhlIGhhcmR3YXJlIHN0YXJ0cyBjb3VudGluZyBhdCAx LiBUaGUgZmlyc3QNCj4+IGludGVyZmFjZSBpcyBTRDEgYW5kIGl0IGlzIHVzZWQgYXMgV2lGaS4g VGhlIHNlY29uZCBvbmUgaXMgU0QyIHdoaWNoIGlzIHRoZQ0KPj4gZU1NQy4gU28gd2l0aCB0aGlz IGFsaWFzZXMgaXQgc2hvdWxkIG1hdGNoIFNEMiB0byBtbWMyLg0KPj4gRG8geW91IHdhbnQgbWUg dG8gZGVsZXRlIHRoZSBhbGlhc2VzIGluIHRoZSBpbmNsdWRlIGZpbGUgImlteDZ1bGwtZGhjb3It c29tLmR0c2kiDQo+IA0KPiBZZXMsIGJlY2F1c2UgaXQgaW5jb3JyZWN0bHkgY2FsbHMgZU1NQyBh cyBtbWMxLiBZb3Ugc2FpZCBpdCBpcyBTRDIsIHJpZ2h0Pw0KDQpZZXMuIEkgd2lsbCBkbyB0aGlz IGluIHZlcnNpb24gMy4NCg0KDQpUaGFua3MgYW5kIGJlc3QgcmVnYXJkcw0KQ2hyaXN0b3BoDQo=