From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D7AC433EF for ; Thu, 3 Mar 2022 20:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234753AbiCCUBo (ORCPT ); Thu, 3 Mar 2022 15:01:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231695AbiCCUBo (ORCPT ); Thu, 3 Mar 2022 15:01:44 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 025191A3636 for ; Thu, 3 Mar 2022 12:00:57 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E952143D; Thu, 3 Mar 2022 12:00:57 -0800 (PST) Received: from [192.168.122.164] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 49B6E3F70D; Thu, 3 Mar 2022 12:00:57 -0800 (PST) Message-ID: <922fab4e-0608-0d46-9379-026a51398b7a@arm.com> Date: Thu, 3 Mar 2022 14:00:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] net: bcmgenet: Return not supported if we don't have a WoL IRQ Content-Language: en-US To: Jakub Kicinski , Florian Fainelli Cc: Peter Robinson , Doug Berger , "David S. Miller" , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, Javier Martinez Canillas References: <20220222095348.2926536-1-pbrobinson@gmail.com> <734024dc-dadd-f92d-cbbb-c8dc9c955ec3@gmail.com> <3ae3a9fc-9dd1-00c6-4ae8-a65df3ed225f@gmail.com> <6cefe7ca-842b-d3af-0299-588b9307703b@gmail.com> <20220223144818.2f9ce725@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Jeremy Linton In-Reply-To: <20220223144818.2f9ce725@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On 2/23/22 16:48, Jakub Kicinski wrote: > On Wed, 23 Feb 2022 09:54:26 -0800 Florian Fainelli wrote: >>> I have no problems working with you to improve the driver, the problem >>> I have is this is currently a regression in 5.17 so I would like to >>> see something land, whether it's reverting the other patch, landing >>> thing one or another straight forward fix and then maybe revisit as >>> whole in 5.18. >> >> Understood and I won't require you or me to complete this investigating >> before fixing the regression, this is just so we understand where it >> stemmed from and possibly fix the IRQ layer if need be. Given what I >> just wrote, do you think you can sprinkle debug prints throughout the >> kernel to figure out whether enable_irq_wake() somehow messes up the >> interrupt descriptor of interrupt and test that theory? We can do that >> offline if you want. > > Let me mark v2 as Deferred for now, then. I'm not really sure if that's > what's intended but we have 3 weeks or so until 5.17 is cut so we can > afford a few days of investigating. > > I'm likely missing the point but sounds like the IRQ subsystem treats > IRQ numbers as unsigned so if we pass a negative value "fun" is sort > of expected. Isn't the problem that device somehow comes with wakeup > capable being set already? Isn't it better to make sure device is not > wake capable if there's no WoL irq instead of adding second check? > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > index cfe09117fe6c..7dea44803beb 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > @@ -4020,12 +4020,12 @@ static int bcmgenet_probe(struct platform_device *pdev) > > /* Request the WOL interrupt and advertise suspend if available */ > priv->wol_irq_disabled = true; > - if (priv->wol_irq > 0) { > + if (priv->wol_irq > 0) > err = devm_request_irq(&pdev->dev, priv->wol_irq, > bcmgenet_wol_isr, 0, dev->name, priv); > - if (!err) > - device_set_wakeup_capable(&pdev->dev, 1); > - } > + else > + err = -ENOENT; > + device_set_wakeup_capable(&pdev->dev, !err); > > /* Set the needed headroom to account for any possible > * features enabling/disabling at runtime > I duplicated the problem on rpi4/ACPI by moving to gcc12, so I have a/b config that is close as I can achieve using gcc11 vs 12 and the one built with gcc12 fails pretty consistently while the gcc11 works. So, I assumed that applying this patch would fix it, but it doesn't. I may have messed something up, but I'm trying to figure out what is actually different in the two modules between gcc11 and 12.