Re: [PATCH v3] app/testpmd: print statistics periodically

[Thomas Monjalon <thomas@monjalon.net>]

15/06/2017 03:48, Pablo de Lara:
> +print_stats(void)
> +{
> +	uint8_t i;
> +	const char clr[] = { 27, '[', '2', 'J', '\0' };
> +	const char topLeft[] = { 27, '[', '1', ';', '1', 'H', '\0' };

Spotted a CamelCase ;)
Is there a punishment planned in the contributor's guide?

> +		if (stats_period != 0) {
> +			uint64_t prev_tsc = 0, cur_tsc, timer_tsc = 0;
> +			uint64_t timer_period;
> +
> +			/* Convert to number of cycles */
> +			timer_period = stats_period * rte_get_timer_hz();
> +
> +			while (1) {
> +				cur_tsc = rte_rdtsc();
> +				timer_tsc += cur_tsc - prev_tsc;

Please forget (Intel) TSC wording and prefer the more generic
rte_get_timer_cycles() function.