From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 6/6] ARM: dts: exynos5420: add sclk_pcm_in to audss clock controller Date: Sat, 21 Sep 2013 17:18:14 +0200 Message-ID: <9260897.NJpGqJ1JKi@flatron> References: <1379711637-5226-1-git-send-email-abrestic@chromium.org> <1379711637-5226-6-git-send-email-abrestic@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1379711637-5226-6-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Bresticker Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Kukjin Kim , Russell King , Mike Turquette , Grant Likely , Sachin Kamat , Jiri Kosina , Rahul Sharma , Leela Krishna Amudala , Stephen Boyd , Tomasz Figa , Tushar Behera , Yadwinder Singh Brar , Doug Anderson , Padmavathi Venna , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.orglinux- List-Id: linux-samsung-soc@vger.kernel.org Hi Andrew, On Friday 20 of September 2013 14:13:57 Andrew Bresticker wrote: > The parent of sclk_pcm in the AudioSS block is sclk_maupcm0. > > Signed-off-by: Andrew Bresticker > --- > arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi > b/arch/arm/boot/dts/exynos5420.dtsi index d537cd7..339ab93 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -72,8 +72,8 @@ > compatible = "samsung,exynos5420-audss-clock"; > reg = <0x03810000 0x0C>; > #clock-cells = <1>; > - clocks = <&clock 148>; > - clock-names = "sclk_audio"; > + clocks = <&clock 148>, <&clock 149>; > + clock-names = "sclk_audio", "sclk_pcm_in"; Same note as for Exynos 5250. I think it would be more reasonable to specify all the input clocks here. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Sat, 21 Sep 2013 17:18:14 +0200 Subject: [PATCH 6/6] ARM: dts: exynos5420: add sclk_pcm_in to audss clock controller In-Reply-To: <1379711637-5226-6-git-send-email-abrestic@chromium.org> References: <1379711637-5226-1-git-send-email-abrestic@chromium.org> <1379711637-5226-6-git-send-email-abrestic@chromium.org> Message-ID: <9260897.NJpGqJ1JKi@flatron> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Andrew, On Friday 20 of September 2013 14:13:57 Andrew Bresticker wrote: > The parent of sclk_pcm in the AudioSS block is sclk_maupcm0. > > Signed-off-by: Andrew Bresticker > --- > arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi > b/arch/arm/boot/dts/exynos5420.dtsi index d537cd7..339ab93 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -72,8 +72,8 @@ > compatible = "samsung,exynos5420-audss-clock"; > reg = <0x03810000 0x0C>; > #clock-cells = <1>; > - clocks = <&clock 148>; > - clock-names = "sclk_audio"; > + clocks = <&clock 148>, <&clock 149>; > + clock-names = "sclk_audio", "sclk_pcm_in"; Same note as for Exynos 5250. I think it would be more reasonable to specify all the input clocks here. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752824Ab3IUPSW (ORCPT ); Sat, 21 Sep 2013 11:18:22 -0400 Received: from mail-ee0-f52.google.com ([74.125.83.52]:48478 "EHLO mail-ee0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271Ab3IUPST (ORCPT ); Sat, 21 Sep 2013 11:18:19 -0400 From: Tomasz Figa To: Andrew Bresticker Cc: linux-samsung-soc@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Kukjin Kim , Russell King , Mike Turquette , Grant Likely , Sachin Kamat , Jiri Kosina , Rahul Sharma , Leela Krishna Amudala , Stephen Boyd , Tomasz Figa , Tushar Behera , Yadwinder Singh Brar , Doug Anderson , Padmavathi Venna , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] ARM: dts: exynos5420: add sclk_pcm_in to audss clock controller Date: Sat, 21 Sep 2013 17:18:14 +0200 Message-ID: <9260897.NJpGqJ1JKi@flatron> User-Agent: KMail/4.11.1 (Linux/3.11.1-gentoo; KDE/4.11.1; x86_64; ; ) In-Reply-To: <1379711637-5226-6-git-send-email-abrestic@chromium.org> References: <1379711637-5226-1-git-send-email-abrestic@chromium.org> <1379711637-5226-6-git-send-email-abrestic@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On Friday 20 of September 2013 14:13:57 Andrew Bresticker wrote: > The parent of sclk_pcm in the AudioSS block is sclk_maupcm0. > > Signed-off-by: Andrew Bresticker > --- > arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi > b/arch/arm/boot/dts/exynos5420.dtsi index d537cd7..339ab93 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -72,8 +72,8 @@ > compatible = "samsung,exynos5420-audss-clock"; > reg = <0x03810000 0x0C>; > #clock-cells = <1>; > - clocks = <&clock 148>; > - clock-names = "sclk_audio"; > + clocks = <&clock 148>, <&clock 149>; > + clock-names = "sclk_audio", "sclk_pcm_in"; Same note as for Exynos 5250. I think it would be more reasonable to specify all the input clocks here. Best regards, Tomasz