Re: [PATCH net-next] ppp: pass private data to channel callbacks

[Jiri Slaby <jirislaby@kernel.org>]

Hi,

On 04. 09. 26, 5:11, Qingfang Deng wrote:
> PPP channel callbacks receive struct ppp_channel only to retrieve the
> driver's private pointer. Pass that pointer directly instead.

We had type checking at least. What's the purpose of this patch, actually?

> Signed-off-by: Qingfang Deng <qingfang.deng@linux.dev>
> ---
>   drivers/net/ppp/ppp_async.c   | 13 ++++++-------
>   drivers/net/ppp/ppp_generic.c | 12 ++++++------
>   drivers/net/ppp/ppp_synctty.c | 13 ++++++-------
>   drivers/net/ppp/pppoe.c       |  8 ++++----
>   drivers/net/ppp/pptp.c        |  9 ++++-----
>   include/linux/ppp_channel.h   |  6 +++---
>   net/atm/pppoatm.c             | 21 ++++++++-------------
>   net/l2tp/l2tp_ppp.c           |  6 +++---
>   8 files changed, 40 insertions(+), 48 deletions(-)
> 
> diff --git a/drivers/net/ppp/ppp_async.c b/drivers/net/ppp/ppp_async.c
> index ea7fe9608ffd..e73b0fce86b9 100644
> --- a/drivers/net/ppp/ppp_async.c
> +++ b/drivers/net/ppp/ppp_async.c
> @@ -91,13 +91,12 @@ MODULE_ALIAS_LDISC(N_PPP);
>    * Prototypes.
>    */
>   static int ppp_async_encode(struct asyncppp *ap);
> -static int ppp_async_send(struct ppp_channel *chan, struct sk_buff *skb);
> +static int ppp_async_send(void *private, struct sk_buff *skb);
thanks,
-- 
js
suse labs