Re: [pseudo] [PATCH v2 1/2] ports/linux/guts: Implement close_range() instead of returning ENOSYS

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2026-07-16 at 05:56 +0000, Babanpreet Singh wrote:
> The close_range() wrapper added in 35433e6 ("ports/linux/guts: Add
> close_range wrapper for glibc 2.34") returns ENOSYS on the assumption
> that callers handle that. systemd v260 no longer does: it removed its
> /proc/self/fd fallback and treats a close_range() failure as fatal, so
> every fork+exec under pseudo aborts:
> 
>     Failed to close all file descriptors: Function not implemented
>     '(mkfs)' failed with exit status 1.
> 
> A client side op closes the low descriptors one at a time, skipping the
> ones pseudo needs for itself, and returns the first fd above pseudo's
> own so the caller can pass the rest of the range to the kernel directly.
> 
> CLOSE_RANGE_UNSHARE is handled by calling unshare(CLONE_FILES) before
> closing anything, so the closes only affect the caller and not other
> processes sharing the descriptor table. Unknown flags and an inverted
> range are rejected with EINVAL before anything is closed.
> 
> A range starting entirely above INT_MAX cannot contain any of pseudo's
> fds and is also passed straight through.
> 
> [YOCTO #16339]
> 
> AI-Generated: Uses Claude (claude-opus-4-8)
> Signed-off-by: Babanpreet Singh <bbnpreetsingh@gmail.com>
> ---
>  enums/op.in                    |  1 +
>  ports/linux/guts/close_range.c | 54 ++++++++++++++++++++++++++----
>  ports/linux/portdefs.h         | 16 +++++++++
>  pseudo_client.c                | 60 ++++++++++++++++++++++++++++++++++
>  4 files changed, 124 insertions(+), 7 deletions(-)

Unfortunately there is something wrong in this patch. I added this
series and your other series fixing the closed fds and with this patch
present, we see failures:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/50/builds/4259

i.e. linux-libc-headers do_install fails, which is one of the first
pieces of the OE build to use pseudo. This should be reproducible in a
OE build with "bitbake linux-libc-headers -c install", with a patch
like the one below applied to update pseudo.

As soon as I revert this patch, the builds work ok. I also tested with
the second series applied without this patch (patches tweaked to apply)
and that also seems to build ok, so it would appear to be something in
this change.

I've not dug into it in detail yet but I wanted to share the issue now
I've isolated it.

Cheers,

Richard


diff --git a/meta/recipes-devtools/pseudo/pseudo_git.bb b/meta/recipes-devtools/pseudo/pseudo_git.bb
index 9f02d90568..01a66ae21e 100644
--- a/meta/recipes-devtools/pseudo/pseudo_git.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_git.bb
@@ -1,6 +1,6 @@
 require pseudo.inc
 
-SRC_URI = "git://git.yoctoproject.org/pseudo;branch=master;protocol=https;branch=master \
+SRC_URI = "git://git.yoctoproject.org/pseudo;branch=master-next;protocol=https \
            file://fallback-passwd \
            file://fallback-group \
            "
@@ -12,8 +12,8 @@ SRC_URI:append:class-nativesdk = " \
     file://older-glibc-symbols.patch"
 SRC_URI[prebuilt.sha256sum] = "ed9f456856e9d86359f169f46a70ad7be4190d6040282b84c8d97b99072485aa"
 
-SRCREV = "ca47829825f297d7bf83665c0541a9de4aa78009"
-PV = "1.9.8+git"
+SRCREV = "7f509ca924d27109335c4575d1fb67745c7b3abd"
+PV = "1.9.9+git"
 
 # largefile and 64bit time_t support adds these macros via compiler flags globally
 # remove them for pseudo since pseudo intercepts some of the functions which will be