From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Yang Jihong <yangjihong1@huawei.com>,
acme@kernel.org, irogers@google.com, jolsa@kernel.org,
namhyung@kernel.org, adrian.hunter@intel.com
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, kan.liang@linux.intel.com,
james.clark@arm.com, tmricht@linux.ibm.com, ak@linux.intel.com,
anshuman.khandual@arm.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v7 0/6] perf record: Track sideband events for all CPUs when tracing selected CPUs
Date: Tue, 29 Aug 2023 17:54:23 +0530 [thread overview]
Message-ID: <929ddd1f-dc15-079c-331d-13cc5f25a1a2@amd.com> (raw)
In-Reply-To: <93abb0e0-1691-a887-f7b2-7591f83a8618@huawei.com>
>> Number of actual samples are same ~38K. However, the perf.data file is 5x
>> bigger because of additional sideband data.
>
> Yes, if record system wide sideband data, the amount of sideband events will increase proportionally, which is expected.
>
>>
>> I'm pretty sure we don't need most of those additional data. So, thinking
>> loud, should we post-process perf.data file and filter out unnecessary data?
>>
>
> I wonder if we can add a new function in perf inject.
Ok. perf inject is one option. But shall we do it bydefault in perf-record?
It's needed only when profiling target is set of cpus, not for systemwide or
per-process mode.
> By reading perf.data and comparing tid of SAMPLE events and sideband events, we can filter out the sideband data of unmatched tasks.
Yup. But AFAIK, perf-record keeps writing to perf.data and never does post-
processing on it. So adding support for this will take a bit of effort. Not
sure if we should do it as part of this series.
Thanks,
Ravi
next prev parent reply other threads:[~2023-08-29 12:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 3:26 [PATCH v7 0/6] perf record: Track sideband events for all CPUs when tracing selected CPUs Yang Jihong
2023-08-26 3:26 ` [PATCH v7 1/6] perf evlist: Add perf_evlist__go_system_wide() helper Yang Jihong
2023-08-26 3:26 ` [PATCH v7 2/6] perf evlist: Add evlist__findnew_tracking_event() helper Yang Jihong
2023-08-26 3:26 ` [PATCH v7 3/6] perf record: Move setting tracking events before record__init_thread_masks() Yang Jihong
2023-08-26 3:26 ` [PATCH v7 4/6] perf record: Track sideband events for all CPUs when tracing selected CPUs Yang Jihong
2023-08-26 14:59 ` Namhyung Kim
2023-08-28 3:03 ` Yang Jihong
2023-08-28 11:25 ` Adrian Hunter
2023-08-29 1:40 ` Yang Jihong
2023-08-26 3:26 ` [PATCH v7 5/6] perf test: Add test case for record sideband events Yang Jihong
2023-08-26 3:26 ` [PATCH v7 6/6] perf test: Add perf_event_attr test for record selected CPUs exclude_user Yang Jihong
2023-08-29 5:37 ` [PATCH v7 0/6] perf record: Track sideband events for all CPUs when tracing selected CPUs Ravi Bangoria
2023-08-29 9:34 ` Yang Jihong
2023-08-29 12:24 ` Ravi Bangoria [this message]
2023-08-31 10:13 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=929ddd1f-dc15-079c-331d-13cc5f25a1a2@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.