From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F31C433F5 for ; Mon, 4 Apr 2022 15:48:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378675AbiDDPuQ (ORCPT ); Mon, 4 Apr 2022 11:50:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235747AbiDDPuQ (ORCPT ); Mon, 4 Apr 2022 11:50:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8ACAF261A for ; Mon, 4 Apr 2022 08:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649087298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACaAB1t0vMWb3pX2ELgBqL+jg9CnsBzljXi5Wr6J60o=; b=ahQIZJveoaR+Y6dsDE5k2DBuix4glwxgmWuUbkU0t6K4znyfEdZbQU0DnSa5F71Xd5sait JYdGNQBlf25YwkWQPb2M6fY5lX/sqaQucXMv7nxKHSdttWiCSza4IweLIWkf7wOz7rCqeN W5yW13uy+n5yMyAAHFYJZPiq4Sals0o= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-548-5bcm1QfLPLG4BGUNo7H2Nw-1; Mon, 04 Apr 2022 11:48:17 -0400 X-MC-Unique: 5bcm1QfLPLG4BGUNo7H2Nw-1 Received: by mail-wr1-f69.google.com with SMTP id j18-20020adfa552000000b002060a011303so1013732wrb.14 for ; Mon, 04 Apr 2022 08:48:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ACaAB1t0vMWb3pX2ELgBqL+jg9CnsBzljXi5Wr6J60o=; b=BIqwKg2Zjw0eggwZa5fJenp1v9fsuEW5SLjZE2wSt5VYdswZGUdNFKVXjmOGS6xuP9 T9byoG6PHlDbwi6Te6QaVV3OOJfpfvHKFeRAeG1jceeYFNydSqL7iigSDNvxANe/Hbzq GakzUN0pp+raeGWzjNYF8MtOSXfAaC+NHlpP+s6W32V4apw2bOu+/356JZeg+7QdcT/n 5YFWhyx3LsNQ/+g64oZB2PLgyN60NaQxQt/YzeQApftrHullc87/lqup8LGlYAEH/uRV xxVUU4hxAdaq+fMY1LwRx/DY0vS4b5Cbhf90WGQvL9rWTXtf+CO+HbseXD/pcyf+Ql+/ IPcw== X-Gm-Message-State: AOAM532WoB/2sA6PHIyr/o0pAX1rGwkx0ZqsSQrdYsVm1g3z1Zkjfebb LCGjNDxV3lBDVxvfKtP78stGXV98dKZ6EHXczMJLDTqAayxBVDW5aDiZFtLDzSYS5a+S37j1guH 3rwSOnM6xUrTocxE82GNt2g== X-Received: by 2002:adf:f188:0:b0:206:e20:1b65 with SMTP id h8-20020adff188000000b002060e201b65mr259498wro.363.1649087296378; Mon, 04 Apr 2022 08:48:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+jBXSnytEUbHzPD7PrJYBhDtVRIkCeBYl9hIqrrHNXMn+EkEqSV4Kzkt4zlwuYyU9ugLZaA== X-Received: by 2002:adf:f188:0:b0:206:e20:1b65 with SMTP id h8-20020adff188000000b002060e201b65mr259479wro.363.1649087296112; Mon, 04 Apr 2022 08:48:16 -0700 (PDT) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id v14-20020a7bcb4e000000b0034492fa24c6sm9737099wmj.34.2022.04.04.08.48.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Apr 2022 08:48:15 -0700 (PDT) Message-ID: <92a46ea2-e23e-b7c8-ea5f-35d458ee1b76@redhat.com> Date: Mon, 4 Apr 2022 17:48:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 2/4] dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106 Content-Language: en-US To: wens@kernel.org, Javier Martinez Canillas Cc: Maxime Ripard , Rob Herring , Krzysztof Kozlowski , David Airlie , Daniel Vetter , devicetree , Linux Kernel , dri-devel References: <20220330190846.13997-1-wens@kernel.org> <20220330190846.13997-3-wens@kernel.org> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Chen-Yu, On 4/4/22 17:06, Chen-Yu Tsai wrote: [snip] >>> enum: >>> + - sinowealth,sh1106-i2c >> >> I like that you didn't include a "fb" suffix for this, the existing >> ones are cargo culting from the previous fbdev driver to make existing >> DTBs compatible with the DRM driver. >> >> I've been thinking if I should post a patch to compatible strings >> without the "fb" and mark the current ones as deprecated... >> >> Reviewed-by: Javier Martinez Canillas > > I also thought about dropping the "-i2c" suffix, but then thought > there might be a case where someone wanted to search the device > tree specifically for an I2C connected node using said compatible > string. > > What do you think? > > tl; dr: unfortunately we can't do it due how SPI and I2C report module aliases. Otherwise module auto loading will not work. I wrote a much longer explanation with some details not so long ago: https://patchwork.kernel.org/project/dri-devel/patch/20220209091204.2513437-1-javierm@redhat.com/#24730793 BTW, I bought a SSD1306 SPI controller and go it working this weekend. I plan to post the patches once yours land, to avoid in-flight series that may conflict. And what I did is mark the -fb as deprecated, then added "ssd130x-i2c" and "ssd130x-spi" compatibles strings. The WIP patches can be found here in case you are interested: https://github.com/martinezjavier/linux/tree/drm-ssd130x-spi > ChenYu > -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84A57C433EF for ; Mon, 4 Apr 2022 15:48:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E952510E021; Mon, 4 Apr 2022 15:48:20 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 786EB10E021 for ; Mon, 4 Apr 2022 15:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649087298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACaAB1t0vMWb3pX2ELgBqL+jg9CnsBzljXi5Wr6J60o=; b=ahQIZJveoaR+Y6dsDE5k2DBuix4glwxgmWuUbkU0t6K4znyfEdZbQU0DnSa5F71Xd5sait JYdGNQBlf25YwkWQPb2M6fY5lX/sqaQucXMv7nxKHSdttWiCSza4IweLIWkf7wOz7rCqeN W5yW13uy+n5yMyAAHFYJZPiq4Sals0o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-300-310k7deENWWewKJHLA3v3w-1; Mon, 04 Apr 2022 11:48:17 -0400 X-MC-Unique: 310k7deENWWewKJHLA3v3w-1 Received: by mail-wm1-f72.google.com with SMTP id m35-20020a05600c3b2300b0038c90ef2dceso7091632wms.4 for ; Mon, 04 Apr 2022 08:48:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ACaAB1t0vMWb3pX2ELgBqL+jg9CnsBzljXi5Wr6J60o=; b=kgpNGKMcYIZKBl0FF0Xt89GqjRUl68M0MN4cZNz25ixWp8RzBksCVfPCLJWEj67bON NqoKknAyv0RCswJa50JAgO3wjXd51mnAqhC53EYVbrrGIVcMQT2L2MWPn1fAeqRg7Obb tYQ5PeebSpjF5kw7+GsaBbMqhzJUQ6v5mfg9fqvJm9AH9oaK2uRsRryZGmyyKqSAVhbp BjxDSk+jT5UzTClyONrRUWh91AvMtQw+R/bq2USPlUHQF1hQ9biX9QQJpkMY8mUxKjYD xyU9EInsVfhzL2rzu8aWJTCaR9/Z+qM1GR8qGtfTEdn0ZSJiS9LhU9XIKfGpzPZg777j 8nHQ== X-Gm-Message-State: AOAM533YMZrlZp6yNeb2L84MJgBPCfoHuzAIye0c7AESwo9Jn4D9gJK2 F0aXI92LIfRNQfv7UlJ2OT4x8f4BWbfmHfrkh4A3Br/U8QQRrlKB9mCMEfC1kNKmYOweBe87RRO sZTz5vDFuy+Y87wIx24ydqV0Ju/x+ X-Received: by 2002:adf:f188:0:b0:206:e20:1b65 with SMTP id h8-20020adff188000000b002060e201b65mr259496wro.363.1649087296378; Mon, 04 Apr 2022 08:48:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+jBXSnytEUbHzPD7PrJYBhDtVRIkCeBYl9hIqrrHNXMn+EkEqSV4Kzkt4zlwuYyU9ugLZaA== X-Received: by 2002:adf:f188:0:b0:206:e20:1b65 with SMTP id h8-20020adff188000000b002060e201b65mr259479wro.363.1649087296112; Mon, 04 Apr 2022 08:48:16 -0700 (PDT) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id v14-20020a7bcb4e000000b0034492fa24c6sm9737099wmj.34.2022.04.04.08.48.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Apr 2022 08:48:15 -0700 (PDT) Message-ID: <92a46ea2-e23e-b7c8-ea5f-35d458ee1b76@redhat.com> Date: Mon, 4 Apr 2022 17:48:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 2/4] dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106 To: wens@kernel.org, Javier Martinez Canillas References: <20220330190846.13997-1-wens@kernel.org> <20220330190846.13997-3-wens@kernel.org> From: Javier Martinez Canillas In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , David Airlie , Linux Kernel , Rob Herring , dri-devel , Krzysztof Kozlowski Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Chen-Yu, On 4/4/22 17:06, Chen-Yu Tsai wrote: [snip] >>> enum: >>> + - sinowealth,sh1106-i2c >> >> I like that you didn't include a "fb" suffix for this, the existing >> ones are cargo culting from the previous fbdev driver to make existing >> DTBs compatible with the DRM driver. >> >> I've been thinking if I should post a patch to compatible strings >> without the "fb" and mark the current ones as deprecated... >> >> Reviewed-by: Javier Martinez Canillas > > I also thought about dropping the "-i2c" suffix, but then thought > there might be a case where someone wanted to search the device > tree specifically for an I2C connected node using said compatible > string. > > What do you think? > > tl; dr: unfortunately we can't do it due how SPI and I2C report module aliases. Otherwise module auto loading will not work. I wrote a much longer explanation with some details not so long ago: https://patchwork.kernel.org/project/dri-devel/patch/20220209091204.2513437-1-javierm@redhat.com/#24730793 BTW, I bought a SSD1306 SPI controller and go it working this weekend. I plan to post the patches once yours land, to avoid in-flight series that may conflict. And what I did is mark the -fb as deprecated, then added "ssd130x-i2c" and "ssd130x-spi" compatibles strings. The WIP patches can be found here in case you are interested: https://github.com/martinezjavier/linux/tree/drm-ssd130x-spi > ChenYu > -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat