From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Armin Wolf <W_Armin@gmx.de>
Cc: Hans de Goede <hdegoede@redhat.com>,
corbet@lwn.net, Dell.Client.Kernel@dell.com,
linux-doc@vger.kernel.org, platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] platform/x86: wmi: Remove chardev interface
Date: Fri, 8 Dec 2023 15:43:23 +0200 (EET) [thread overview]
Message-ID: <92e2d5f-77cd-30b0-64e5-28f767baf776@linux.intel.com> (raw)
In-Reply-To: <20231207222623.232074-5-W_Armin@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
On Thu, 7 Dec 2023, Armin Wolf wrote:
> The design of the WMI chardev interface is broken:
> - it assumes that WMI drivers are not instantiated twice
> - it offers next to no abstractions, the WMI driver gets
> a raw byte buffer
> - it is only used by a single driver, something which is
> unlikely to change
>
> Since the only user (dell-smbios-wmi) has been migrated
> to his own ioctl interface, remove it.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2023-12-08 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 22:26 [PATCH 0/5] platform/x86: wmi: Cleanup obsolete features Armin Wolf
2023-12-07 22:26 ` [PATCH 1/5] platform/x86: wmi: Remove debug_dump_wdg module param Armin Wolf
2023-12-08 11:30 ` Ilpo Järvinen
2023-12-07 22:26 ` [PATCH 2/5] platform/x86: wmi: Remove debug_event " Armin Wolf
2023-12-08 11:33 ` Ilpo Järvinen
2023-12-07 22:26 ` [PATCH 3/5] platform/x86: dell-smbios-wmi: Stop using WMI chardev Armin Wolf
2023-12-08 13:41 ` Ilpo Järvinen
2023-12-08 18:00 ` Armin Wolf
2023-12-07 22:26 ` [PATCH 4/5] platform/x86: wmi: Remove chardev interface Armin Wolf
2023-12-08 13:43 ` Ilpo Järvinen [this message]
2023-12-07 22:26 ` [PATCH 5/5] platform/x86: wmi: Add driver development guide Armin Wolf
2023-12-08 12:25 ` Ilpo Järvinen
2023-12-08 18:10 ` Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92e2d5f-77cd-30b0-64e5-28f767baf776@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.