Re: [PATCH] drm/amdgpu: Fix a NULL pointer of fence

["Christian König" <ckoenig.leichtzumerken@gmail.com>]

Am 07.07.22 um 11:50 schrieb xinhui pan:
> Fence is accessed by dma_resv_add_fence() now.
> Use amdgpu_amdkfd_remove_eviction_fence instead.
>
> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 0036c9e405af..1e25c400ce4f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1558,10 +1558,10 @@ void amdgpu_amdkfd_gpuvm_destroy_cb(struct amdgpu_device *adev,
>   
>   	if (!process_info)
>   		return;
> -
>   	/* Release eviction fence from PD */
>   	amdgpu_bo_reserve(pd, false);
> -	amdgpu_bo_fence(pd, NULL, false);
> +	amdgpu_amdkfd_remove_eviction_fence(pd,
> +					process_info->eviction_fence);

Good catch as well, but Felix needs to take a look at this.

Regards,
Christian.

>   	amdgpu_bo_unreserve(pd);
>   
>   	/* Update process info */