From: pvorel <pvorel@suse.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/1] lib: Retry safe_clone() on ENOSPC|EUSERS
Date: Wed, 30 Mar 2022 14:46:49 +0200 [thread overview]
Message-ID: <92fea33b63410dfa96d0c654950eb11f@suse.de> (raw)
In-Reply-To: <YkRNGt435X50u8Z9@yuki>
Hi Cyril, all,
>>
>> NOTE: 0.1s seems to be safe, although using TST_RETRY_FUNC() with 1s
>> (the default) would be of course OK.
>
> I would just put in the default 1s to make things extra safe even on
> slow hardware.
>
+1
...
>> +/* too fast creating namespaces => retrying */
>> +#define TST_CHECK_ENOSPC(x) ((x) >= 0 || !(errno == ENOSPC || errno
>> == EUSERS))
>
> Reading the manual page I do not think that we have to retry on EUSERS,
> that used to be the return value where we reached limit of nested
> namespaces and that is not going go away if we retry.
>
> Otherwise the rest looks good.
>
Fixed both and merged.
Kind regards,
Petrb
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-03-30 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 20:46 [LTP] [PATCH v2 1/1] lib: Retry safe_clone() on ENOSPC|EUSERS Petr Vorel
2022-03-30 12:29 ` Cyril Hrubis
2022-03-30 12:46 ` pvorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92fea33b63410dfa96d0c654950eb11f@suse.de \
--to=pvorel@suse.de \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.