From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE692C02192 for ; Fri, 7 Feb 2025 06:54:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tgIFn-00044u-TF; Fri, 07 Feb 2025 01:54:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgIFm-00044l-DK for grub-devel@gnu.org; Fri, 07 Feb 2025 01:54:18 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgIFk-00026n-85 for grub-devel@gnu.org; Fri, 07 Feb 2025 01:54:18 -0500 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5171vRgB027570; Fri, 7 Feb 2025 06:54:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=gf3Ynm Zpvc4/yAsFKSVwsK2ArPnAyKWoRmE1C72adi4=; b=FcpBtht++glDh/Y7Oz64oH 8SuLl8zFjcp9g5jTOk+iAf6PUD+Ko5dVx6rtlw9LCKEmkwhqx2aDVkjf676noiTo lb+JnNXD+6RCCAR7Q4v2YMb/dVWnaWxHmORv/e8VYR7EHb1IsU+bnRWpzl/jXSjm c1B546S688s4EdwVgZttiiVITA49FEvqMzys2Gsit0B30IZchi6215EGollYcEeZ O8/DgechEcVN+WMG0XbHagmNz3fH7rW2yBJO7uQXA5B2kaYyZYrs/kYZCCB5rCrE 9MfneD3dgZZq53Bi8xxa3h0PVPD+WXFb7KwK6Y1QvlM+1aP/jgGTsoXNAheGli5g == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44myc044nu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Feb 2025 06:54:12 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5174TJ9J005277; Fri, 7 Feb 2025 06:54:11 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 44j05ka2a3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Feb 2025 06:54:11 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5176s9T632637614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Feb 2025 06:54:10 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E10AB581FA; Fri, 7 Feb 2025 06:54:09 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1BECB581F9; Fri, 7 Feb 2025 06:54:09 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 7 Feb 2025 06:54:09 +0000 (GMT) MIME-Version: 1.0 Date: Fri, 07 Feb 2025 12:24:08 +0530 From: Avnish Chouhan To: Sudhakar Kuppusamy Cc: grub-devel@gnu.org, dja@axtens.net, jan.setjeeilers@oracle.com, julian.klode@canonical.com, mate.kukri@canonical.com, pjones@redhat.com, stefanb@linux.ibm.com, nayna@linux.ibm.com, ssrish@linux.ibm.com, daniel.kiper@oracle.com Subject: Re: [PATCH v1 19/21] appendedsig: Reads the default DB keys from ELF Note In-Reply-To: <20241218145647.1390837-20-sudhakar@linux.ibm.com> References: <20241218145647.1390837-1-sudhakar@linux.ibm.com> <20241218145647.1390837-20-sudhakar@linux.ibm.com> Message-ID: <9302990b3f3dbb1eb06f4c8346521964@linux.ibm.com> X-Sender: avnish@linux.ibm.com X-TM-AS-GCONF: 00 X-Proofpoint-GUID: X1WMhAWQoPVcOtXXlU6jXCCGmVHtGvNL X-Proofpoint-ORIG-GUID: X1WMhAWQoPVcOtXXlU6jXCCGmVHtGvNL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-07_03,2025-02-07_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 mlxlogscore=999 mlxscore=0 impostorscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502070046 Received-SPF: pass client-ip=148.163.156.1; envelope-from=avnish@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org Sender: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org ClJldmlld2VkLWJ5OsKgQXZuaXNowqBDaG91aGFuwqA8YXZuaXNoQGxpbnV4LmlibS5jb20+CgpP biAyMDI0LTEyLTE4IDIwOjI2LCBTdWRoYWthciBLdXBwdXNhbXkgd3JvdGU6Cj4gaWYgc2VjdXJl IGJvb3QgZW5hYmxlZCB3aXRoIFBLUyBhbmQgc2V0IHVzZV9zdGF0aWNfa2V5cyBmbGFnLCBpdAo+ IHJlYWRzIHRoZSBEQiBkZWZhdWx0IGtleXMgZnJvbSBFTEYgTm90ZSBhbmQgc3RvcmUgaXQgaW4g dHJ1c3RlZCBsaXN0IAo+IGJ1ZmZlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTdWRoYWthciBLdXBw dXNhbXkgPHN1ZGhha2FyQGxpbnV4LmlibS5jb20+Cj4gLS0tCj4gIGdydWItY29yZS9jb21tYW5k cy9hcHBlbmRlZHNpZy9hcHBlbmRlZHNpZy5jIHwgNTggKysrKysrKysrKysrKystLS0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9ncnViLWNvcmUvY29tbWFuZHMvYXBwZW5kZWRzaWcvYXBwZW5kZWRzaWcuYwo+ IGIvZ3J1Yi1jb3JlL2NvbW1hbmRzL2FwcGVuZGVkc2lnL2FwcGVuZGVkc2lnLmMKPiBpbmRleCA4 YjA4NDA4N2UuLjlhOWY0ZWYxYyAxMDA2NDQKPiAtLS0gYS9ncnViLWNvcmUvY29tbWFuZHMvYXBw ZW5kZWRzaWcvYXBwZW5kZWRzaWcuYwo+ICsrKyBiL2dydWItY29yZS9jb21tYW5kcy9hcHBlbmRl ZHNpZy9hcHBlbmRlZHNpZy5jCj4gQEAgLTEwODIsNyArMTA4Miw3IEBAIGdydWJfY3JlYXRlX2Rp c3RydXN0ZWRfbGlzdCAodm9pZCkKPiAgICogcGFyc2VzIGl0LCBhbmQgYWRkcyBpdCB0byB0aGUg dHJ1c3RlZCBsaXN0Lgo+ICAgKi8KPiAgc3RhdGljIGdydWJfZXJyX3QKPiAtZ3J1Yl9idWlsZF9z dGF0aWNfdHJ1c3RlZF9saXN0IChjb25zdCBzdHJ1Y3QgZ3J1Yl9tb2R1bGVfaGVhZGVyIAo+ICpo ZWFkZXIpCj4gK2dydWJfYnVpbGRfc3RhdGljX3RydXN0ZWRfbGlzdCAoY29uc3Qgc3RydWN0IGdy dWJfbW9kdWxlX2hlYWRlcgo+ICpoZWFkZXIsIGNvbnN0IGdydWJfYm9vbF90IG1vZGUpCj4gIHsK PiAgICBncnViX2Vycl90IGVyciA9IEdSVUJfRVJSX05PTkU7Cj4gICAgc3RydWN0IGdydWJfZmls ZSBwc2V1ZG9fZmlsZTsKPiBAQCAtMTEwMSw3ICsxMTAxLDE0IEBAIGdydWJfYnVpbGRfc3RhdGlj X3RydXN0ZWRfbGlzdCAoY29uc3Qgc3RydWN0Cj4gZ3J1Yl9tb2R1bGVfaGVhZGVyICpoZWFkZXIp Cj4gICAgaWYgKGVyciAhPSBHUlVCX0VSUl9OT05FKQo+ICAgICAgcmV0dXJuIGVycjsKPiAKPiAt ICBlcnIgPSBncnViX2FkZF9jZXJ0aWZpY2F0ZSAoY2VydF9kYXRhLCBjZXJ0X2RhdGFfc2l6ZSwg JmdydWJfZGIsIDEpOwo+ICsgIGlmIChtb2RlKQo+ICsgICAgewo+ICsgICAgICBlcnIgPSBncnVi X2lzX2Rpc3RydXN0ZWRfY2VydF9oYXNoIChjZXJ0X2RhdGEsIGNlcnRfZGF0YV9zaXplKTsKPiAr ICAgICAgaWYgKGVyciAhPSBHUlVCX0VSUl9OT05FKQo+ICsgICAgICAgIHJldHVybiBlcnI7Cj4g KyAgICB9Cj4gKwo+ICsgIGVyciA9IGdydWJfYWRkX2NlcnRpZmljYXRlIChjZXJ0X2RhdGEsIGNl cnRfZGF0YV9zaXplLCAmZ3J1Yl9kYiwgCj4gbW9kZSk7Cj4gICAgaWYgKGNlcnRfZGF0YSAhPSBO VUxMKQo+ICAgICAgZ3J1Yl9mcmVlIChjZXJ0X2RhdGEpOwo+IAo+IEBAIC0xMTU0LDYgKzExNjEs MjAgQEAgZ3J1Yl9yZWxlYXNlX2Rpc3RydXN0ZWRfbGlzdCAodm9pZCkKPiAgICBncnViX21lbXNl dCAoJmdydWJfZGJ4LCAweDAwLCBzaXplb2YgKGdydWJfZGJ4KSk7Cj4gIH0KPiAKPiArc3RhdGlj IGdydWJfZXJyX3QKPiArZ3J1Yl9sb2FkX3N0YXRpY19rZXlzIChjb25zdCBzdHJ1Y3QgZ3J1Yl9t b2R1bGVfaGVhZGVyICpoZWFkZXIsIGNvbnN0Cj4gZ3J1Yl9ib29sX3QgbW9kZSkKPiArewo+ICsg IGludCByYyA9IEdSVUJfRVJSX05PTkU7Cj4gKyAgRk9SX01PRFVMRVMgKGhlYWRlcikKPiArICAg IHsKPiArICAgICAgLyogTm90IGFuIEVMRiBtb2R1bGUsIHNraXAuICAqLwo+ICsgICAgICBpZiAo aGVhZGVyLT50eXBlICE9IE9CSl9UWVBFX1g1MDlfUFVCS0VZKQo+ICsgICAgICAgIGNvbnRpbnVl Owo+ICsgICAgICByYyA9IGdydWJfYnVpbGRfc3RhdGljX3RydXN0ZWRfbGlzdCAoaGVhZGVyLCBt b2RlKTsKPiArICAgIH0KPiArICByZXR1cm4gcmM7Cj4gK30KPiArCj4gIEdSVUJfTU9EX0lOSVQg KGFwcGVuZGVkc2lnKQo+ICB7Cj4gICAgaW50IHJjOwo+IEBAIC0xMTcyLDI2ICsxMTkzLDI5IEBA IEdSVUJfTU9EX0lOSVQgKGFwcGVuZGVkc2lnKQo+IAo+ICAgIGlmICghZ3J1Yl91c2VfcGxhdGZv cm1fa2V5c3RvcmUgJiYgY2hlY2tfc2lncyA9PSBjaGVja19zaWdzX2ZvcmNlZCkKPiAgICAgIHsK PiAtICAgICAgRk9SX01PRFVMRVMgKGhlYWRlcikKPiArICAgICAgcmMgPSBncnViX2xvYWRfc3Rh dGljX2tleXMgKGhlYWRlciwgMCk7Cj4gKyAgICAgIGlmIChyYyAhPSBHUlVCX0VSUl9OT05FKQo+ ICAgICAgICAgIHsKPiAtICAgICAgICAgIC8qIE5vdCBhbiBFTEYgbW9kdWxlLCBza2lwLiAgKi8K PiAtICAgICAgICAgIGlmIChoZWFkZXItPnR5cGUgIT0gT0JKX1RZUEVfWDUwOV9QVUJLRVkpCj4g LSAgICAgICAgICAgIGNvbnRpbnVlOwo+IC0KPiAtICAgICAgICAgIHJjID0gZ3J1Yl9idWlsZF9z dGF0aWNfdHJ1c3RlZF9saXN0IChoZWFkZXIpOwo+IC0gICAgICAgICAgaWYgKHJjICE9IEdSVUJf RVJSX05PTkUpCj4gLSAgICAgICAgICAgIHsKPiAtICAgICAgICAgICAgICBncnViX3JlbGVhc2Vf dHJ1c3RlZF9saXN0ICgpOwo+IC0gICAgICAgICAgICAgIGdydWJfZXJyb3IgKHJjLCAic3RhdGlj IHRydXN0ZWQgbGlzdCBjcmVhdGlvbiBmYWlsZWQiKTsKPiAtICAgICAgICAgICAgfQo+IC0gICAg ICAgICAgZWxzZQo+IC0gICAgICAgICAgICBncnViX3ByaW50ZiAoImFwcGVuZGVkc2lnOiB0aGUg dHJ1c3RlZCBsaXN0IG5vdyBoYXMgJSIKPiBQUkl1R1JVQl9TSVpFICIgc3RhdGljIGtleXNcbiIs Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICBncnViX2RiLmtleV9lbnRyaWVzKTsKPiArICAg ICAgICAgIGdydWJfcmVsZWFzZV90cnVzdGVkX2xpc3QgKCk7Cj4gKyAgICAgICAgICBncnViX2Vy cm9yIChyYywgInN0YXRpYyB0cnVzdGVkIGxpc3QgY3JlYXRpb24gZmFpbGVkIik7Cj4gICAgICAg ICAgfQo+ICsgICAgICBlbHNlCj4gKyAgICAgICAgZ3J1Yl9wcmludGYgKCJhcHBlbmRlZHNpZzog dGhlIHRydXN0ZWQgbGlzdCBub3cgaGFzICUiCj4gUFJJdUdSVUJfU0laRSAiIHN0YXRpYyBrZXlz XG4iLAo+ICsgICAgICAgICAgICAgICAgICAgICBncnViX2RiLmtleV9lbnRyaWVzKTsKPiArCj4g ICAgICB9Cj4gICAgZWxzZSBpZiAoZ3J1Yl91c2VfcGxhdGZvcm1fa2V5c3RvcmUgJiYgY2hlY2tf c2lncyA9PSAKPiBjaGVja19zaWdzX2ZvcmNlZCkKPiAgICAgIHsKPiAtICAgICAgcmMgPSBncnVi X2NyZWF0ZV90cnVzdGVkX2xpc3QgKCk7Cj4gKwo+ICsgICAgICBpZiAoZ3J1Yl9wbGF0Zm9ybV9r ZXlzdG9yZS51c2Vfc3RhdGljX2tleXMgPT0gMSkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICBn cnViX3ByaW50ZiAoIldhcm5pbmc6IGRiIHZhcmlhYmxlIGlzIG5vdCBhdmFpbGFibGUgYXQgUEtT Cj4gYW5kIHVzaW5nIGEgc3RhdGljIGtleXMgIgo+ICsgICAgICAgICAgICAgICAgICAgICAgICJh cyBhIGRlZmF1bHQga2V5IGluIHRydXN0ZWQgbGlzdFxuIik7Cj4gKyAgICAgICAgICByYyA9IGdy dWJfbG9hZF9zdGF0aWNfa2V5cyAoaGVhZGVyLCAxKTsKPiArICAgICAgICB9Cj4gKyAgICAgIGVs c2UKPiArICAgICAgICByYyA9IGdydWJfY3JlYXRlX3RydXN0ZWRfbGlzdCAoKTsKPiArCj4gICAg ICAgIGlmIChyYyAhPSBHUlVCX0VSUl9OT05FKQo+ICAgICAgICAgIHsKPiAgICAgICAgICAgIGdy dWJfcmVsZWFzZV90cnVzdGVkX2xpc3QgKCk7CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpHcnViLWRldmVsIG1haWxpbmcgbGlzdApHcnViLWRldmVsQGdu dS5vcmcKaHR0cHM6Ly9saXN0cy5nbnUub3JnL21haWxtYW4vbGlzdGluZm8vZ3J1Yi1kZXZlbAo=