All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Haichen Feng <2806891994@qq.com>
Cc: Hans de Goede <hansg@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
Date: Thu, 30 Apr 2026 15:45:13 +0300 (EEST)	[thread overview]
Message-ID: <930ba4a0-91be-03b3-4f71-4f43ea334843@linux.intel.com> (raw)
In-Reply-To: <tencent_C70DE4F14F7552DAFC00633507DB5B48F708@qq.com>

On Sat, 25 Apr 2026, Haichen Feng wrote:

> The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
> S boards, but requires quirks for correctly switching thermal
> profile.
> 
> Add the DMI board name to victus_s_thermal_profile_boards[] table and
> map it to omen_v1_thermal_params.
> 
> Testing on board 8BC2 confirmed that platform profile is registered
> successfully and fan RPMs are readable and controllable.
> 
> Signed-off-by: Haichen Feng <2806891994@qq.com>
> ---
>  drivers/platform/x86/hp/hp-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index d1cc6e7d1..075d39417 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -213,6 +213,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCD") },
>  		.driver_data = (void *)&omen_v1_thermal_params,
>  	},
> +	{
> +		.matches = {DMI_MATCH(DMI_BOARD_NAME, "8BC2")},

Please place it into the correct place (8BC2 < 8BC[AD]) in the array.

> +		.driver_data = (void *)&omen_v1_thermal_params,
> +	},
>  	{
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BD4") },
>  		.driver_data = (void *)&victus_s_thermal_params,
> 

-- 
 i.


  reply	other threads:[~2026-04-30 12:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-25 11:07 [PATCH] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2) Haichen Feng
2026-04-30 12:45 ` Ilpo Järvinen [this message]
2026-04-30 14:07   ` [PATCH v2] " Haichen Feng
2026-04-30 16:37   ` [PATCH v3] " Haichen Feng
2026-05-05 10:06     ` Ilpo Järvinen
2026-05-05 11:44       ` [PATCH v4] " Haichen Feng
2026-05-07 12:57         ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=930ba4a0-91be-03b3-4f71-4f43ea334843@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=2806891994@qq.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.