Re: [PATCH v4 08/11] drm/amd/display: make blnd bypass mode clearer

[Harry Wentland <harry.wentland@amd.com>]

On 2026-08-11 12:45, Melissa Wen wrote:
> If userspace set blnd colorop to bypass, AMD driver just skips blnd
> transfer function configuration. Currently, this is not an issue since
> dc plane state is a reset/default state, but it's not fully correct and
> doesn't mirror shaper tf helper. Make bypass mode setup clear by
> initially set tf->type as BYPASS and let the helper change its type
> according to userspace requests.
> 
> Acked-by: Harry Wentland <harry.wentland@amd.com>
> Signed-off-by: Melissa Wen <mwen@igalia.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> index ca9e43e81edf..ad67106c6435 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> @@ -1837,6 +1837,7 @@ __set_dm_plane_colorop_blend(struct drm_plane_state *plane_state,
>   	uint32_t blend_size = 0;
>   	int i = 0;
>   
> +	tf->type = TF_TYPE_BYPASS;
>   	dc_plane_state->cm.flags.bits.blend_enable = 0;
>   
>   	/* 1D Curve - BLND TF: find state */