Re: [PATCH 02/12] iio: adc: use named initializers for acpi_device_id

[Matti Vaittinen <mazziesaccount@gmail.com>]

On 05/10/2026 17:01, Pawel Zalewski wrote:
> Use a designated initializer for the acpi_device_id fields which makes the
> code more readable and consistent with how lists are initialized in the
> rest of the kernel code base. Also drop explicitly setting fields to 0
> where it is redundant.
> 
> Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>

> ---
>   drivers/iio/adc/ad7298.c        | 2 +-
>   drivers/iio/adc/pac1921.c       | 2 +-
>   drivers/iio/adc/pac1934.c       | 2 +-
>   drivers/iio/adc/ti-adc081c.c    | 2 +-
>   drivers/iio/adc/ti-adc108s102.c | 2 +-
>   drivers/iio/adc/ti-adc128s052.c | 2 +-
>   6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7298.c b/drivers/iio/adc/ad7298.c
> index c669022b5dec..66b8ca4e3132 100644
> --- a/drivers/iio/adc/ad7298.c
> +++ b/drivers/iio/adc/ad7298.c
> @@ -347,7 +347,7 @@ static int ad7298_probe(struct spi_device *spi)
>   }
>   
>   static const struct acpi_device_id ad7298_acpi_ids[] = {
> -	{ "INT3494", 0 },
> +	{ .id = "INT3494" },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(acpi, ad7298_acpi_ids);
> diff --git a/drivers/iio/adc/pac1921.c b/drivers/iio/adc/pac1921.c
> index f0bab94462f4..730416ba147b 100644
> --- a/drivers/iio/adc/pac1921.c
> +++ b/drivers/iio/adc/pac1921.c
> @@ -1322,7 +1322,7 @@ static const struct of_device_id pac1921_of_match[] = {
>   MODULE_DEVICE_TABLE(of, pac1921_of_match);
>   
>   static const struct acpi_device_id pac1921_acpi_match[] = {
> -	{ "MCHP1921" },
> +	{ .id = "MCHP1921" },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(acpi, pac1921_acpi_match);
> diff --git a/drivers/iio/adc/pac1934.c b/drivers/iio/adc/pac1934.c
> index de59dc27c440..7e18a8728bd8 100644
> --- a/drivers/iio/adc/pac1934.c
> +++ b/drivers/iio/adc/pac1934.c
> @@ -1612,7 +1612,7 @@ MODULE_DEVICE_TABLE(of, pac1934_of_match);
>    * https://ww1.microchip.com/downloads/aemDocuments/documents/OTH/ApplicationNotes/ApplicationNotes/PAC1934-Integration-Notes-for-Microsoft-Windows-10-and-Windows-11-Driver-Support-DS00002534.pdf
>    */
>   static const struct acpi_device_id pac1934_acpi_match[] = {
> -	{ "MCHP1930", .driver_data = (kernel_ulong_t)&pac1934_chip_config[PAC1934] },
> +	{ .id = "MCHP1930", .driver_data = (kernel_ulong_t)&pac1934_chip_config[PAC1934] },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(acpi, pac1934_acpi_match);
> diff --git a/drivers/iio/adc/ti-adc081c.c b/drivers/iio/adc/ti-adc081c.c
> index 2df8f1c21c2a..d222c5637a71 100644
> --- a/drivers/iio/adc/ti-adc081c.c
> +++ b/drivers/iio/adc/ti-adc081c.c
> @@ -205,7 +205,7 @@ MODULE_DEVICE_TABLE(i2c, adc081c_id);
>   
>   static const struct acpi_device_id adc081c_acpi_match[] = {
>   	/* Used on some AAEON boards */
> -	{ "ADC081C", (kernel_ulong_t)&adc081c_model },
> +	{ .id = "ADC081C", .driver_data = (kernel_ulong_t)&adc081c_model },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(acpi, adc081c_acpi_match);
> diff --git a/drivers/iio/adc/ti-adc108s102.c b/drivers/iio/adc/ti-adc108s102.c
> index 10959e835cb8..316d2eb16991 100644
> --- a/drivers/iio/adc/ti-adc108s102.c
> +++ b/drivers/iio/adc/ti-adc108s102.c
> @@ -270,7 +270,7 @@ static const struct of_device_id adc108s102_of_match[] = {
>   MODULE_DEVICE_TABLE(of, adc108s102_of_match);
>   
>   static const struct acpi_device_id adc108s102_acpi_ids[] = {
> -	{ "INT3495", 0 },
> +	{ .id = "INT3495" },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(acpi, adc108s102_acpi_ids);
> diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
> index 1899813c1aee..381e2121a2b7 100644
> --- a/drivers/iio/adc/ti-adc128s052.c
> +++ b/drivers/iio/adc/ti-adc128s052.c
> @@ -264,7 +264,7 @@ static const struct spi_device_id adc128_id[] = {
>   MODULE_DEVICE_TABLE(spi, adc128_id);
>   
>   static const struct acpi_device_id adc128_acpi_match[] = {
> -	{ "AANT1280", (kernel_ulong_t)&adc124s_config },
> +	{ .id = "AANT1280", .driver_data = (kernel_ulong_t)&adc124s_config },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(acpi, adc128_acpi_match);
> 


-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~