From: Heyi Guo <guoheyi@linux.alibaba.com>
To: openbmc <openbmc@lists.ozlabs.org>
Cc: George Liu <liuxiwei@inspur.com>,
Adriana Kobylak <anoo@us.ibm.com>,
Gunnar Mills <gmills@linux.vnet.ibm.com>,
Jayanth Othayoth <ojayanth@in.ibm.com>
Subject: [phosphor-software-manager] potential out of order for reboot guard enable and disable procedure
Date: Sat, 5 Mar 2022 22:03:35 +0800 [thread overview]
Message-ID: <9321559d-ece8-e8b4-06eb-e0fa5bfb90a2@linux.alibaba.com> (raw)
Hi all,
We found reboot might be permanently disabled after running BMC image
update with curl command. The journal log showed the steps of reboot
guard enable and disable were out of order:
Mar 05 20:32:58 ali2600 systemd[1]: Starting Enable a guard that blocks
BMC reboot...
Mar 05 20:32:58 ali2600 phosphor-image-updater[370]: BMC activation has
ended - BMC reboots are re-enabled.
Mar 05 20:32:58 ali2600 systemd[1]: Starting Removes the guard that
blocks BMC reboot...
Mar 05 20:32:58 ali2600 phosphor-image-updater[370]: BMC image ready,
need reboot to get activated.
Mar 05 20:32:58 ali2600 systemd[1]: reboot-guard-disable.service: Succeeded.
Mar 05 20:32:58 ali2600 systemd[1]: Finished Removes the guard that
blocks BMC reboot.
Mar 05 20:32:59 ali2600 systemd[1]: reboot-guard-enable.service: Succeeded.
Mar 05 20:32:59 ali2600 systemd[1]: Finished Enable a guard that blocks
BMC reboot.
It seems systemd would not guarantee the completion order for StartUnit
operations, while I think this is critical for firmware upgrade
procedure. Shall we switch to normal C++ implementation to create and
remove reboot guaud configuration files, to guarantee the order of these
sequential steps?
Thanks,
Heyi
reply other threads:[~2022-03-05 14:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9321559d-ece8-e8b4-06eb-e0fa5bfb90a2@linux.alibaba.com \
--to=guoheyi@linux.alibaba.com \
--cc=anoo@us.ibm.com \
--cc=gmills@linux.vnet.ibm.com \
--cc=liuxiwei@inspur.com \
--cc=ojayanth@in.ibm.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.