From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org,
Sumit Semwal <sumit.semwal@linaro.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/10] udmabuf: add MEMFD_CREATE dependency
Date: Tue, 11 Sep 2018 12:40:10 +0300 [thread overview]
Message-ID: <9324055.sTKbuWCmpk@avalon> (raw)
In-Reply-To: <20180911065921.23818-7-kraxel@redhat.com>
Hi Gerd,
Thank you for the patch.
On Tuesday, 11 September 2018 09:59:17 EEST Gerd Hoffmann wrote:
> udmabuf builds without it, but if userspace can not create memfd
> handles in the first place it is rather pointless to include it.
Except perhaps for compile test coverage ? How about
depends on MEMFD_CREATE || COMPILE_TEST
?
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> drivers/dma-buf/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> index 338129eb12..fc3fe3f04e 100644
> --- a/drivers/dma-buf/Kconfig
> +++ b/drivers/dma-buf/Kconfig
> @@ -34,6 +34,7 @@ config UDMABUF
> bool "userspace dmabuf misc driver"
> default n
> depends on DMA_SHARED_BUFFER
> + depends on MEMFD_CREATE
> help
> A driver to let userspace turn memfd regions into dma-bufs.
> Qemu can use this to create host dmabufs for guest framebuffers.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-09-11 9:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 6:59 [PATCH 00/10] udmabuf: misc fixes Gerd Hoffmann
2018-09-11 6:59 ` [PATCH 01/10] udmabuf: sort headers, drop uapi/ path prefix Gerd Hoffmann
2018-09-11 6:59 ` Gerd Hoffmann
2018-09-11 9:35 ` Laurent Pinchart
2018-09-11 9:35 ` Laurent Pinchart
2018-09-11 6:59 ` [PATCH 02/10] udmabuf: improve map_udmabuf error handling Gerd Hoffmann
2018-09-11 6:59 ` Gerd Hoffmann
2018-09-11 9:37 ` Laurent Pinchart
2018-09-11 9:37 ` Laurent Pinchart
2018-09-11 6:59 ` [PATCH 03/10] udmabuf: use pgoff_t for pagecount Gerd Hoffmann
2018-09-11 6:59 ` Gerd Hoffmann
2018-09-11 7:38 ` Daniel Vetter
2018-09-11 6:59 ` [PATCH 04/10] udmabuf: constify udmabuf_ops Gerd Hoffmann
2018-09-11 6:59 ` Gerd Hoffmann
2018-09-11 9:38 ` Laurent Pinchart
2018-09-11 6:59 ` [PATCH 05/10] udmabuf: constify udmabuf_create args Gerd Hoffmann
2018-09-11 6:59 ` Gerd Hoffmann
2018-09-11 9:39 ` Laurent Pinchart
2018-09-11 6:59 ` [PATCH 06/10] udmabuf: add MEMFD_CREATE dependency Gerd Hoffmann
2018-09-11 6:59 ` Gerd Hoffmann
2018-09-11 9:40 ` Laurent Pinchart [this message]
2018-09-11 6:59 ` [PATCH 07/10] udmabuf: rework limits Gerd Hoffmann
2018-09-11 6:59 ` Gerd Hoffmann
2018-09-11 9:41 ` Laurent Pinchart
2018-09-11 9:41 ` Laurent Pinchart
2018-09-11 6:59 ` [PATCH 08/10] udmabuf: improve udmabuf_create error handling Gerd Hoffmann
2018-09-11 6:59 ` Gerd Hoffmann
2018-09-11 9:42 ` Laurent Pinchart
2018-09-11 6:59 ` [PATCH 09/10] udmabuf: use EBADFD in case we didn't got a memfd Gerd Hoffmann
2018-09-11 6:59 ` Gerd Hoffmann
2018-09-11 6:59 ` [PATCH 10/10] udmabuf: use ENOTTY for invalid ioctls Gerd Hoffmann
2018-09-11 6:59 ` Gerd Hoffmann
2018-09-11 9:43 ` Laurent Pinchart
2018-09-11 9:43 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9324055.sTKbuWCmpk@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.