From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Andi Shyti <andi.shyti@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Bartosz Golaszewski <brgl@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Vignesh R <vigneshr@ti.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linus Walleij <linusw@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] i2c: Convert to subsys_platform_driver()
Date: Wed, 4 Nov 2026 18:38:40 +0100 [thread overview]
Message-ID: <93534aaf-00f3-45f4-982e-7fd44ab3799c@kernel.org> (raw)
In-Reply-To: <20261104113316.1634141-1-peng.fan@oss.nxp.com>
On 04/11/2026 12:33, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Replace the open-coded subsys_initcall()/module_exit() platform driver
> registration with subsys_platform_driver().
>
> No functional change.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/i2c/busses/i2c-at91-core.c | 13 +------------
> drivers/i2c/busses/i2c-davinci.c | 14 +-------------
> drivers/i2c/busses/i2c-designware-platdrv.c | 13 +------------
> drivers/i2c/busses/i2c-imx.c | 13 +------------
> drivers/i2c/busses/i2c-mxs.c | 13 +------------
> drivers/i2c/busses/i2c-omap.c | 15 +--------------
> drivers/i2c/busses/i2c-pnx.c | 13 +------------
> drivers/i2c/busses/i2c-pxa.c | 13 +------------
> drivers/i2c/busses/i2c-s3c2410.c | 13 +------------
> drivers/i2c/busses/i2c-sh_mobile.c | 13 +------------
> drivers/i2c/busses/i2c-versatile.c | 13 +------------
> 11 files changed, 11 insertions(+), 135 deletions(-)
>
> -subsys_initcall(i2c_adap_pxa_init);
> -module_exit(i2c_adap_pxa_exit);
> +subsys_platform_driver(i2c_pxa_driver);
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 15e14a6fe6dc..dd1f6f854a32 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1188,18 +1188,7 @@ static struct platform_driver s3c24xx_i2c_driver = {
> .of_match_table = of_match_ptr(s3c24xx_i2c_match),
> },
> };
> -
> -static int __init i2c_adap_s3c_init(void)
> -{
> - return platform_driver_register(&s3c24xx_i2c_driver);
> -}
> -subsys_initcall(i2c_adap_s3c_init);
> -
> -static void __exit i2c_adap_s3c_exit(void)
> -{
> - platform_driver_unregister(&s3c24xx_i2c_driver);
> -}
> -module_exit(i2c_adap_s3c_exit);
> +subsys_platform_driver(s3c24xx_i2c_driver);
Apparently reviewing only a few lines out of 300 is still reviewing:
https://lore.kernel.org/all/9e39502a-dd17-4fa2-98a3-9019523cb5e8@kernel.org/
Therefore:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-04 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 11:33 [PATCH] i2c: Convert to subsys_platform_driver() Peng Fan (OSS)
2026-11-04 11:45 ` Vladimir Zapolskiy
2026-11-04 11:54 ` Wolfram Sang
2026-11-04 14:18 ` Bartosz Golaszewski
2026-11-04 17:38 ` Krzysztof Kozlowski [this message]
2026-11-04 20:37 ` Andy Shevchenko
2026-11-05 8:16 ` Krzysztof Kozlowski
2026-11-05 8:17 ` Wolfram Sang
2026-11-05 8:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93534aaf-00f3-45f4-982e-7fd44ab3799c@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=aaro.koskinen@iki.fi \
--cc=alexandre.belloni@bootlin.com \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=andreas@kemnade.info \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=codrin.ciubotariu@microchip.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jmkrzyszt@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=nicolas.ferre@microchip.com \
--cc=o.rempel@pengutronix.de \
--cc=peng.fan@oss.nxp.com \
--cc=peter.griffin@linaro.org \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=rogerq@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=vz@mleia.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.