From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A38C433F5 for ; Wed, 13 Oct 2021 09:17:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B507860C4B for ; Wed, 13 Oct 2021 09:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239062AbhJMJTS (ORCPT ); Wed, 13 Oct 2021 05:19:18 -0400 Received: from mga07.intel.com ([134.134.136.100]:48932 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbhJMJTP (ORCPT ); Wed, 13 Oct 2021 05:19:15 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="290878653" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="290878653" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 02:17:13 -0700 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="480721077" Received: from abaydur-mobl1.ccr.corp.intel.com (HELO [10.249.230.131]) ([10.249.230.131]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 02:17:08 -0700 Subject: Re: [PATCH v3 0/8] perf session: Extend reader object to allow multiple readers From: "Bayduraev, Alexey V" To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , linux-kernel , Andi Kleen , Adrian Hunter , Alexander Antonov , Alexei Budankov , Riccardo Mancini References: Organization: Intel Corporation Message-ID: <9365d01b-20a7-2ad2-2a50-b3661a47da9f@linux.intel.com> Date: Wed, 13 Oct 2021 12:17:05 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.10.2021 12:06, Alexey Bayduraev wrote:> Changes in v4:> - set/unset active_decomp within reader__process_events Sorry, The subject should of course be [PATCH v4 0/8] ... Regards, Alexey > > Changes in v3: > - removed struct reader_state in [PATCH v3 1/8] > - fixed repeating code in [PATCH v3 2/8] > - split [PATCH v2 4/5] to [PATCH v3 4/8], [PATCH v3 5/8] > - split [PATCH v2 5/5] to [PATCH v3 6/8] - [PATCH v3 8/8] > > Changes in v2: > - introduced struct decomp_data suggested by Jiri Olsa > - removed unnecessary [PATCH v1 1/6] > - removed unnecessary extra line in [PATCH v2 4/5] > - removed unnecessary reader_state.eof flag in [PATCH v2 5/5] > > Patchset moves state info and decompressor object into reader object > that made possible to split reader__process_events function into three > logical parts: init, map/unmap and single event reader which are used > in events reader loop. This approach allows reading multiple trace > files at the same time. > > The design and implementation are based on the prototype [1], [2]. > The patchset was separated from [3]. > > Tested: > > tools/perf/perf record -o prof.data -- matrix.gcc.g.O3 > tools/perf/perf record -o prof.data -z -- matrix.gcc.g.O3 > tools/perf/perf report -i prof.data > tools/perf/perf report -i prof.data --call-graph=callee > tools/perf/perf report -i prof.data --stdio --header > tools/perf/perf report -i prof.data -D --header > > [1] git clone https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git -b perf/record_threads > [2] https://lore.kernel.org/lkml/20180913125450.21342-1-jolsa@kernel.org/ > [3] https://lore.kernel.org/lkml/cover.1629186429.git.alexey.v.bayduraev@linux.intel.com/ > > Alexey Bayduraev (8): > perf session: Move all state items to reader object > perf session: Introduce decompressor in reader object > perf session: Move init/release code to separate functions > perf session: Move map code to separate function > perf session: Move unmap code to reader__mmap > perf session: Move event read code to separate function > perf session: Introduce reader return codes > perf session: Introduce reader EOF function > > tools/perf/util/session.c | 193 ++++++++++++++++++++++++++------------ > tools/perf/util/session.h | 10 +- > 2 files changed, 141 insertions(+), 62 deletions(-) >