Re: [PATCH] hob/settings: implement a new tab in settings dialog to show SSTATE_MIRRORS

[Paul Eggleton <paul.eggleton@linux.intel.com>]

Hi Cristiana,

On Tuesday 25 September 2012 13:30:20 Cristiana Voicu wrote:
> Add a new tab to show correctly SSTATE_MIRRORS variable. Now you can add new
> mirrors or delete mirror. "info" image was also changed( it is smaller, so
> it can be next to labels).
> From "Build environment" tab, SSTATE_DIR and SSTATE_MIRRORS vars were
> removed.
> 
> [YOCTO #2893]
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>

I just tested this; it works for the basic case, however there are a couple of 
issues with "Custom":

 1) If I select "Custom", set both "Match" and "Replace with", save and then 
re-open the dialog, I see that the mirror entry shows as "Standard" again. I 
think the code should be checking to see if the entry fits into "Standard" form 
and if not then showing it as "Custom".

 2) If I select "Custom" with a path already set, I feel it should adjust the 
path to be the appropriate full version that will still work (i.e. with \1 or 
PATH on the end). That does mean it needs to be able to go back the other way 
and probably show a warning dialog if it can't reverse it cleanly. However 
this fix can wait until 1.4 if there isn't enough time IMO.

There are a couple of other minor visual issues but at this late stage I think 
we can address those in 1.4.

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre