From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 6/7] drm/i915/gen11: Program the Y and UV plane for planar mode correctly. Date: Sat, 22 Sep 2018 11:37:09 +0200 Message-ID: <936dd554-c8ed-4ab9-52fd-2acc510593b7@linux.intel.com> References: <20180921173945.6276-1-maarten.lankhorst@linux.intel.com> <20180921173945.6276-7-maarten.lankhorst@linux.intel.com> <20180921190137.GK5565@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 501606E08E for ; Sat, 22 Sep 2018 09:37:53 +0000 (UTC) In-Reply-To: <20180921190137.GK5565@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjEtMDktMTggb20gMjE6MDEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gRnJpLCBT ZXAgMjEsIDIwMTggYXQgMDc6Mzk6NDRQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IFRoZSBVViBwbGFuZSBpcyB0aGUgbWFzdGVyIHBsYW5lIHRoYXQgZG9lcyBhbGwgY29sb3Ig Y29ycmVjdGlvbiBldGMuCj4+IEl0IG5lZWRzIHRvIGJlIHByb2dyYW1tZWQgd2l0aCB0aGUgZGlt ZW5zaW9ucyBmb3IgY29sb3IgcGxhbmUgMSAoVVYpLgo+Pgo+PiBUaGUgWSBwbGFuZSBqdXN0IGZl ZWRzIHRoZSBZIHBpeGVscyB0byBpdC4gUHJvZ3JhbSB0aGUgc2NhbGVyIGZyb20gdGhlCj4+IG1h c3RlciBvbmx5LCBhbmQgc2V0IFBMQU5FX0NUTF9ZVVY0MjBfWV9QTEFORSBvbiB0aGUgc2xhdmUg cGxhbmUuCj4+Cj4+IENoYW5nZXMgc2luY2UgdjE6Cj4+IC0gTWFrZSBhIGNvbW1vbiBza2xfcHJv Z3JhbV9wbGFuZSwgYW5kIHVzZSBpdCBmb3IgYm90aCBwbGFuZSB1cGRhdGVzLgo+Pgo+PiBTaWdu ZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50 ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAgIHwg IDEgKwo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgfCA1MCArKysrKysr KysrKysrKysrKysrKystLS0tLS0tLQo+PiAgMiBmaWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRpb25z KCspLCAxMyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4+IGluZGV4 IGI2MTRhMDZiNjZjNC4uYTMxMjlhNGMxNWNjIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3JlZy5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVn LmgKPj4gQEAgLTY1MTEsNiArNjUxMSw3IEBAIGVudW0gewo+PiAgI2RlZmluZSAgIFBMQU5FX0NU TF9LRVlfRU5BQkxFX0RFU1RJTkFUSU9OCSgyIDw8IDIxKQo+PiAgI2RlZmluZSAgIFBMQU5FX0NU TF9PUkRFUl9CR1JYCQkJKDAgPDwgMjApCj4+ICAjZGVmaW5lICAgUExBTkVfQ1RMX09SREVSX1JH QlgJCQkoMSA8PCAyMCkKPj4gKyNkZWZpbmUgICBQTEFORV9DVExfWVVWNDIwX1lfUExBTkUJCSgx IDw8IDE5KQo+PiAgI2RlZmluZSAgIFBMQU5FX0NUTF9ZVVZfVE9fUkdCX0NTQ19GT1JNQVRfQlQ3 MDkJKDEgPDwgMTgpCj4+ICAjZGVmaW5lICAgUExBTkVfQ1RMX1lVVjQyMl9PUkRFUl9NQVNLCQko MHgzIDw8IDE2KQo+PiAgI2RlZmluZSAgIFBMQU5FX0NUTF9ZVVY0MjJfWVVZVgkJCSgwIDw8IDE2 KQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+PiBpbmRleCBjNGUwNWIwYjYwYmYu LjcwOGQyZGZkNTlkNyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf c3ByaXRlLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPj4g QEAgLTMzOSwyMyArMzM5LDIzIEBAIHNrbF9wcm9ncmFtX3NjYWxlcihzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAJCSAgICAgICgoY3J0Y193ICsgMSkgPDwgMTYpfChjcnRj X2ggKyAxKSk7Cj4+ICB9Cj4+ICAKPj4gLXZvaWQKPj4gLXNrbF91cGRhdGVfcGxhbmUoc3RydWN0 IGludGVsX3BsYW5lICpwbGFuZSwKPj4gLQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlLAo+PiAtCQkgY29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFu ZV9zdGF0ZSkKPj4gK3N0YXRpYyB2b2lkCj4+ICtza2xfcHJvZ3JhbV9wbGFuZShzdHJ1Y3QgaW50 ZWxfcGxhbmUgKnBsYW5lLAo+PiArCQkgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpj cnRjX3N0YXRlLAo+PiArCQkgIGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVf c3RhdGUsCj4+ICsJCSAgaW50IGNvbG9yX3BsYW5lLCBib29sIHNsYXZlLCB1MzIgcGxhbmVfY3Rs KQo+PiAgewo+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUo cGxhbmUtPmJhc2UuZGV2KTsKPj4gIAllbnVtIHBsYW5lX2lkIHBsYW5lX2lkID0gcGxhbmUtPmlk Owo+PiAgCWVudW0gcGlwZSBwaXBlID0gcGxhbmUtPnBpcGU7Cj4+IC0JdTMyIHBsYW5lX2N0bCA9 IHBsYW5lX3N0YXRlLT5jdGw7Cj4+ICAJY29uc3Qgc3RydWN0IGRybV9pbnRlbF9zcHJpdGVfY29s b3JrZXkgKmtleSA9ICZwbGFuZV9zdGF0ZS0+Y2tleTsKPj4gLQl1MzIgc3VyZl9hZGRyID0gcGxh bmVfc3RhdGUtPmNvbG9yX3BsYW5lWzBdLm9mZnNldDsKPj4gLQl1MzIgc3RyaWRlID0gc2tsX3Bs YW5lX3N0cmlkZShwbGFuZV9zdGF0ZSwgMCk7Cj4+ICsJdTMyIHN1cmZfYWRkciA9IHBsYW5lX3N0 YXRlLT5jb2xvcl9wbGFuZVtjb2xvcl9wbGFuZV0ub2Zmc2V0Owo+PiArCXUzMiBzdHJpZGUgPSBz a2xfcGxhbmVfc3RyaWRlKHBsYW5lX3N0YXRlLCBjb2xvcl9wbGFuZSk7Cj4+ICAJdTMyIGF1eF9z dHJpZGUgPSBza2xfcGxhbmVfc3RyaWRlKHBsYW5lX3N0YXRlLCAxKTsKPj4gIAlpbnQgY3J0Y194 ID0gcGxhbmVfc3RhdGUtPmJhc2UuZHN0LngxOwo+PiAgCWludCBjcnRjX3kgPSBwbGFuZV9zdGF0 ZS0+YmFzZS5kc3QueTE7Cj4+IC0JdWludDMyX3QgeCA9IHBsYW5lX3N0YXRlLT5jb2xvcl9wbGFu ZVswXS54Owo+PiAtCXVpbnQzMl90IHkgPSBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0ueTsK Pj4gKwl1aW50MzJfdCB4ID0gcGxhbmVfc3RhdGUtPmNvbG9yX3BsYW5lW2NvbG9yX3BsYW5lXS54 Owo+PiArCXVpbnQzMl90IHkgPSBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbY29sb3JfcGxhbmVd Lnk7Cj4+ICAJdWludDMyX3Qgc3JjX3cgPSBkcm1fcmVjdF93aWR0aCgmcGxhbmVfc3RhdGUtPmJh c2Uuc3JjKSA+PiAxNjsKPj4gIAl1aW50MzJfdCBzcmNfaCA9IGRybV9yZWN0X2hlaWdodCgmcGxh bmVfc3RhdGUtPmJhc2Uuc3JjKSA+PiAxNjsKPj4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmUgKmxpbmtl ZCA9IHBsYW5lX3N0YXRlLT5saW5rZWRfcGxhbmU7Cj4+IEBAIC00MDksNyArNDA5LDkgQEAgc2ts X3VwZGF0ZV9wbGFuZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+PiAgCj4+ICAJLyogcHJv Z3JhbSBwbGFuZSBzY2FsZXIgKi8KPj4gIAlpZiAocGxhbmVfc3RhdGUtPnNjYWxlcl9pZCA+PSAw KSB7Cj4+IC0JCXNrbF9wcm9ncmFtX3NjYWxlcihkZXZfcHJpdiwgcGxhbmUsIGNydGNfc3RhdGUs IHBsYW5lX3N0YXRlKTsKPj4gKwkJaWYgKCFzbGF2ZSkKPj4gKwkJCXNrbF9wcm9ncmFtX3NjYWxl cihkZXZfcHJpdiwgcGxhbmUsCj4+ICsJCQkJCSAgIGNydGNfc3RhdGUsIHBsYW5lX3N0YXRlKTsK Pj4gIAo+PiAgCQlJOTE1X1dSSVRFX0ZXKFBMQU5FX1BPUyhwaXBlLCBwbGFuZV9pZCksIDApOwo+ PiAgCX0gZWxzZSB7Cj4+IEBAIC00MjQsNiArNDI2LDI1IEBAIHNrbF91cGRhdGVfcGxhbmUoc3Ry dWN0IGludGVsX3BsYW5lICpwbGFuZSwKPj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXZf cHJpdi0+dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsKPj4gIH0KPj4gIAo+PiArdm9pZAo+PiArc2ts X3VwZGF0ZV9wbGFuZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+PiArCQkgY29uc3Qgc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4+ICsJCSBjb25zdCBzdHJ1Y3QgaW50 ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+PiArewo+PiArCXNrbF9wcm9ncmFtX3BsYW5l KHBsYW5lLCBjcnRjX3N0YXRlLCBwbGFuZV9zdGF0ZSwKPj4gKwkJCSAgISFwbGFuZV9zdGF0ZS0+ bGlua2VkX3BsYW5lLCBmYWxzZSwKPiBUaGUgISFsaW5rZWQgdGhpbmcgaXMgYSBiaXQgbWFnaWN5 LiBJJ2QgcHJvYmFibHkgZm9yZ2V0IHdoYXQgaXQgbWVhbnMKPiBldmVyeSBzaW5nbGUgdGltZS4g U28gSU1PIGRlc2VydmVzIHRvIGJlIHdyaXR0ZW4gb3V0IGluIGEgYml0IG1vcmUKPiB2ZXJib3Nl IHdheSBhbmQvb3IgYWNjb21wYW5pZWQgYnkgYSBjb21tZW50LgpJJ2xsIGp1c3QgbWFrZSBhIHZh cmlhYmxlIGludCBjb2xvcl9wbGFuZSA9IHBsYW5lX3N0YXRlLT5saW5rZWRfcGxhbmUgPyAxIDog MD8KPj4gKwkJCSAgcGxhbmVfc3RhdGUtPmN0bCk7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyB2b2lk Cj4+ICtpY2xfdXBkYXRlX3NsYXZlKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4+ICsJCSBj b25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPj4gKwkJIGNvbnN0IHN0 cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4+ICt7Cj4+ICsJc2tsX3Byb2dy YW1fcGxhbmUocGxhbmUsIGNydGNfc3RhdGUsIHBsYW5lX3N0YXRlLCAwLCB0cnVlLAo+PiArCQkJ ICBwbGFuZV9zdGF0ZS0+Y3RsIHwgUExBTkVfQ1RMX1lVVjQyMF9ZX1BMQU5FKTsKPiBTbyB0aGF0 IG9uZSBiaXQgaXMgdGhlIG9ubHkgZGlmZmVyZW5jZSAoYXBhcnQgZnJvbSB0aGUgb2J2aW91cwo+ IFBMQU5FX1NVUkYvU1RSSURFL09GRlNFVD8gTm8gbmVlZCB0byBkZWFsIHdpdGggdGhlIGNocm9t YSB2cy4gbHVtYSAKPiBzaXplIGRpZmZlcmVuY2UgZXRjPwpZZXMsIGFuZCBhbGwgY29sb3IgbWFu YWdlbWVudCBpcyBpZ25vcmVkIG9uIHRoZSBZIHBsYW5lLiBTdGlsbCB0aGVyZSBkb2Vzbid0IHNl ZW0KdG8gYmUgYW55IGhhcm0gaW4gcHJvZ3JhbW1pbmcgaXQsIHNvICpzaHJ1ZyouCgpPbmx5IG5v dCBzbyBuaWNlIHRoaW5nIGlzIEkgZm91bmQgYSBDUkMgbWlzbWF0Y2ggd2hlbiB1c2luZyBjaHJv bWEgdXBzYW1wbGluZyArIHNjYWxpbmcKdnMganVzdCB1c2luZyB0aGUgY2hyb21hIHVwc2FtcGxp bmcuIFNlZW1zIHRvIGJlIGEgc21hbGwgfjEgb3IgMiBwaXhlbCBkaWZmZXJlbmNlIGluIDEwIGJp dC4KTmVlZCB0byBpbnZlc3RpZ2F0ZSBpdCBhIGJpdCBtb3JlLCBidXQgd2l0aCA4IGJpdHMgeW91 IGRvbid0IG5vdGljZSBpdC4gSnVzdCBhbiBhbm5veWluZyBjcmMgbWlzbWF0Y2guIDopCgp+TWFh cnRlbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK