From: David Hildenbrand <david@redhat.com>
To: Shakeel Butt <shakeel.butt@linux.dev>, Rik van Riel <riel@surriel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Chris Li <chrisl@kernel.org>, Ryan Roberts <ryan.roberts@arm.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-mm@kvack.org, kernel-team@meta.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remove unnecessary calls to lru_add_drain
Date: Sat, 21 Dec 2024 16:32:52 +0100 [thread overview]
Message-ID: <938c59d4-9ad4-4fdb-bd3d-0de139a940c3@redhat.com> (raw)
In-Reply-To: <xxfhcjaq2xxcl5adastz5omkytenq7izo2e5f4q7e3ns4z6lko@odigjjc7hqrg>
>
>> tlb_gather_mmu(&tlb, vms->vma->vm_mm);
>> update_hiwater_rss(vms->vma->vm_mm);
>> unmap_vmas(&tlb, mas_detach, vms->vma, vms->start, vms->end,
>
> I hope this much history is good enough to convince Andrew. With that
> please add:
>
> Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
>
Yes, seems reasonable to me. Does it matter on small (32bit?) machines?
Hard to judge, but being too careful here likely does not make sense
until we learn that there is a real problem.
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-12-21 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 20:32 [PATCH] mm: remove unnecessary calls to lru_add_drain Rik van Riel
2024-12-19 22:14 ` Andrew Morton
2024-12-20 2:00 ` Rik van Riel
2024-12-21 1:10 ` Shakeel Butt
2024-12-21 15:32 ` David Hildenbrand [this message]
2025-01-02 15:53 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=938c59d4-9ad4-4fdb-bd3d-0de139a940c3@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@surriel.com \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.