From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95312EB64D9 for ; Thu, 15 Jun 2023 07:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hUypKYJNSW83ctrllqc3q97NWKAqUdgxMX46BKLwm3M=; b=UX70ka7Izha2mK 8G0VFgSzkQTTfCb7u+4RSE2q+vtyTzaTc/02v5nF9gVm8DmYAC/maKnnZbB3Vk8RyOxSkOkBcRm0R Ta0IcFKTtuTmXQlJ7PlNjNqlIuiNeW0ATz/mByDB4/DS1fv8kVaQneAlTTJkAEpWHGjTwIgtA/J7I DFE9O0j5j6CjU6ovlRohJFhdPw+hPQjPT45OBxeDvheVxa/cgG9AZr6v+sInRXxMp6F9b3ZkD8693 OfYTzQJE7J/9RH6XTiFbXVPF/2NpJiQT4JH6Zc1e9RZ4I2Iat316nU7Zb+YZOeZbI6wWFps9uwz8S srvo3fHxLTtU+2ocyW7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9hXL-00E2Fm-2Z; Thu, 15 Jun 2023 07:36:55 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9hXI-00E2Dy-17; Thu, 15 Jun 2023 07:36:54 +0000 Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 22C456606F57; Thu, 15 Jun 2023 08:36:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686814610; bh=LKh3/K++ffNF/AmhFmt1beqCBIT5fIwS1jSCTqbyqDI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gr0uhLjDP3FkXRGO3mjV/ksfm1Gc9ctX7XQsIC90QRgClzsyzFOlitxUYypzdlbMi 76VM+QpyrDwoLufsZX11AlQZiska4ko9rQUvXF0hjLGNkqef+JQsQKLblJoQ7A8Y7A kk8AVCse0DLXFJN86tgONSQmw6bKWr434KeiwLCKQj5z8CZqrNRnECojIrtwHjPnNc 24aWVEBFzVa657fisKnYqjvv4B0fLMQ3jVT+TbxbJPA/2gXbMZTgMI+irPexG9r033 +Eq2+/apzCvXELNEat2utZ+V4PbOeRoQypEStqHHsxyW0+PtSHtB5Q/oVrk2ToALfZ PzrJ9i/AWyLWA== Message-ID: <938c740e-8196-ca0f-b53f-a0e33722e25c@collabora.com> Date: Thu, 15 Jun 2023 09:36:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2 01/15] dt-bindings: display: mediatek: ethdr: Add compatible for MT8188 Content-Language: en-US To: =?UTF-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= , "p.zabel@pengutronix.de" , "matthias.bgg@gmail.com" , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "devicetree@vger.kernel.org" , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" References: <20230614073125.17958-1-shawn.sung@mediatek.com> <20230614073125.17958-2-shawn.sung@mediatek.com> <1f044902-0726-34ed-3eea-7224e5750e22@collabora.com> <6c24ad522f42ce35bf387bae1b8a029f58bb0e01.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <6c24ad522f42ce35bf387bae1b8a029f58bb0e01.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230615_003652_647078_8FEC7167 X-CRM114-Status: GOOD ( 23.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMTUvMDYvMjMgMDc6NTEsIFNoYXduIFN1bmcgKOWui+WtneismSkgaGEgc2NyaXR0bzoKPiBI aSBBbmdlbG8sCj4gICAKPiBZZXMsIE1UODE4OCBFVEhEUiBpcyBmdWxseSBjb21wYXRpYmxlIHdp dGggTVQ4MTk1LCBzbyB3ZSBkaWRuJ3QgYWRkIGl0cwo+IGNvbXBhdGlibGUgbmFtZSB0byB0aGUg ZHJpdmVyIGJ1dCBqdXN0IGxpc3RlZCBpdCBpbiBkdC1iaW5kaW5ncy4KPiAgIAo+IE1heSBJIGRv dWJsZSBjaGVjayB3aXRoIHlvdSB0aGF0Cj4gSSBzZWUgdGhlcmUgaXMgYSBzaG9ydCBkZXNjcmlw dGlvbiByZWdhcmRpbmcgIml0ZW1zIiBvYmplY3Q6Cj4+ICMgaXRlbXMgaXMgYSBsaXN0IG9mIHBv c3NpYmxlIHZhbHVlcyBmb3IgdGhlIHByb3BlcnR5LiBUaGUgbnVtYmVyIG9mCj4+ICMgdmFsdWVz IGlzIGRldGVybWluZWQgYnkgdGhlIG51bWJlciBvZiBlbGVtZW50cyBpbiB0aGUgbGlzdC4KPj4g IyBPcmRlciBpbiBsaXN0cyBpcyBzaWduaWZpY2FudCwgb3JkZXIgaW4gZGljdHMgaXMgbm90Cj4g aW4gaHR0cHM6Ly9kb2NzLmtlcm5lbC5vcmcvZGV2aWNldHJlZS9iaW5kaW5ncy93cml0aW5nLXNj aGVtYS5odG1sCj4gICAKPiBTbyBkb2VzIHRoZSBjb21wYXRpYmxlIGhhcyB0byBiZToKPiAibWVk aWF0ZWssbXQ4MTg4LWRpc3AtZXRoZHIiLCAibWVkaWF0ZWssbXQ4MTk1LWRpc3AtCj4gZXRoZHIi IHJhdGhlciB0aGFuIGluIHJldmVyc2VkIG9yZGVyPwo+ICAgCj4gSG93ZXZlciwgSSBjb3VsZG4n dCBmaW5kIGFueSBkZXNjcmlwdGlvbiBtZW50aW9ucyB0aGUgb3JkZXIgaW4KPiBEb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvd3JpdGluZy1zY2hlbWEucnN0Cj4gTm90IHN1cmUgaWYg dGhlIG9yZGVyIGluICJpdGVtcyIgb2JqZWN0IGRvZXMgbm90IG1hdHRlciBhZnRlciB0aGVuLgo+ ICAgCgpObyB0aGUgb3JkZXIgZG9lc24ndCBtYXR0ZXIgaW4gdGhhdCBzZW5zZS4gSWYgeW91IGNo ZWNrIHRoZSBvdGhlciBiaW5kaW5ncywKeW91J2xsIHNlZSB0aGF0IHRoZSBydWxlIGlzIHRvIG9y ZGVyIGJ5IG5hbWUsIHdoaWNoIHlvdXIgY2hhbmdlIGFzIHdlbGwgZG9lcy4KCkl0J3MgZmluZS4K ClAuUy46IEluIGNhc2UgeW91IGRpZG4ndCBrbm93LCBgbWFrZSBkdF9iaW5kaW5nX2NoZWNrYCBh bmQgYG1ha2UgZHRic19jaGVja2AKICAgICAgIHdpbGwgdmFsaWRhdGUgeW91ciBiaW5kaW5ncyBh bmQgeW91ciBkZXZpY2V0cmVlcyBhZ2FpbnN0IHRoZSBiaW5kaW5ncy4KClJlZ2FyZHMsCkFuZ2Vs bwoKPiBUaGFua3MsCj4gSHNpYW8gQ2hpZW4gU3VuZwo+IAo+IAo+IE9uIFdlZCwgMjAyMy0wNi0x NCBhdCAxMzo0MSArMDIwMCwgQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gd3JvdGU6Cj4+ICAg CQo+PiBFeHRlcm5hbCBlbWFpbCA6IFBsZWFzZSBkbyBub3QgY2xpY2sgbGlua3Mgb3Igb3BlbiBh dHRhY2htZW50cyB1bnRpbAo+PiB5b3UgaGF2ZSB2ZXJpZmllZCB0aGUgc2VuZGVyIG9yIHRoZSBj b250ZW50Lgo+PiAgIElsIDE0LzA2LzIzIDA5OjMxLCBIc2lhbyBDaGllbiBTdW5nIGhhIHNjcml0 dG86Cj4+PiBBZGQgY29tcGF0aWJsZSBuYW1lIGZvciBNZWRpYVRlayBNVDgxODggRVRIRFIuCj4+ Pgo+Pj4gU2lnbmVkLW9mZi1ieTogSHNpYW8gQ2hpZW4gU3VuZyA8c2hhd24uc3VuZ0BtZWRpYXRl ay5jb20+Cj4+PiAtLS0KPj4+ICAgIC4uLi9iaW5kaW5ncy9kaXNwbGF5L21lZGlhdGVrL21lZGlh dGVrLGV0aGRyLnlhbWwgICAgICAgICAgIHwgNgo+PiArKysrKy0KPj4+ICAgIDEgZmlsZSBjaGFu Z2VkLCA1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0Cj4+ IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvbWVkaWF0ZWsvbWVk aWF0ZWssZXRoZHIueQo+PiBhbWwKPj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvZGlzcGxheS9tZWRpYXRlay9tZWRpYXRlayxldGhkci55Cj4+IGFtbAo+Pj4gaW5kZXggODAx ZmE2NmFlNjE1Li42Nzc4ODIzNDhlZGUgMTAwNjQ0Cj4+PiAtLS0KPj4gYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9tZWRpYXRlay9tZWRpYXRlayxldGhkci55Cj4+ IGFtbAo+Pj4gKysrCj4+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3Bs YXkvbWVkaWF0ZWsvbWVkaWF0ZWssZXRoZHIueQo+PiBhbWwKPj4+IEBAIC0yMyw3ICsyMywxMSBA QCBkZXNjcmlwdGlvbjoKPj4+Cj4+PiAgICBwcm9wZXJ0aWVzOgo+Pj4gICAgICBjb21wYXRpYmxl Ogo+Pj4gLSAgICBjb25zdDogbWVkaWF0ZWssbXQ4MTk1LWRpc3AtZXRoZHIKPj4+ICsgICAgb25l T2Y6Cj4+PiArICAgICAgLSBjb25zdDogbWVkaWF0ZWssbXQ4MTk1LWRpc3AtZXRoZHIKPj4+ICsg ICAgICAtIGl0ZW1zOgo+Pj4gKyAgICAgICAgICAtIGNvbnN0OiBtZWRpYXRlayxtdDgxODgtZGlz cC1ldGhkcgo+Pj4gKyAgICAgICAgICAtIGNvbnN0OiBtZWRpYXRlayxtdDgxOTUtZGlzcC1ldGhk cgo+Pj4KPj4KPj4gSXMgTVQ4MTg4J3MgRVRIRFIgZnVsbHkgY29tcGF0aWJsZSB3aXRoIE1UODE5 NSdzIEVUSERSPwo+Pgo+PiBJZiBpdCBpcywgeW91J3JlIG5vdCBhZGRpbmcgYSBtdDgxODggc3Bl Y2lmaWMgY29tcGF0aWJsZSBzdHJpbmcgaW4KPj4gdGhlIGRyaXZlciBhbmQKPj4gdGhpcyBtZWFu cyB0aGF0IHRoZSBkZXZpY2V0cmVlIHdpbGwgbG9vayBsaWtlOgo+Pgo+PiBjb21wYXRpYmxlID0g Im1lZGlhdGVrLG10ODE5NS1kaXNwLWV0aGRyIiwgIm1lZGlhdGVrLG10ODE4OC1kaXNwLQo+PiBl dGhkciIKPj4KPj4gLi4uc28gdGhlIHByb3Bvc2VkIGRvYyBjaGFuZ2Ugd29ya3MuCj4+Cj4+IFJl dmlld2VkLWJ5OiBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyA8Cj4+IGFuZ2Vsb2dpb2FjY2hp bm8uZGVscmVnbm9AY29sbGFib3JhLmNvbT4KPj4KPj4+ICAgICAgcmVnOgo+Pj4gICAgICAgIG1h eEl0ZW1zOiA3Cj4+PiAtLQo+Pj4gMi4xOC4wCj4+Pgo+Pgo+PgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11979EB64D9 for ; Thu, 15 Jun 2023 07:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243762AbjFOHiR (ORCPT ); Thu, 15 Jun 2023 03:38:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244192AbjFOHiH (ORCPT ); Thu, 15 Jun 2023 03:38:07 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C534E26B0; Thu, 15 Jun 2023 00:37:42 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 22C456606F57; Thu, 15 Jun 2023 08:36:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686814610; bh=LKh3/K++ffNF/AmhFmt1beqCBIT5fIwS1jSCTqbyqDI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gr0uhLjDP3FkXRGO3mjV/ksfm1Gc9ctX7XQsIC90QRgClzsyzFOlitxUYypzdlbMi 76VM+QpyrDwoLufsZX11AlQZiska4ko9rQUvXF0hjLGNkqef+JQsQKLblJoQ7A8Y7A kk8AVCse0DLXFJN86tgONSQmw6bKWr434KeiwLCKQj5z8CZqrNRnECojIrtwHjPnNc 24aWVEBFzVa657fisKnYqjvv4B0fLMQ3jVT+TbxbJPA/2gXbMZTgMI+irPexG9r033 +Eq2+/apzCvXELNEat2utZ+V4PbOeRoQypEStqHHsxyW0+PtSHtB5Q/oVrk2ToALfZ PzrJ9i/AWyLWA== Message-ID: <938c740e-8196-ca0f-b53f-a0e33722e25c@collabora.com> Date: Thu, 15 Jun 2023 09:36:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2 01/15] dt-bindings: display: mediatek: ethdr: Add compatible for MT8188 Content-Language: en-US To: =?UTF-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= , "p.zabel@pengutronix.de" , "matthias.bgg@gmail.com" , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "devicetree@vger.kernel.org" , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" References: <20230614073125.17958-1-shawn.sung@mediatek.com> <20230614073125.17958-2-shawn.sung@mediatek.com> <1f044902-0726-34ed-3eea-7224e5750e22@collabora.com> <6c24ad522f42ce35bf387bae1b8a029f58bb0e01.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <6c24ad522f42ce35bf387bae1b8a029f58bb0e01.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 15/06/23 07:51, Shawn Sung (宋孝謙) ha scritto: > Hi Angelo, > > Yes, MT8188 ETHDR is fully compatible with MT8195, so we didn't add its > compatible name to the driver but just listed it in dt-bindings. > > May I double check with you that > I see there is a short description regarding "items" object: >> # items is a list of possible values for the property. The number of >> # values is determined by the number of elements in the list. >> # Order in lists is significant, order in dicts is not > in https://docs.kernel.org/devicetree/bindings/writing-schema.html > > So does the compatible has to be: > "mediatek,mt8188-disp-ethdr", "mediatek,mt8195-disp- > ethdr" rather than in reversed order? > > However, I couldn't find any description mentions the order in > Documentation/devicetree/bindings/writing-schema.rst > Not sure if the order in "items" object does not matter after then. > No the order doesn't matter in that sense. If you check the other bindings, you'll see that the rule is to order by name, which your change as well does. It's fine. P.S.: In case you didn't know, `make dt_binding_check` and `make dtbs_check` will validate your bindings and your devicetrees against the bindings. Regards, Angelo > Thanks, > Hsiao Chien Sung > > > On Wed, 2023-06-14 at 13:41 +0200, AngeloGioacchino Del Regno wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> Il 14/06/23 09:31, Hsiao Chien Sung ha scritto: >>> Add compatible name for MediaTek MT8188 ETHDR. >>> >>> Signed-off-by: Hsiao Chien Sung >>> --- >>> .../bindings/display/mediatek/mediatek,ethdr.yaml | 6 >> +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git >> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.y >> aml >> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.y >> aml >>> index 801fa66ae615..677882348ede 100644 >>> --- >> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.y >> aml >>> +++ >> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.y >> aml >>> @@ -23,7 +23,11 @@ description: >>> >>> properties: >>> compatible: >>> - const: mediatek,mt8195-disp-ethdr >>> + oneOf: >>> + - const: mediatek,mt8195-disp-ethdr >>> + - items: >>> + - const: mediatek,mt8188-disp-ethdr >>> + - const: mediatek,mt8195-disp-ethdr >>> >> >> Is MT8188's ETHDR fully compatible with MT8195's ETHDR? >> >> If it is, you're not adding a mt8188 specific compatible string in >> the driver and >> this means that the devicetree will look like: >> >> compatible = "mediatek,mt8195-disp-ethdr", "mediatek,mt8188-disp- >> ethdr" >> >> ...so the proposed doc change works. >> >> Reviewed-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> >>> reg: >>> maxItems: 7 >>> -- >>> 2.18.0 >>> >> >>