From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: Re: [PATCH] crypto/aesni_mb: fix zero burst dequeue Date: Mon, 17 Jul 2017 11:16:47 +0100 Message-ID: <938c99a3-920c-1997-e1fa-b2fe7ff024ed@intel.com> References: <20170714064848.54333-1-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, stable@dpdk.org To: Pablo de Lara Return-path: In-Reply-To: <20170714064848.54333-1-pablo.de.lara.guarch@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14/07/2017 7:48 AM, Pablo de Lara wrote: > In the unlikely scenario that an application > calls rte_cryptodev_dequeue_burst with nb_ops = 0, > there was a job leak, as a job would be created > but would not be populated, as no operation is passed. > > Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue") > Cc: stable@dpdk.org > > Signed-off-by: Pablo de Lara > --- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > index 13cffaf..fda662f 100644 > --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > @@ -644,6 +644,9 @@ aesni_mb_pmd_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops, > > int retval, processed_jobs = 0; > > + if (unlikely(nb_ops == 0)) > + return 0; > + > do { > /* Get next operation to process from ingress queue */ > retval = rte_ring_dequeue(qp->ingress_queue, (void **)&op); > Acked-by: Declan Doherty