From: Markus Elfring <Markus.Elfring@web.de>
To: Daniel Okazaki <dtokazaki@google.com>,
kernel-team@android.com, linux-i2c@vger.kernel.org,
kernel-janitors@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] eeprom: at24: fix memory corruption race condition
Date: Sat, 20 Apr 2024 11:11:05 +0200 [thread overview]
Message-ID: <939095cb-b9c0-4214-9429-7b45f9a31f36@web.de> (raw)
In-Reply-To: <20240419191200.219548-1-dtokazaki@google.com>
> If the eeprom is not accessible, an nvmem device will be registered, the
> read will fail, and the device will be torn down.
…
Can it be nicer to present the introduction for failure conditions as an enumeration?
> Move the failure point before registering the nvmem device.
…
I would interpret the diff data more in the way that a devm_nvmem_register() call
should be performed a bit later in the implementation of the function “at24_probe”.
How do you think about to mention the affected function also in the summary phrase?
> ---
…
Please add a version description for your change approach.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc4#n713
Regards,
Markus
next prev parent reply other threads:[~2024-04-20 9:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 23:06 [PATCH v1] at24: fix memory corruption race condition Daniel Okazaki
2024-04-17 23:59 ` Bartosz Golaszewski
2024-04-18 0:23 ` Bartosz Golaszewski
2024-04-18 17:13 ` Daniel Okazaki
2024-04-18 17:15 ` Daniel Okazaki
2024-04-18 17:17 ` Bartosz Golaszewski
2024-04-19 18:31 ` [PATCH v2] eeprom: " Daniel Okazaki
2024-04-19 19:04 ` Markus Elfring
2024-04-19 19:12 ` [PATCH v3] " Daniel Okazaki
2024-04-20 6:15 ` Greg Kroah-Hartman
2024-04-20 9:11 ` Markus Elfring [this message]
2024-04-20 10:04 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2024-04-22 17:43 Daniel Okazaki
2024-04-22 22:09 ` Greg Kroah-Hartman
2024-04-23 8:14 ` Bartosz Golaszewski
2024-04-23 6:15 ` Markus Elfring
2024-04-23 8:13 ` Bartosz Golaszewski
2024-04-23 8:15 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=939095cb-b9c0-4214-9429-7b45f9a31f36@web.de \
--to=markus.elfring@web.de \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=dtokazaki@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.