All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Simon Marchi <simon.marchi@ericsson.com>,
	Philippe Proulx <pproulx@efficios.com>
Cc: diamon-discuss@lists.linuxfoundation.org
Subject: Re: [diamon-discuss] Common Trace Format 1.9 planning
Date: Wed, 25 Mar 2015 21:00:43 +0000 (UTC)	[thread overview]
Message-ID: <939295554.103805.1427317243385.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <987784607.103695.1427316285128.JavaMail.zimbra@efficios.com>

Philippe might want to chime in.

----- Original Message -----
> ----- Original Message -----
> > On 15-03-25 03:22 PM, Mathieu Desnoyers wrote:
> > > > This is great, so v1.9 is a superset of 1.8.
> > >
> > > No. A superset would be a completely backward compatible 1.9.
> > > This is not the case here. We plan to do incompatible changes
> > > within 1.9, hence the 1.8 and 1.9 parsers needed. Since the
> > > version is self-described, it should not be an issue to detect
> > > the CTF version from the trace metadata.
> > 
> > From what I understand, it means that a reader for 1.9 won't be able to
> > read
> > a 1.8 trace, is that right?
> 
> Yes, we plan to add incompatible grammar changes. This might have to be
> versioned as 2.0 then. However, we can have side-by-side implementations
> of CTF 1.8 and 2.0 readers within a trace reading lib, and therefore
> distinguish between those, and use the proper CTF reader implementation.
> 
> > 
> > Do the version numbers mean something? If introducing non backward
> > compatible
> > changes only bumps the minor version, what could ever bump the major?
> 
> Good question! In this case, we might be talking about a CTF 2.0 then,
> since we are planning non-compatible changes.
> 
> > 
> > If they don't have one already, this could be an opportunity to give a
> > meaning
> > to the numbers. The major could be for breaking backward compatibility,
> > while
> > the minor could be for backward-compatible changes. It would mean that a
> > reader
> > for x.y should be able to read any x.z trace, where z <= y. In other words,
> > the
> > x.y format would be a superset of x.z (I think?). Much like semver.org, but
> > without the PATCH level.
> 
> Yes, I think it's a good approach.
> 
> We have been hesitating between moving from CTF 1.8 to either 1.9 or 2.0.
> Here are the upsides/downsides of each approach:
> 
> * 1.8 to 1.9:
>   + Compatibility: New CTF 1.9 readers would be able to read CTF 1.8 traces,
>   - Incompatibility: CTF 1.8 readers would not be able to read CTF 1.9
>   traces,
>   - Complexity: The CTF 1.9 specification would need to be an exact subset
>     of 1.8, which means a more complex spec, grammar, and implementations,
> 
> * 1.8 to 2.0:
>   + Compability: Since we're keeping the version headers, a trace reader
>     can implement parsers for both CTF 1.8 and 2.0, and read both trace
>     formats without requiring user interaction,
>   - Incompatibility: CTF 1.8 readers would not be able to read CTF 2.0
>   traces,
>   + Simplicity: New CTF 2.0 readers would be simpler, since they would not
>     need to read CTF 1.8 traces,
> 
> Since the user-visible impacts of bumping from 1.8 to 1.9 or from 1.8 to 2.0
> appear to be the same for existing implementations of the spec, I am really
> tempted to bump to 2.0 at this stage. Already having the version number in
> the header makes the transition so much easier to manage.
> 
> Thoughts ?
> 
> Thanks!
> 
> Mathieu
> 
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
> _______________________________________________
> diamon-discuss mailing list
> diamon-discuss@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/diamon-discuss
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

  reply	other threads:[~2015-03-25 21:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <470558667.103090.1427308587048.JavaMail.zimbra@efficios.com>
2015-03-25 18:39 ` [diamon-discuss] Common Trace Format 1.9 planning Mathieu Desnoyers
2015-03-25 19:09   ` Matthew Khouzam
2015-03-25 19:22     ` Mathieu Desnoyers
2015-03-25 19:40       ` Simon Marchi
2015-03-25 20:44         ` Mathieu Desnoyers
2015-03-25 21:00           ` Mathieu Desnoyers [this message]
2015-03-25 21:41             ` Philippe Proulx
2015-03-25 23:07               ` Philippe Proulx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=939295554.103805.1427317243385.JavaMail.zimbra@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=diamon-discuss@lists.linuxfoundation.org \
    --cc=pproulx@efficios.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.