From: Paolo Abeni <pabeni@redhat.com>
To: Chengfeng Ye <nicoyip.dev@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: pktgen: return bool from __pktgen_NN_threads()
Date: Thu, 27 Aug 2026 10:16:06 +0200 [thread overview]
Message-ID: <9397cfcc-03ee-4269-a9f9-97df1f454ebd@redhat.com> (raw)
In-Reply-To: <20260825185313.239861-1-nicoyip.dev@gmail.com>
On 8/25/26 8:53 PM, Chengfeng Ye wrote:
> Callers of __pktgen_NN_threads() only check whether a pktgen_dev was
> found. After the RCU lookup they never dereference the returned
> pointer, so returning it past rcu_read_unlock() is confusing.
>
> Return bool instead and keep the pktgen_dev pointer local to the
> RCU critical section.
>
> Suggested-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Chengfeng Ye <nicoyip.dev@gmail.com>
## Form letter - net-next-closed
net-next pull request for v7.3 has already been merged, and therefore
the net-next tree is closed for new drivers, features, code refactoring
and optimizations. We are currently accepting bug fixes only.
Please repost when net-next reopens after Aug 31st.
RFC patches sent for review only are obviously welcome at any time.
See:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer
pv-bot: closed
next prev parent reply other threads:[~2026-08-27 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 15:23 [PATCH net] net: pktgen: keep device lookup under RCU protection Chengfeng Ye
2026-08-24 15:38 ` Eric Dumazet
2026-08-25 10:45 ` Paolo Abeni
2026-08-25 18:55 ` Chengfeng Ye
2026-08-25 18:53 ` [PATCH net-next] net: pktgen: return bool from __pktgen_NN_threads() Chengfeng Ye
2026-08-27 8:16 ` Paolo Abeni [this message]
2026-09-27 14:07 ` Chengfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9397cfcc-03ee-4269-a9f9-97df1f454ebd@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicoyip.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.