All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Schmidt <flosch@nutanix.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@mailo.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] Add option to disable building tests
Date: Mon, 27 Jul 2026 10:05:40 +0100	[thread overview]
Message-ID: <939dd72d-80cd-4cd7-b9d2-e245afbaefeb@nutanix.com> (raw)
In-Reply-To: <amcbxTQXOwIJPPpo@redhat.com>



On 2026-07-27 09:50, Daniel P. Berrangé wrote:
> I would suggest that building a second time is wasted effort too. If
> the 2nd build is byte-for-byte identical to the 1st build, then it is
> pointless. If it is not byte-for-byte identical, then you'll be taking
> binaries that have not been tested.

You're absolutely right. They are bit-to-bit-identical, and it is wasted 
effort, too. That is something we'll look at internally.

However, it felt like a genuinely useful feature to split build and test 
phase more strongly, by having the ability to only build the product 
binaries if desired.

There are other options, of course. A new build target such as "make 
bin" or similar could only build the product binaries, and a following 
"make test" would then build + run the tests. This could be combined 
with Philippe's idea to run (and not only build) the tests by default, 
though I'm always wary of changing the behaviour of default targets. 
That's obviously a maintainers' decision.

Cheers,
Florian


  reply	other threads:[~2026-07-27  9:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24 13:54 [PATCH] Add option to disable building tests Florian Schmidt
2026-07-24 16:45 ` Pierrick Bouvier
2026-07-27  8:12   ` Philippe Mathieu-Daudé
2026-07-27  8:46     ` Florian Schmidt
2026-07-27  8:50       ` Daniel P. Berrangé
2026-07-27  9:05         ` Florian Schmidt [this message]
2026-07-27  9:11     ` Thomas Huth
2026-07-27 11:19       ` BALATON Zoltan
2026-07-27 14:24         ` Philippe Mathieu-Daudé
2026-07-27 15:15           ` Fabiano Rosas
2026-07-27 15:23             ` Peter Maydell
2026-07-27 16:29               ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=939dd72d-80cd-4cd7-b9d2-e245afbaefeb@nutanix.com \
    --to=flosch@nutanix.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@mailo.com \
    --cc=philmd@oss.qualcomm.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.