All of lore.kernel.org
 help / color / mirror / Atom feed
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>, Lixu Zhang <lixu.zhang@intel.com>,
	Arnd Bergmann <arnd@kernel.org>, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion
Date: Thu, 30 May 2024 20:49:15 -0700	[thread overview]
Message-ID: <93a4b3f093a3105c4731fdac37cc1964b266302c.camel@linux.intel.com> (raw)
In-Reply-To: <508d40bb-f2df-469a-9f94-58b41a28f53a@app.fastmail.com>

On Wed, 2024-05-29 at 15:18 +0200, Arnd Bergmann wrote:
> On Wed, May 29, 2024, at 09:05, Zhang, Lixu wrote:
> 
> > > 
> > > 	for (i = 0; i < fragment->fragment_cnt && offset <
> > > ish_fw->size; i++) {
> > You added a parameter fragment_count, but you didn't use it. Did
> > you 
> > intend to use it here?
> > 
> 
> My mistake, that was again broken in my incorrect
> rebase.
> 
Do you have updated patch? Lixu can try and make sure that the
functionality is not broken by changes.

Thanks,
Srinivas

>      Arnd


  reply	other threads:[~2024-05-31  3:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 11:57 [PATCH 1/2] HID: intel-ish-hid: fix cache management mistake Arnd Bergmann
2024-05-28 11:57 ` [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion Arnd Bergmann
2024-05-28 12:45   ` Arnd Bergmann
2024-05-28 21:06   ` kernel test robot
2024-05-28 21:17   ` kernel test robot
2024-05-29  7:05   ` Zhang, Lixu
2024-05-29 13:18     ` Arnd Bergmann
2024-05-31  3:49       ` srinivas pandruvada [this message]
2024-05-31 16:29         ` Arnd Bergmann
2024-05-29  6:46 ` [PATCH 1/2] HID: intel-ish-hid: fix cache management mistake Zhang, Lixu
2024-05-29  7:06   ` Arnd Bergmann
2024-05-29 22:25     ` srinivas pandruvada
2024-05-30  7:41       ` Zhang, Lixu
2024-05-31  8:51       ` Zhang, Lixu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93a4b3f093a3105c4731fdac37cc1964b266302c.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixu.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.