From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F06D5499F21 for ; Thu, 27 Aug 2026 18:10:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787854206; cv=none; b=uKNm0R+nr7zYW3zfqjQWguGZfgEe4TpRsAQKqrDRJ30kWIyMlka7gPhyvl2r/waZ/YUsX1rdRXysa+7zdxCSMVekRRzJkRjPKsBsfpd/sEHAQwZEg5VX1pMUsthEbpTOroH/urAL3mtVVNmp7AfT70H5uBSxqZZrHBPs8aEfhnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787854206; c=relaxed/simple; bh=8z7mNlPzoQwnfVSdIFR7CDKyD6KPFQ2Mjh2ASGykRbs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=krZZxnov4b1t14WrrKDR59w7ik8N28Ey/KMCjzzH/u3HiiwuPvel9RQQbuQeknJXcjVSAW6zMVhraWgsuHukg9DAqKc2JyFL26Z7cxspydnNe/CpfKlBjoN7TkpgAGEl2TQT2OiinC/GIl/nvf9UDGa4K+jiN5C30FTXoq/BOAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dE/isKpB; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dE/isKpB" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-cc1e1ff659bso184965a12.0 for ; Thu, 27 Aug 2026 11:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787854204; x=1788459004; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bsSqKCxu1aiUq+LFG5GddEFJLmJcMTVHCUjI3Qe8EB0=; b=dE/isKpBOo1NXZh+MNJs+Xmh86SAjNuwQhTQQkPrl606yIY7mT3Fmhuxis1ULUGVsm /E0DPyYtyZZeY5lQsFszj80BnkmSov/R9t0jMee7JkuPVJtd5VyQxOrRl1cbth8fL1PC 43MPUF1sBKnoAy57HTIMEaRfkWimw0nSTKQ2HNY6ZEJSkCQIKloblGn6u6uGFgVUv2lj BKbmPnmxfTXfpqccCLKUZF2Nz0ELVsG5G+iDg+Usqa4gIeibbgT+f5jgZj164DA6G37Q vjp13XJaO8Lkbvo6wLS4jd8oXl55WIVpmCpB8xApS1jwJuaynOHCHKJLqKve4vaN+bZv dexQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787854204; x=1788459004; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=bsSqKCxu1aiUq+LFG5GddEFJLmJcMTVHCUjI3Qe8EB0=; b=mho3TVNeWt8DICvyo0zvKD6PoVyn4aymkcF6OcUp/fG7ffHFNy9m2Ep+jufbDhazi2 xkyoJRN1a2SYTXO68V5KCDeG12Z974klyDclL+3op5Akhohuc96a6fx1zfn7C4W5c8RX C/i1G3vvLjoqYfQxNrfNKYAZira81Gk2fBOY4QuVOSdW+m3EeDORnJw1WVZ22hoeZkws yotwnXtmHTid5/ZrgRmSsVFrwpRgyJGuij0SHBM4IrzpFSJuuW5OuJjsMC+8DQ17jsWV g0kmkpRKateg14x1KizXtIEaUftM8vNtYZy6tK4yUbvVYwSxMydRV2Wl5rwvMTcUf/93 Jy+g== X-Forwarded-Encrypted: i=1; AHgh+RpehTQvJnKvF4G3VAueBC7k3UqhnH589fZgzhgUTv3cGUXPGWvFzDAl1JKzxtbYKSYo/8MqD7xWchyt5yUGdg==@vger.kernel.org X-Gm-Message-State: AFuF++lkRKsqBtFvnkcln8p9W9lsQcloVe+KYWFxoRA8Ni4Y15xaydGv Ni8iOxUKV125r2wFvcmnKbJfjJPdniau+phH87sME/OZRbR1pdTEQ1WONCfB/A== X-Gm-Gg: AR+sD13sfaO3rU68lW1Rf+Omxxs/Azg3Q/8O4Lu4oaSOYpN/O4HhODIWPx5fvy7yH2F IJSO67q55OTMUU9KJc/yintmzNRj4CrQcBvM+zQ2hHZ8AkYQXuw2XM/ooyzJfLviguoTQI7PHhq UbOXIgcdIdup1Sx8Xq9ykzDDkIRnuGRUlXeS4xy5oMZvSUvMWwiXMKihKs455BajXxRyF0V/Rqm zpbGpYvyr28MPhZBV8wAzNcB6Kau8A8+iKAXGH1QbUfT1b8YF05aTFETkOr5kAYa+zF1KGui/Md iCbRlw7tdkLDbm80nCnIm6KJP7vFTt/3MPQDAXJkM8jP3hN1Qe/Bo+RleILn+DTBdx4IqvzIlpR xEZw29l5u5cSVSV4IYe3elqT820iEmDFsjCLg7ob7rnCqBkDlUp2NvtQpu4qHVgPHn5+nOqKVwb 9Ua1ly3J5jEawfekwUH5/t8gOs5LzlVIpb7LOuyDtmxQoHHCukuWTLcSvsgMlikXPkx+I/e3j0n d0+uyiS0VFu7q+pcysHHucPZP04TYKjB75tNQ== X-Received: by 2002:a05:6a20:cd95:b0:3d1:ae83:6fc2 with SMTP id adf61e73a8af0-3d2686a88dfmr1663623637.9.1787854204218; Thu, 27 Aug 2026 11:10:04 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc1beae5b51sm2502401a12.3.2026.08.27.11.10.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2026 11:10:03 -0700 (PDT) Sender: Guenter Roeck Message-ID: <93d22742-bf3e-4e69-aed5-27137d8f49bf@roeck-us.net> Date: Thu, 27 Aug 2026 11:10:02 -0700 Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Differentiate scenarios when watchdog is closed To: chaithco@redhat.com Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260824205051.4117285-2-chaithco@redhat.com> <2bd566ca-2696-46d3-aeec-57db66fa1902@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/27/26 10:09, chaithco@redhat.com wrote: > > > On Thu, Aug 27 2026 at 09:01:47 AM -07:00:00, Guenter Roeck wrote: >> Presently >> [...] >> Also, the subject should start with the subsystem name ("watchdog:") >> [...] >> deliberately > > Thank you for catching these! Please accept my apologies. I can fix those up in the next submission. > >> [...] Also, while technically userspace may close the >> watchdog deliberately while it is running, that is not what happens >> on a regular basis. > > This is actually what initiated a bug report at https://bugzilla.redhat.com/show_bug.cgi?id=1991285 it turns out systemd explicitly does this to help ensure a system shutting down actually eventually goes down even if the shutdown process hits some snags. It does this on every shutdown. Given the prevalence of systemd, this is a regular occurrence. The end result is that, when using iTCO, it shows an error on every shutdown when systemd is in use as init. > >> If you want to make a change, I would suggest to add an error message >> into watchdog_stop() to report an error if the stop callback returns >> an error. That would distinguish 2/3 without making functional changes. > > Thank you! So something like this? > >        if (wdd->ops->stop) { >                clear_bit(WDOG_HW_RUNNING, &wdd->status); >                err = wdd->ops->stop(wdd); > +               if (err < 0) > +                       pr_info("watchdog%d: closed while still enabled!\n"); More like pr_err(""watchdog%d: Failed to stop watchdog: %pe\n", wdd->id, ERR_PTR(err)); since this would be a real error. The "watchdog%d: watchdog did not stop!" message will then follow (unconditionally). >                trace_watchdog_stop(wdd, err); >        } else { >                set_bit(WDOG_HW_RUNNING, &wdd->status); > > > While responding to this, an additional thought occurred to me; given the primary reason a user would see this is because systemd is shutting down a system, it may be more worth while to have systemd log something about closing the watchdog without disarming it to at least explain a pr_crit kernel log line. Otherwise, it just looks like "something bad happened" with watchdog. I am additionally unsure of what would be best to go in watchdog_stop that helps differentiate intentional closing of the watchdog without disabling vs malicious/accidental closing. The intent would lie within the entity closing the watchdog; "closed while still enabled!" still seems like "something bad happened" with info on if it was intentional or not. > Problem is that we don't know if "something bad happened". The same message will be seen if the watchdog daemon was killed or crashed. We can not just assume that closing the watchdog device was intentional. Guenter