From: hangbin.liu@linux.dev
To: "Matthieu Baerts" <matttbe@kernel.org>,
"MPTCP Linux" <mptcp@lists.linux.dev>
Cc: "Hangbin Liu" <liuhangbin@kylinos.cn>
Subject: Re: [PATCH mptcp-next] selftests: mptcp: verify nft JSON support
Date: Thu, 08 Oct 2026 13:45:16 +0000 [thread overview]
Message-ID: <93e09debbb09d20579f3efc127e404dcd775ecee@linux.dev> (raw)
In-Reply-To: <00f4f36f-37ce-4845-a86a-ef190961b843@kernel.org>
October 8, 2026 at 7:09 PM, "Matthieu Baerts" <matttbe@kernel.org> wrote:
>
> Hi Hangbin,
>
> On 08/10/2026 12:00, Hangbin Liu wrote:
>
> >
> > Use --version to check for nft presence, as older nft versions reject -V.
> > Ensure the nft tool has JSON support, since we need JSON output for
> > parsing with jq.
> >
> Thank you for the patch. But do you think it is really needed? 'nft -V'
> as been introduced before MPTCP being upstream, and who is building nft
> without JSON support?
Not really, but ...
>
> As an alternative, I can squash this in "selftests: mptcp: convert
> iptables to nftables for mptcp_sockopt.sh", just to silence Clashiko.
Yes, this is just to silence Clashiko, which report this issue as medium.
Jakub asks to take action for medium+ reports.
And I see you have squashed this. Thanks for your works!
Thanks
Hangbin
next prev parent reply other threads:[~2026-10-08 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 10:00 [PATCH mptcp-next] selftests: mptcp: verify nft JSON support Hangbin Liu
2026-10-08 11:00 ` MPTCP CI
2026-10-08 11:09 ` Matthieu Baerts
2026-10-08 11:55 ` Matthieu Baerts
2026-10-08 13:23 ` hangbin.liu
2026-10-08 13:45 ` hangbin.liu [this message]
2026-10-08 13:48 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93e09debbb09d20579f3efc127e404dcd775ecee@linux.dev \
--to=hangbin.liu@linux.dev \
--cc=liuhangbin@kylinos.cn \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.