All of lore.kernel.org
 help / color / mirror / Atom feed
From: quic_zijuhu <quic_zijuhu@quicinc.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>, Wren Turkal <wt@penguintechs.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	<linux-bluetooth@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional()
Date: Wed, 24 Apr 2024 21:12:09 +0800	[thread overview]
Message-ID: <93e15ecf-252f-4789-a23b-a28280f6aa84@quicinc.com> (raw)
In-Reply-To: <CAMRc=MeDQFHX9r-sHNxqkfpi=LkHoRSL7i6dWokB-J+J03rBEg@mail.gmail.com>

On 4/24/2024 8:27 PM, Bartosz Golaszewski wrote:
> On Wed, Apr 24, 2024 at 2:24 PM Wren Turkal <wt@penguintechs.org> wrote:
>>>>>
>>>>> That's OK, we have the first part right. Let's now see if we can reuse
>>>>> patch 2/2 from Zijun.
>>>>
>>>> I'm compiling it right now. Be back soon.
>>>>
>>>
>>> Well I doubt it's correct as it removed Krzysztof's fix which looks
>>> right. If I were to guess I'd say we need some mix of both.
>>
>> Patch 2/2 remove K's fix? I thought only 1/2 did that.
>>
>> To be specific, I have applied your patch and Zijun's 2/2 only.
>>
> 
> No, patch 1/2 from Zijun reverted my changes. Patch 2/2 removes
> Krzysztof's changes and replaces them with a different if else. This
> patch is a better alternative to Zijun's patch 1/2. For 2/2, I'll let
> Krzysztof handle it.
>
do you really realize what do you talk about?
do you really listen what do @Wren says?

he says that my patch 2/2 is right based on several verification results.

BTW, my 2/2 fix don't have anything about DTS usage.

he maybe be a DTS expert but not BT from his present fix history for
bluetooth system.

> Bart


  parent reply	other threads:[~2024-04-24 13:12 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 13:00 [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional() Bartosz Golaszewski
2024-04-22 13:33 ` bluez.test.bot
2024-04-24  4:05 ` [PATCH] " Krzysztof Kozlowski
2024-04-24  4:55 ` quic_zijuhu
2024-04-24  5:07 ` Wren Turkal
2024-04-24  9:04   ` Bartosz Golaszewski
2024-04-24  9:32     ` quic_zijuhu
2024-04-24  9:50       ` Krzysztof Kozlowski
2024-04-24 11:16     ` Wren Turkal
2024-04-24 11:53       ` Wren Turkal
2024-04-24 11:56         ` Bartosz Golaszewski
2024-04-24 12:09           ` Wren Turkal
2024-04-24 12:17           ` Wren Turkal
2024-04-24 12:20             ` Bartosz Golaszewski
2024-04-24 12:23               ` Bartosz Golaszewski
2024-04-24 12:24               ` Wren Turkal
2024-04-24 12:27                 ` Bartosz Golaszewski
2024-04-24 12:30                   ` Wren Turkal
2024-04-24 12:57                     ` Bartosz Golaszewski
2024-04-24 12:57                   ` Wren Turkal
2024-04-24 13:12                   ` quic_zijuhu [this message]
2024-04-24 13:26                     ` Wren Turkal
2024-04-24 13:30                       ` quic_zijuhu
2024-04-24 22:09                         ` Wren Turkal
2024-04-24 13:53                       ` Bartosz Golaszewski
2024-04-24 22:17                         ` Wren Turkal
2024-04-24 23:35                           ` quic_zijuhu
2024-04-25  2:34                             ` Wren Turkal
2024-04-24 11:25     ` Wren Turkal
2024-04-24 11:53       ` Bartosz Golaszewski
2024-04-24 11:59         ` Wren Turkal
2024-04-24 12:01           ` Bartosz Golaszewski
2024-04-24 12:05             ` Wren Turkal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93e15ecf-252f-4789-a23b-a28280f6aa84@quicinc.com \
    --to=quic_zijuhu@quicinc.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=wt@penguintechs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.