From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A34F4C433F5 for ; Wed, 4 May 2022 11:01:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234082AbiEDLF1 (ORCPT ); Wed, 4 May 2022 07:05:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348461AbiEDLF0 (ORCPT ); Wed, 4 May 2022 07:05:26 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3E96E237D7; Wed, 4 May 2022 04:01:50 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5EA481042; Wed, 4 May 2022 04:01:50 -0700 (PDT) Received: from [10.57.1.74] (unknown [10.57.1.74]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5EBBB3FA50; Wed, 4 May 2022 04:01:48 -0700 (PDT) Message-ID: <93f0e003-e9ce-c37f-e603-ddf22ffec0d6@arm.com> Date: Wed, 4 May 2022 12:01:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3] coresight: core: Fix coresight device probe failure issue To: Jinlong Mao , Mathieu Poirier , Mike Leach , Leo Yan , Alexander Shishkin Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Hao Zhang References: <20220309142206.15632-1-quic_jinlmao@quicinc.com> <9cbb2e86-640f-4b5d-22ff-00c63a1b9743@quicinc.com> <99845680-c2a5-2538-a57c-6fbf395faa8b@arm.com> <0ef5aa68-fc1c-6f0b-a1cb-46c5548952db@quicinc.com> From: Suzuki K Poulose In-Reply-To: <0ef5aa68-fc1c-6f0b-a1cb-46c5548952db@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 15/03/2022 08:52, Jinlong Mao wrote: > > On 3/15/2022 4:42 PM, Suzuki K Poulose wrote: >> On 15/03/2022 08:36, Jinlong Mao wrote: >>> On 3/10/2022 5:10 PM, Suzuki K Poulose wrote: >>>> Hi Jinlong >>>> >>>> >>>> On 09/03/2022 14:22, Mao Jinlong wrote: >>>>> It is possibe that probe failure issue happens when the device >>>>> and its child_device's probe happens at the same time. >>>>> In coresight_make_links, has_conns_grp is true for parent, but >>>>> has_conns_grp is false for child device as has_conns_grp is set >>>>> to true in coresight_create_conns_sysfs_group. The probe of parent >>>>> device will fail at this condition. Add has_conns_grp check for >>>>> child device before make the links and make the process from >>>>> device_register to connection_create be atomic to avoid this >>>>> probe failure issue. >>>>> >>>>> Suggested-by: Suzuki K Poulose >>>>> Suggested-by: Mike Leach >>>>> Signed-off-by: Mao Jinlong >>>> >>>> Thanks for the rework. The patch looks good to me. >>>> >>>> Suzuki >>> Thanks Suzuki. >>> >>> Hi Mathieu & Mike, >>> >>> Could you please help to review and provide your comments for the >>> PATCH V3 ? >> >> Thats what I just said above. The patch looks good to me, I can queue >> this in the next cycle. Queued here: https://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git/commit/?h=next&id=8c1d3f79d9ca48e406b78e90e94cf09a8c076bf2 Cheers Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EA86C433F5 for ; Wed, 4 May 2022 11:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cU7UrKDSKAdJmVX4Ox+0Hs6Z7vAvQSOx6a9faLXZl6M=; b=IUaylchzToJ9dU EYTEgIgEHvrEEMeTexPwvJkm2Pe2cHzHPybx07xwvGt/oWcdZiq/WRl88AN1yYSDQzxiEwHlHxZeL OOthHBOvltl+zF0Od7Qh2XqY2VLCVYQ4kCD9Irr1LUDBTZNb9qugNa6o2N9RIEcPql4W6yrxpCCdl znFWZuifPKH0KpeJIVHOv/CJLlX1J4DIBCqj+94qiupZ3+9TV4MTE/vxHd7BNtoaYlZLjQeYY9CLA LdpIoh7u//2wp9b9psbtX9ZgFa4AOrQFYF/u49hweFty1nS3FruzX3p+jDzLQNZ2+O6u9itK/XHFh qz80YEu7h4bfu96NIBkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmClY-00ANNA-OL; Wed, 04 May 2022 11:01:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmClW-00ANM7-3p for linux-arm-kernel@lists.infradead.org; Wed, 04 May 2022 11:01:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5EA481042; Wed, 4 May 2022 04:01:50 -0700 (PDT) Received: from [10.57.1.74] (unknown [10.57.1.74]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5EBBB3FA50; Wed, 4 May 2022 04:01:48 -0700 (PDT) Message-ID: <93f0e003-e9ce-c37f-e603-ddf22ffec0d6@arm.com> Date: Wed, 4 May 2022 12:01:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3] coresight: core: Fix coresight device probe failure issue To: Jinlong Mao , Mathieu Poirier , Mike Leach , Leo Yan , Alexander Shishkin Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Hao Zhang References: <20220309142206.15632-1-quic_jinlmao@quicinc.com> <9cbb2e86-640f-4b5d-22ff-00c63a1b9743@quicinc.com> <99845680-c2a5-2538-a57c-6fbf395faa8b@arm.com> <0ef5aa68-fc1c-6f0b-a1cb-46c5548952db@quicinc.com> From: Suzuki K Poulose In-Reply-To: <0ef5aa68-fc1c-6f0b-a1cb-46c5548952db@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_040154_245583_1591D1EE X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/03/2022 08:52, Jinlong Mao wrote: > > On 3/15/2022 4:42 PM, Suzuki K Poulose wrote: >> On 15/03/2022 08:36, Jinlong Mao wrote: >>> On 3/10/2022 5:10 PM, Suzuki K Poulose wrote: >>>> Hi Jinlong >>>> >>>> >>>> On 09/03/2022 14:22, Mao Jinlong wrote: >>>>> It is possibe that probe failure issue happens when the device >>>>> and its child_device's probe happens at the same time. >>>>> In coresight_make_links, has_conns_grp is true for parent, but >>>>> has_conns_grp is false for child device as has_conns_grp is set >>>>> to true in coresight_create_conns_sysfs_group. The probe of parent >>>>> device will fail at this condition. Add has_conns_grp check for >>>>> child device before make the links and make the process from >>>>> device_register to connection_create be atomic to avoid this >>>>> probe failure issue. >>>>> >>>>> Suggested-by: Suzuki K Poulose >>>>> Suggested-by: Mike Leach >>>>> Signed-off-by: Mao Jinlong >>>> >>>> Thanks for the rework. The patch looks good to me. >>>> >>>> Suzuki >>> Thanks Suzuki. >>> >>> Hi Mathieu & Mike, >>> >>> Could you please help to review and provide your comments for the >>> PATCH V3 ? >> >> Thats what I just said above. The patch looks good to me, I can queue >> this in the next cycle. Queued here: https://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git/commit/?h=next&id=8c1d3f79d9ca48e406b78e90e94cf09a8c076bf2 Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel