Re: [PATCH 43/83] ASoC: codecs: pcm*: use .auto_selectable_formats

[Kirill Marinushkin <k.marinushkin@gmail.com>]

Hello Kuninori Morimoto,


i looked at the [PATCH 43/83], related to pcm* codecs, it looks good to me!

I don't think i would be able to embrace the whole patchset, but hopefully,

my review will be at least somewhat helpful!


Only one minor thought is that probably `.auto_selectable_formats` for 
`pcm3060.c`

could also include `SND_SOC_POSSIBLE_DAIFMT_NB_NF`, similar to `pcm186x.c`.

But it's a tiny comment, you don't need to take it seriously.

You are doing a massive work, i deeply respect the scope you take on!


Reviewed-by: Kirill Marinushkin <k.marinushkin@gmail.com>


Best regards,

Kirill

---

On 5/26/26 4:19 AM, Kuninori Morimoto wrote:
> We can use .auto_selectable_formats. Let's adds it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>   sound/soc/codecs/pcm1681.c | 7 +++++++
>   sound/soc/codecs/pcm1754.c | 6 ++++++
>   sound/soc/codecs/pcm1789.c | 7 +++++++
>   sound/soc/codecs/pcm179x.c | 6 ++++++
>   sound/soc/codecs/pcm186x.c | 9 +++++++++
>   sound/soc/codecs/pcm3060.c | 7 +++++++
>   sound/soc/codecs/pcm512x.c | 9 +++++++++
>   7 files changed, 51 insertions(+)
>
> diff --git a/sound/soc/codecs/pcm1681.c b/sound/soc/codecs/pcm1681.c
> index cb923cecb47fc..60fdbe5c4e054 100644
> --- a/sound/soc/codecs/pcm1681.c
> +++ b/sound/soc/codecs/pcm1681.c
> @@ -199,10 +199,17 @@ static int pcm1681_hw_params(struct snd_pcm_substream *substream,
>   	return pcm1681_set_deemph(component);
>   }
>   
> +static const u64 pcm1681_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J;
> +
>   static const struct snd_soc_dai_ops pcm1681_dai_ops = {
>   	.set_fmt	= pcm1681_set_dai_fmt,
>   	.hw_params	= pcm1681_hw_params,
>   	.mute_stream	= pcm1681_mute,
> +	.auto_selectable_formats	= &pcm1681_selectable_formats,
> +	.num_auto_selectable_formats	= 1,
>   	.no_capture_mute = 1,
>   };
>   
> diff --git a/sound/soc/codecs/pcm1754.c b/sound/soc/codecs/pcm1754.c
> index b68a528000be8..bb15da1c24aa2 100644
> --- a/sound/soc/codecs/pcm1754.c
> +++ b/sound/soc/codecs/pcm1754.c
> @@ -78,10 +78,16 @@ static int pcm1754_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
>   	return 0;
>   }
>   
> +static const u64 pcm1754_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J;
> +
>   static const struct snd_soc_dai_ops pcm1754_dai_ops = {
>   	.set_fmt = pcm1754_set_dai_fmt,
>   	.hw_params = pcm1754_hw_params,
>   	.mute_stream = pcm1754_mute_stream,
> +	.auto_selectable_formats = &pcm1754_selectable_formats,
> +	.num_auto_selectable_formats = 1,
>   };
>   
>   static const struct snd_soc_dai_driver pcm1754_dai = {
> diff --git a/sound/soc/codecs/pcm1789.c b/sound/soc/codecs/pcm1789.c
> index 3ab381e9a8566..f06e353743aaa 100644
> --- a/sound/soc/codecs/pcm1789.c
> +++ b/sound/soc/codecs/pcm1789.c
> @@ -164,11 +164,18 @@ static int pcm1789_trigger(struct snd_pcm_substream *substream, int cmd,
>   	return ret;
>   }
>   
> +static const u64 pcm1789_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J;
> +
>   static const struct snd_soc_dai_ops pcm1789_dai_ops = {
>   	.set_fmt	= pcm1789_set_dai_fmt,
>   	.hw_params	= pcm1789_hw_params,
>   	.mute_stream	= pcm1789_mute,
>   	.trigger	= pcm1789_trigger,
> +	.auto_selectable_formats	= &pcm1789_selectable_formats,
> +	.num_auto_selectable_formats	= 1,
>   	.no_capture_mute = 1,
>   };
>   
> diff --git a/sound/soc/codecs/pcm179x.c b/sound/soc/codecs/pcm179x.c
> index f52ff66b6e644..cb70927872aa0 100644
> --- a/sound/soc/codecs/pcm179x.c
> +++ b/sound/soc/codecs/pcm179x.c
> @@ -142,10 +142,16 @@ static int pcm179x_hw_params(struct snd_pcm_substream *substream,
>   	return 0;
>   }
>   
> +static const u64 pcm179x_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J;
> +
>   static const struct snd_soc_dai_ops pcm179x_dai_ops = {
>   	.set_fmt	= pcm179x_set_dai_fmt,
>   	.hw_params	= pcm179x_hw_params,
>   	.mute_stream	= pcm179x_mute,
> +	.auto_selectable_formats	= &pcm179x_selectable_formats,
> +	.num_auto_selectable_formats	= 1,
>   	.no_capture_mute = 1,
>   };
>   
> diff --git a/sound/soc/codecs/pcm186x.c b/sound/soc/codecs/pcm186x.c
> index 0d1103fe4e04d..461ec74e87521 100644
> --- a/sound/soc/codecs/pcm186x.c
> +++ b/sound/soc/codecs/pcm186x.c
> @@ -473,11 +473,20 @@ static int pcm186x_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
>   	return 0;
>   }
>   
> +static const u64 pcm186x_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_B	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_NF;
> +
>   static const struct snd_soc_dai_ops pcm186x_dai_ops = {
>   	.set_sysclk = pcm186x_set_dai_sysclk,
>   	.set_tdm_slot = pcm186x_set_tdm_slot,
>   	.set_fmt = pcm186x_set_fmt,
>   	.hw_params = pcm186x_hw_params,
> +	.auto_selectable_formats = &pcm186x_selectable_formats,
> +	.num_auto_selectable_formats = 1,
>   };
>   
>   static struct snd_soc_dai_driver pcm1863_dai = {
> diff --git a/sound/soc/codecs/pcm3060.c b/sound/soc/codecs/pcm3060.c
> index 8974200652e7e..5fb344c6d8d90 100644
> --- a/sound/soc/codecs/pcm3060.c
> +++ b/sound/soc/codecs/pcm3060.c
> @@ -164,10 +164,17 @@ static int pcm3060_hw_params(struct snd_pcm_substream *substream,
>   	return 0;
>   }
>   
> +static const u64 pcm3060_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J;
> +
>   static const struct snd_soc_dai_ops pcm3060_dai_ops = {
>   	.set_sysclk = pcm3060_set_sysclk,
>   	.set_fmt = pcm3060_set_fmt,
>   	.hw_params = pcm3060_hw_params,
> +	.auto_selectable_formats = &pcm3060_selectable_formats,
> +	.num_auto_selectable_formats = 1,
>   };
>   
>   #define PCM3060_DAI_RATES_ADC	(SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_32000 | \
> diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c
> index a70e8ea166dc5..981a2e56fa724 100644
> --- a/sound/soc/codecs/pcm512x.c
> +++ b/sound/soc/codecs/pcm512x.c
> @@ -1505,12 +1505,21 @@ static int pcm512x_mute(struct snd_soc_dai *dai, int mute, int direction)
>   	return ret;
>   }
>   
> +static const u64 pcm512x_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_LEFT_J	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_B;
> +
>   static const struct snd_soc_dai_ops pcm512x_dai_ops = {
>   	.startup = pcm512x_dai_startup,
>   	.hw_params = pcm512x_hw_params,
>   	.set_fmt = pcm512x_set_fmt,
>   	.mute_stream = pcm512x_mute,
>   	.set_bclk_ratio = pcm512x_set_bclk_ratio,
> +	.auto_selectable_formats = &pcm512x_selectable_formats,
> +	.num_auto_selectable_formats = 1,
>   	.no_capture_mute = 1,
>   };
>